aboutsummaryrefslogtreecommitdiffhomepage
path: root/tensorflow/core/kernels/cholesky_op.cc
diff options
context:
space:
mode:
authorGravatar A. Unique TensorFlower <gardener@tensorflow.org>2017-06-02 16:06:51 -0700
committerGravatar TensorFlower Gardener <gardener@tensorflow.org>2017-06-02 16:11:24 -0700
commit0c92dada6a0790d4c0cbd54ce4c801b1940dc4ed (patch)
tree7290bb50ca665ee6f93b13940b5375971d0dda3a /tensorflow/core/kernels/cholesky_op.cc
parenta4caeb2ea4ba4229ea8444e8eda32b7dba57658c (diff)
Use inplace Cholesky factorization and solves to speed up and reduce memory usage in matrix_solve_ls.
Check succes before copying outputs in cholesky_op. PiperOrigin-RevId: 157887564
Diffstat (limited to 'tensorflow/core/kernels/cholesky_op.cc')
-rw-r--r--tensorflow/core/kernels/cholesky_op.cc6
1 files changed, 3 insertions, 3 deletions
diff --git a/tensorflow/core/kernels/cholesky_op.cc b/tensorflow/core/kernels/cholesky_op.cc
index 5c7102f6f6..755ce7c43b 100644
--- a/tensorflow/core/kernels/cholesky_op.cc
+++ b/tensorflow/core/kernels/cholesky_op.cc
@@ -64,11 +64,11 @@ class CholeskyOp : public LinearAlgebraOp<Scalar> {
Eigen::Matrix<Scalar, Eigen::Dynamic, Eigen::Dynamic, Eigen::RowMajor>>
llt_decomposition(input);
- // Output the lower triangular in a dense form.
- outputs->at(0) = llt_decomposition.matrixL();
-
OP_REQUIRES(context, llt_decomposition.info() == Eigen::Success,
errors::InvalidArgument(kErrMsg));
+
+ // Output the lower triangular in a dense form.
+ outputs->at(0) = llt_decomposition.matrixL();
}
};