diff options
| author |  A. Unique TensorFlower <gardener@tensorflow.org> | 2018-09-18 13:28:38 -0700 |
|---|---|---|
| committer | TensorFlower Gardener <gardener@tensorflow.org> | 2018-09-18 13:33:19 -0700 |
| commit | 33170cc661f3838aa7d0d7fc19bb0c6ba4812a3c (patch) | |
| tree | c33a2e11456e70c60526e65569956567b4f84cb3 /tensorflow/core/BUILD | |
| parent | 199cb7746c7ad92d7be344363d8276c45fc7a4b8 (diff) | |
Eliminate VisitableAllocator.
The visitor pattern is used to allow pre-registration of memory for
DMA access, e.g. for fast GPU/CPU i/o and for RDMA networking. The
VisitableAllocator interface was introduced to support this use some
time ago, prior to SubAllocators. Memory registration works best if
it's done infrequently, on large pieces of memory, rather than on
every piece that's dynamically allocated/freed. This usage pattern
fits the SubAllocator better than a general Allocator. This change
moves memory allocation visitor access to SubAllocator and eliminates
the VisitableAllocator subclass of Allocator.
This change also more rigorously enforces the requirement that all
Visitors be declared prior to memory allocation begining. This is
accomplished by requiring that Visitors be provided to the SubAllocator
constructor.
This refactoring will ease an upcoming CL introducing
NUMA specific CPU devices. It also should fix some performance
pitfalls (e.g. accidental use of PoolAllocator) introduced by an
earlier refactoring of ProcessState that was also in preparation for
NUMA. It restores the default use of the cpu_allocator() value (i.e.
no SubAllocator) by model executions that don't use allocation
visitors (since visitor registration must precede the first allocation,
hence can be detected at that time).
PiperOrigin-RevId: 213505655
Diffstat (limited to 'tensorflow/core/BUILD')
| -rw-r--r-- | tensorflow/core/BUILD | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/tensorflow/core/BUILD b/tensorflow/core/BUILD index d55bd8d7ed..9bcf5b0865 100644 --- a/tensorflow/core/BUILD +++ b/tensorflow/core/BUILD @@ -2783,7 +2783,6 @@ CORE_CPU_LIB_HEADERS = CORE_CPU_BASE_HDRS + [ "common_runtime/step_stats_collector.h", "common_runtime/threadpool_device.h", "common_runtime/tracing_device.h", - "common_runtime/visitable_allocator.h", "common_runtime/process_state.h", "common_runtime/pool_allocator.h", "graph/gradients.h", |