diff options
author | Justine Tunney <jart@google.com> | 2018-01-17 20:55:46 -0800 |
---|---|---|
committer | TensorFlower Gardener <gardener@tensorflow.org> | 2018-01-17 20:59:53 -0800 |
commit | 4d9bef194799c0656c9ea80f8f083cfab1ebc14a (patch) | |
tree | 2a0176193d20cf8ca486dcabc34e56ebfebf716a /tensorflow/contrib/tensorboard | |
parent | 2b6bb5c203ce9778ef63bf4ef68b3425fc42cc12 (diff) |
Say SQLite BLOB protos are ideally temporary
We ideally want a schema that's pure SQL and doesn't embed
protos. However some protos we don't have time to translate
quite yet. So we put a BLOB as the last field so it can be
migrated later.
Please note there might end up being some things highly
specific to TensorFlow and/or Google that end up here. In
those cases we might consider keeping the proto blobs
permanently, if they're difficult to express in SQL.
PiperOrigin-RevId: 182313847
Diffstat (limited to 'tensorflow/contrib/tensorboard')
-rw-r--r-- | tensorflow/contrib/tensorboard/db/schema.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tensorflow/contrib/tensorboard/db/schema.cc b/tensorflow/contrib/tensorboard/db/schema.cc index 6ccd386dc0..3c7bc87e4a 100644 --- a/tensorflow/contrib/tensorboard/db/schema.cc +++ b/tensorflow/contrib/tensorboard/db/schema.cc @@ -339,8 +339,8 @@ Status SetupTensorboardSqliteDb(Sqlite* db) { // inserted_time: Float UNIX timestamp with µs precision. This is // always the wall time of when the row was inserted into the // DB. It may be used as a hint for an archival job. - // node_def: Contains tf.GraphDef proto. All fields will be cleared - // except those not expressed in SQL. + // graph_def: Contains the tf.GraphDef proto parts leftover which + // haven't been defined in SQL yet. s.Update(Run(db, R"sql( CREATE TABLE IF NOT EXISTS Graphs ( rowid INTEGER PRIMARY KEY, @@ -375,8 +375,8 @@ Status SetupTensorboardSqliteDb(Sqlite* db) { // node_def.name proto field must not be cleared. // op: Copied from tf.NodeDef proto. // device: Copied from tf.NodeDef proto. - // node_def: Contains tf.NodeDef proto. All fields will be cleared - // except those not expressed in SQL. + // node_def: Contains the tf.NodeDef proto parts leftover which + // haven't been defined in SQL yet. // // TODO(jart): Make separate tables for op and device strings. s.Update(Run(db, R"sql( |