diff options
author | A. Unique TensorFlower <gardener@tensorflow.org> | 2018-10-04 10:10:58 -0700 |
---|---|---|
committer | TensorFlower Gardener <gardener@tensorflow.org> | 2018-10-04 10:14:59 -0700 |
commit | 5e1b45d0a8aa3f268745cdc683c26d9ebdd1ea8b (patch) | |
tree | 5a1a6ea4219e82fdef746560ea0a1aae416528d7 /tensorflow/compiler/xla/service | |
parent | c2552cd33c05fa84f280e766e33ba01308ffbcb2 (diff) |
Automated rollback of commit f22037abf5a6f4581f5fb6013f72f91747f22965
PiperOrigin-RevId: 215757701
Diffstat (limited to 'tensorflow/compiler/xla/service')
3 files changed, 5 insertions, 20 deletions
diff --git a/tensorflow/compiler/xla/service/generic_transfer_manager.cc b/tensorflow/compiler/xla/service/generic_transfer_manager.cc index f92fde7f46..bec02e14f9 100644 --- a/tensorflow/compiler/xla/service/generic_transfer_manager.cc +++ b/tensorflow/compiler/xla/service/generic_transfer_manager.cc @@ -98,7 +98,7 @@ Status GenericTransferManager::TransferLiteralFromDeviceInternal( Status GenericTransferManager::TransferLiteralToDeviceAsync( se::Stream* stream, const LiteralSlice& literal, - const ShapedBuffer& device_buffer, TransferToDeviceHint /*hint*/) { + const ShapedBuffer& device_buffer) { const Shape& shape = literal.shape(); VLOG(2) << "transferring literal shape to device: " << ShapeUtil::HumanString(shape) diff --git a/tensorflow/compiler/xla/service/generic_transfer_manager.h b/tensorflow/compiler/xla/service/generic_transfer_manager.h index b1cba82b9f..86c8b1c145 100644 --- a/tensorflow/compiler/xla/service/generic_transfer_manager.h +++ b/tensorflow/compiler/xla/service/generic_transfer_manager.h @@ -45,10 +45,9 @@ class GenericTransferManager : public TransferManager { MutableBorrowingLiteral literal, std::function<void(Status)> done) override; - Status TransferLiteralToDeviceAsync(se::Stream* stream, - const LiteralSlice& literal, - const ShapedBuffer& device_buffer, - TransferToDeviceHint hint) override; + Status TransferLiteralToDeviceAsync( + se::Stream* stream, const LiteralSlice& literal, + const ShapedBuffer& device_buffer) override; Status TransferLiteralToInfeed(se::StreamExecutor* executor, const LiteralSlice& literal) override; diff --git a/tensorflow/compiler/xla/service/transfer_manager.h b/tensorflow/compiler/xla/service/transfer_manager.h index 9199e32d0f..f952e64af2 100644 --- a/tensorflow/compiler/xla/service/transfer_manager.h +++ b/tensorflow/compiler/xla/service/transfer_manager.h @@ -89,16 +89,6 @@ class TransferManager { const LiteralSlice& literal, const ShapedBuffer& device_buffer); - // Hint type given to TransferLiteralToDeviceAsync. - enum TransferToDeviceHint { - // No hint available. - kNoHint, - - // The destination buffer is undefined on the device, meaning it can be - // transferred to eagerly rather than waiting for Stream ordering. - kBufferUndefined, - }; - // Transfers the given literal into the previously allocated device memory // represented by the given ShapedBuffer using the given executor. The shape // of the ShapedBuffer and DeviceShape(literal.shape()) must be compatible, @@ -106,13 +96,9 @@ class TransferManager { // // This operation is performed asynchronously on the given stream. It returns // once the transfer is enqueued. - // - // The optional hint can allow implementations to optimize transfers. It is - // not mandatory for an implementation to obey the hint. virtual Status TransferLiteralToDeviceAsync( se::Stream* stream, const LiteralSlice& literal, - const ShapedBuffer& device_buffer, - TransferToDeviceHint hint = kNoHint) = 0; + const ShapedBuffer& device_buffer) = 0; // Convenience methods for transferring an array to or from the device at a // known address. This avoids having to construct a ShapedBuffer just to |