diff options
| author |  Sanjoy Das <sanjoy@google.com> | 2018-08-16 14:44:15 -0700 |
|---|---|---|
| committer |  TensorFlower Gardener <gardener@tensorflow.org> | 2018-08-16 14:47:49 -0700 |
| commit | d43820b9eff0cc863de2bbfb142afe92bf5afd00 (patch) | |
| tree | e019bdc0bb52496436e0ff92d76b728165e3a420 /tensorflow/compiler/xla/service/shape_inference.h | |
| parent | 8235e83c442744a1285ce97e5dfc2a6556f9f667 (diff) | |
Improve gather ergonomics by renaming fields.
This CL renames the various inputs to the Gather HLO to be more mnemonic by
making it more obviously a batch dynamic-slice. The replacements I made are:
s/elided_window_dims/collapsed_slice_dims/g
s/window_bounds/slice_sizes/g
s/gather_dims_to_operand_dims/start_index_map/g
s/gather_indices/start_indices/g
s/output_window_dims/offset_dims/g
PiperOrigin-RevId: 209051067
Diffstat (limited to 'tensorflow/compiler/xla/service/shape_inference.h')
| -rw-r--r-- | tensorflow/compiler/xla/service/shape_inference.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tensorflow/compiler/xla/service/shape_inference.h b/tensorflow/compiler/xla/service/shape_inference.h index bfd79a4433..4974ac9916 100644 --- a/tensorflow/compiler/xla/service/shape_inference.h +++ b/tensorflow/compiler/xla/service/shape_inference.h @@ -276,9 +276,9 @@ class ShapeInference { // with the given input shape, gather indices shape and gather dimension // numbers. static StatusOr<Shape> InferGatherShape( - const Shape& input_shape, const Shape& gather_indices_shape, + const Shape& input_shape, const Shape& start_indices_shape, const GatherDimensionNumbers& gather_dim_numbers, - tensorflow::gtl::ArraySlice<int64> window_bounds); + tensorflow::gtl::ArraySlice<int64> slice_sizes); // Helper that validates the given input shape, scatter indices shape, updates // shape, and scatter dimension numbers that constitute a scatter operation, |