diff options
| author |  Michael Kuperstein <mkuper@google.com> | 2018-07-25 10:22:40 -0700 |
|---|---|---|
| committer |  TensorFlower Gardener <gardener@tensorflow.org> | 2018-07-25 10:31:05 -0700 |
| commit | f9619bb3f309166a2c1fe453713eb1c44da41f87 (patch) | |
| tree | 2549fc7e13eca8ff137703079b9c57ea0d7f1514 /tensorflow/compiler/xla/service/llvm_ir | |
| parent | 2cd10fad524f99048033c99fdac310487fe8173b (diff) | |
[XLA] DynamicSlice and DynamicUpdateSlice OOB behavior is now well-defined.
This removes comments that refer to it as implementation-defined.
PiperOrigin-RevId: 206013760
Diffstat (limited to 'tensorflow/compiler/xla/service/llvm_ir')
| -rw-r--r-- | tensorflow/compiler/xla/service/llvm_ir/dynamic_update_slice_util.cc | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/tensorflow/compiler/xla/service/llvm_ir/dynamic_update_slice_util.cc b/tensorflow/compiler/xla/service/llvm_ir/dynamic_update_slice_util.cc index 1bd73fc793..27fbb11e2e 100644 --- a/tensorflow/compiler/xla/service/llvm_ir/dynamic_update_slice_util.cc +++ b/tensorflow/compiler/xla/service/llvm_ir/dynamic_update_slice_util.cc @@ -56,10 +56,6 @@ static Status EmitDynamicUpdateSliceInPlaceImpl( // Clamp the start index so that the update region fits in the operand. // start_index = clamp(start_index, 0, output_dim_size - update_dim_size) - - // TODO(b/74360564): This is implementation defined behavior, but is - // currently respected by all implementations. Change this if we ever decide - // to officially document different behavior. llvm::Value* max_bound = b->CreateSub(output_dim_size, update_dim_size); llvm::Value* zero = llvm::ConstantInt::get(start_index[i]->getType(), 0); start_index[i] = |