aboutsummaryrefslogtreecommitdiffhomepage
path: root/tensorflow/compiler/xla/service/hlo_instruction.h
diff options
context:
space:
mode:
authorGravatar A. Unique TensorFlower <gardener@tensorflow.org>2018-07-30 16:14:25 -0700
committerGravatar TensorFlower Gardener <gardener@tensorflow.org>2018-07-30 16:18:32 -0700
commit934b722bff332f51973d9a9d0f65c69a51292406 (patch)
tree7a1d770e77f50734088693f976c1f288a19a9fa5 /tensorflow/compiler/xla/service/hlo_instruction.h
parentf943f0c2012e3820ddfe0fa86f002a80998e1faf (diff)
[XLA] Cleanup: remove the default value of all_reduce_id in the declaration.
Default value could be error-prone. E.g., some hlo passes might forget to handle it. PiperOrigin-RevId: 206665186
Diffstat (limited to 'tensorflow/compiler/xla/service/hlo_instruction.h')
-rw-r--r--tensorflow/compiler/xla/service/hlo_instruction.h3
1 files changed, 1 insertions, 2 deletions
diff --git a/tensorflow/compiler/xla/service/hlo_instruction.h b/tensorflow/compiler/xla/service/hlo_instruction.h
index 30bff286c2..70441b879d 100644
--- a/tensorflow/compiler/xla/service/hlo_instruction.h
+++ b/tensorflow/compiler/xla/service/hlo_instruction.h
@@ -447,8 +447,7 @@ class HloInstruction {
HloComputation* reduce_computation,
tensorflow::gtl::ArraySlice<int64> replica_group_ids,
tensorflow::StringPiece barrier,
- const tensorflow::gtl::optional<int64>& all_reduce_id =
- tensorflow::gtl::nullopt);
+ const tensorflow::gtl::optional<int64>& all_reduce_id);
// Creates a conversion instruction, where operand is the data to convert and
// shape is the target shape for the conversion.