aboutsummaryrefslogtreecommitdiffhomepage
path: root/tensorflow/compiler/xla/service/hlo_instruction.h
diff options
context:
space:
mode:
authorGravatar David Majnemer <majnemer@google.com>2018-09-07 09:11:28 -0700
committerGravatar TensorFlower Gardener <gardener@tensorflow.org>2018-09-07 09:16:11 -0700
commit81110ff2beb38a2cbfbefb69a9b640bf67a8558a (patch)
tree7d3ca9d6292ee6b2163715b20c46d187dc58a89d /tensorflow/compiler/xla/service/hlo_instruction.h
parent57c9485b24655ec1b640ef10ae3debde280d8d60 (diff)
[XLA] Sink PrecisionConfig into Hlo{Dot,Convolution}Instruction
This field only makes sense on kDot & kConvolution. This should shave a few more bytes off of HloInstruction and remove methods that aren't applicable on many HLOs. PiperOrigin-RevId: 211985502
Diffstat (limited to 'tensorflow/compiler/xla/service/hlo_instruction.h')
-rw-r--r--tensorflow/compiler/xla/service/hlo_instruction.h18
1 files changed, 2 insertions, 16 deletions
diff --git a/tensorflow/compiler/xla/service/hlo_instruction.h b/tensorflow/compiler/xla/service/hlo_instruction.h
index 1619d1a985..5581c17c2d 100644
--- a/tensorflow/compiler/xla/service/hlo_instruction.h
+++ b/tensorflow/compiler/xla/service/hlo_instruction.h
@@ -860,11 +860,6 @@ class HloInstruction {
return false;
}
- if (!absl::c_equal(precision_config_.operand_precision(),
- other.precision_config_.operand_precision())) {
- return false;
- }
-
return IdenticalSlowPath(other, eq_computations);
}
@@ -1086,9 +1081,6 @@ class HloInstruction {
// instruction.
void SetupDerivedInstruction(HloInstruction* derived_instruction) const;
- // Returns the dump string of the precision configuration.
- string PrecisionConfigToString() const;
-
// Clones the HLO instruction. The clone will have the same opcode, shape, and
// operands. After creation the clone has no uses. "this" (the instruction
// cloned from) is not changed. Suffix is the string to append to the name of
@@ -1238,10 +1230,8 @@ class HloInstruction {
// information. Transformations to other HLOs will not preserve this
// information but it is presumed that the alternate lowering is strictly
// superior.
- const PrecisionConfig& precision_config() const { return precision_config_; }
- void set_precision_config(const PrecisionConfig& precision_config) {
- precision_config_ = precision_config;
- }
+ // Precondition: opcode must be kConvolution or kDot.
+ const PrecisionConfig& precision_config() const;
// Sets the debug metadata for this instruction.
void set_metadata(const OpMetadata& metadata) { metadata_ = metadata; }
@@ -1651,10 +1641,6 @@ class HloInstruction {
// HLO. See the documentation on backend_config().
string backend_config_;
- // Information used to communicate to the implementation about the algorithm
- // used to produce results. See the documentation on precision_config().
- PrecisionConfig precision_config_;
-
// String identifier for instruction.
string name_;