diff options
| author |  A. Unique TensorFlower <gardener@tensorflow.org> | 2018-08-22 12:56:31 -0700 |
|---|---|---|
| committer | TensorFlower Gardener <gardener@tensorflow.org> | 2018-08-22 13:01:33 -0700 |
| commit | 2325b1e1979694de07439fae7b4585eb6ed4f99a (patch) | |
| tree | 29bb40f997a80d1ee13d871b7e4817c3b46b8aaa /tensorflow/compiler/xla/service/hlo_instruction.h | |
| parent | c73964210ced86791c9231768315fa4652abc9ba (diff) | |
[XLA] Cleanup Alltoall.
- Remove unused field 'cross_replica_sum_barrier' for Alltoall.
- Update cost analysis. There's no computation in Alltoall.
- Cleanup stale TODOs.
PiperOrigin-RevId: 209814190
Diffstat (limited to 'tensorflow/compiler/xla/service/hlo_instruction.h')
| -rw-r--r-- | tensorflow/compiler/xla/service/hlo_instruction.h | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/tensorflow/compiler/xla/service/hlo_instruction.h b/tensorflow/compiler/xla/service/hlo_instruction.h index fdd34544eb..121a9e55f6 100644 --- a/tensorflow/compiler/xla/service/hlo_instruction.h +++ b/tensorflow/compiler/xla/service/hlo_instruction.h @@ -466,12 +466,9 @@ class HloInstruction { // within replica 1, 2, 3, and in the gather phase, the received blocks will // be concatenated in the order of 1, 2, 3; another Alltoall will be applied // within replica 4, 5, 0, and the concatenation order is 4, 5, 0. - // - // TODO(b/110096724): This is NOT YET ready to use. static std::unique_ptr<HloInstruction> CreateAllToAll( const Shape& shape, tensorflow::gtl::ArraySlice<HloInstruction*> operands, - const std::vector<ReplicaGroup>& replica_groups, - tensorflow::StringPiece barrier); + const std::vector<ReplicaGroup>& replica_groups); // Creates a conversion instruction, where operand is the data to convert and // shape is the target shape for the conversion. |