diff options
author | Mark Heffernan <meheff@google.com> | 2018-06-25 23:05:07 -0700 |
---|---|---|
committer | TensorFlower Gardener <gardener@tensorflow.org> | 2018-06-25 23:08:42 -0700 |
commit | 22c06a62b7dcc75f6f717cea63a947b21805afda (patch) | |
tree | 020fd0b07dad4994217170ba13624f15a3709feb /tensorflow/compiler/xla/service/hlo_dce_test.cc | |
parent | 5968eb87766d5536feefaaf8a9ee2f30aeadb354 (diff) |
Rename HLO opcode kGenerateToken to kAfterAll.
Long term I think we want to require kAfterAll to take at least one token as operand so it cannot generate a token out of thin air, so kGenerateToken is no longer an appropriate name. Instead, a primordial token would be supplied some how in the entry computation, perhaps as a parameter, and then threaded to any side-effecting ops.
NFC.
PiperOrigin-RevId: 202079040
Diffstat (limited to 'tensorflow/compiler/xla/service/hlo_dce_test.cc')
-rw-r--r-- | tensorflow/compiler/xla/service/hlo_dce_test.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tensorflow/compiler/xla/service/hlo_dce_test.cc b/tensorflow/compiler/xla/service/hlo_dce_test.cc index 17c78f871c..2822ecd788 100644 --- a/tensorflow/compiler/xla/service/hlo_dce_test.cc +++ b/tensorflow/compiler/xla/service/hlo_dce_test.cc @@ -235,7 +235,7 @@ TEST_F(HloDceTest, CalledComputationWithSideEffect) { auto param = body_builder.AddInstruction( HloInstruction::CreateParameter(0, shape, "param")); auto token = - body_builder.AddInstruction(HloInstruction::CreateGenerateToken({})); + body_builder.AddInstruction(HloInstruction::CreateAfterAll({})); auto infeed = body_builder.AddInstruction( HloInstruction::CreateInfeed(shape, token, "")); body_builder.AddInstruction( @@ -280,7 +280,7 @@ TEST_F(HloDceTest, CalledComputationWithNestedSideEffect) { auto param = nested_callee_builder.AddInstruction( HloInstruction::CreateParameter(0, shape, "param")); auto token = nested_callee_builder.AddInstruction( - HloInstruction::CreateGenerateToken({})); + HloInstruction::CreateAfterAll({})); nested_callee_builder.AddInstruction( HloInstruction::CreateOutfeed(shape, param, token, "")); } |