[XLA] Make HloComputation::instructions() return a view of HloInstruction*s.

Currently it returns a view of unique_ptr<HloInstruction>s.  But the
fact that these are unique_ptrs is an implementation detail, and it's
ugly to leak it everywhere.

PiperOrigin-RevId: 170445375

1 files changed, 3 insertions, 4 deletions

diff --git a/tensorflow/compiler/xla/service/hlo_alias_analysis.cc b/tensorflow/compiler/xla/service/hlo_alias_analysis.cc
index 83756bab80..4d853e65d4 100644
--- a/tensorflow/compiler/xla/service/hlo_alias_analysis.cc
+++ b/tensorflow/compiler/xla/service/hlo_alias_analysis.cc
@@ -376,8 +376,7 @@ string HloAliasAnalysis::ToString() const {
   StrAppend(&out, "  Buffers at each position:\n");
   for (const std::unique_ptr<HloComputation>& computation :
        module_->computations()) {
-    for (const std::unique_ptr<HloInstruction>& instruction :
-         computation->instructions()) {
+    for (const HloInstruction* instruction : computation->instructions()) {
       StrAppend(&out, "    ", instruction->name(), ":\n");
       if (ShapeUtil::IsTuple(instruction->shape())) {
         ShapeUtil::ForEachSubshape(
@@ -385,13 +384,13 @@ string HloAliasAnalysis::ToString() const {
             [&out, &instruction, this](const Shape&, const ShapeIndex& index) {
               StrAppend(&out, "      tuple index ", index.ToString(), ":\n");
               for (const HloBuffer* buffer :
-                   ComputeBuffersAt(instruction.get(), index)) {
+                   ComputeBuffersAt(instruction, index)) {
                 StrAppend(&out, "        ", buffer->ToString(), "\n");
               }
             });
       } else {
         for (const HloBuffer* buffer :
-             ComputeBuffersAt(instruction.get(), /*index=*/{})) {
+             ComputeBuffersAt(instruction, /*index=*/{})) {
           StrAppend(&out, "      ", buffer->ToString(), "\n");
         }
       }