diff options
| author |  Mark Heffernan <meheff@google.com> | 2018-06-25 23:05:07 -0700 |
|---|---|---|
| committer |  TensorFlower Gardener <gardener@tensorflow.org> | 2018-06-25 23:08:42 -0700 |
| commit | 22c06a62b7dcc75f6f717cea63a947b21805afda (patch) | |
| tree | 020fd0b07dad4994217170ba13624f15a3709feb /tensorflow/compiler/xla/service/conditional_simplifier_test.cc | |
| parent | 5968eb87766d5536feefaaf8a9ee2f30aeadb354 (diff) | |
Rename HLO opcode kGenerateToken to kAfterAll.
Long term I think we want to require kAfterAll to take at least one token as operand so it cannot generate a token out of thin air, so kGenerateToken is no longer an appropriate name. Instead, a primordial token would be supplied some how in the entry computation, perhaps as a parameter, and then threaded to any side-effecting ops.
NFC.
PiperOrigin-RevId: 202079040
Diffstat (limited to 'tensorflow/compiler/xla/service/conditional_simplifier_test.cc')
| -rw-r--r-- | tensorflow/compiler/xla/service/conditional_simplifier_test.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tensorflow/compiler/xla/service/conditional_simplifier_test.cc b/tensorflow/compiler/xla/service/conditional_simplifier_test.cc index cad767c039..c38719d50e 100644 --- a/tensorflow/compiler/xla/service/conditional_simplifier_test.cc +++ b/tensorflow/compiler/xla/service/conditional_simplifier_test.cc @@ -144,8 +144,8 @@ TEST_F(ConditionalSimplifierTest, NotRemovedIfContainsNonRemovableInstruction) { auto* conditional = computation->root_instruction(); ASSERT_EQ(conditional->opcode(), HloOpcode::kConditional); auto* false_computation = conditional->false_computation(); - auto token = false_computation->AddInstruction( - HloInstruction::CreateGenerateToken({})); + auto token = + false_computation->AddInstruction(HloInstruction::CreateAfterAll({})); false_computation->AddInstruction(HloInstruction::CreateInfeed( ShapeUtil::MakeShape(F32, {1}), token, "config")); EXPECT_FALSE(ConditionalSimplifier().Run(&module()).ValueOrDie()); |