aboutsummaryrefslogtreecommitdiffhomepage
path: root/tensorflow/compiler/tests
diff options
context:
space:
mode:
authorGravatar A. Unique TensorFlower <gardener@tensorflow.org>2018-08-30 01:56:26 -0700
committerGravatar TensorFlower Gardener <gardener@tensorflow.org>2018-08-30 01:59:58 -0700
commit1a046ed54bea276db1121c6d8f92fd817dc18077 (patch)
tree19b0086ca43ee548a8571ababf32a0ab456e422d /tensorflow/compiler/tests
parentc73d4e56eb2ac66e8fb519cbe83c5f7bddbfc80a (diff)
[TF:XLA] Implement full_matrices=False case of QR decomposition
PiperOrigin-RevId: 210870412
Diffstat (limited to 'tensorflow/compiler/tests')
-rw-r--r--tensorflow/compiler/tests/qr_op_test.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/tensorflow/compiler/tests/qr_op_test.py b/tensorflow/compiler/tests/qr_op_test.py
index 3a268978bf..236b1b881d 100644
--- a/tensorflow/compiler/tests/qr_op_test.py
+++ b/tensorflow/compiler/tests/qr_op_test.py
@@ -101,8 +101,8 @@ class QrOpTest(xla_test.XLATestCase, parameterized.TestCase):
@parameterized.parameters(*PARAMS)
def testQR(self, rows, cols, dtype):
- # TODO(b/111317468): implement full_matrices=False, test other types.
- for full_matrices in [True]:
+ # TODO(b/111317468): Test other types.
+ for full_matrices in [True, False]:
# Only tests the (3, 2) case for small numbers of rows/columns.
for batch_dims in [(), (3,)] + [(3, 2)] * (max(rows, cols) < 10):
self._test(dtype, batch_dims + (rows, cols), full_matrices)