aboutsummaryrefslogtreecommitdiffhomepage
path: root/tensorflow/cc/framework
diff options
context:
space:
mode:
authorGravatar Skye Wanderman-Milne <skyewm@google.com>2017-09-28 13:39:38 -0700
committerGravatar TensorFlower Gardener <gardener@tensorflow.org>2017-09-28 13:54:28 -0700
commit475502198c81414616b520c6f9b1206191c036b8 (patch)
tree43fddc133b6831b462d3b2a2e9bd75a91dd0958f /tensorflow/cc/framework
parente30dcc19134e716a756b106b2888af1be9223059 (diff)
C++ while loop gradient cleanup
PiperOrigin-RevId: 170390543
Diffstat (limited to 'tensorflow/cc/framework')
-rw-r--r--tensorflow/cc/framework/gradients.cc6
-rw-r--r--tensorflow/cc/framework/while_gradients.cc7
2 files changed, 7 insertions, 6 deletions
diff --git a/tensorflow/cc/framework/gradients.cc b/tensorflow/cc/framework/gradients.cc
index 9825b02586..0ec5b9a1bd 100644
--- a/tensorflow/cc/framework/gradients.cc
+++ b/tensorflow/cc/framework/gradients.cc
@@ -98,13 +98,13 @@ class SymbolicGradientBuilder {
const std::vector<Output>& grad_inputs_;
std::vector<Output>* grad_outputs_;
- // A vector of output endpoints which represents backpropagated gradients
- typedef std::vector<Output> BackpropedGradients;
+ // A vector of output endpoints which represents backpropagated gradients.
+ typedef std::vector<Output> BackproppedGradients;
// backprops_ is a map from a node output to its accumulated
// gradients. When a node output has accumulated all its
// gradients, we add a node which sums them up.
- std::unordered_map<Output, BackpropedGradients, OutputHash, OutputEq>
+ std::unordered_map<Output, BackproppedGradients, OutputHash, OutputEq>
backprops_;
// pending[i] is count-down counter for i-th node's expected
diff --git a/tensorflow/cc/framework/while_gradients.cc b/tensorflow/cc/framework/while_gradients.cc
index 8234d5bea4..0734075fc6 100644
--- a/tensorflow/cc/framework/while_gradients.cc
+++ b/tensorflow/cc/framework/while_gradients.cc
@@ -35,8 +35,9 @@ Output ToOutput(OutputTensor output_tensor) {
std::vector<Output> ToOutputVector(
const std::vector<OutputTensor>& output_tensors) {
size_t n = output_tensors.size();
- std::vector<Output> result(n);
- for (int i = 0; i < n; ++i) result[i] = ToOutput(output_tensors[i]);
+ std::vector<Output> result;
+ result.reserve(n);
+ for (int i = 0; i < n; ++i) result.push_back(ToOutput(output_tensors[i]));
return result;
}
@@ -119,7 +120,7 @@ Status AddBackPropLoopCounter(WhileContext* while_ctx, const Output& loop_count,
};
string frame_name = BackPropFrameName(while_ctx->frame_name());
- std::vector<Output> outputs; // unused
+ std::vector<Output> outputs;
TF_RETURN_IF_ERROR(BuildWhileLoop(
scope, {loop_count}, cond_fn, body_fn, frame_name, &outputs,
/* create_while_ctx */ false, backprop_execution_pred));