aboutsummaryrefslogtreecommitdiffhomepage
path: root/configure
diff options
context:
space:
mode:
authorGravatar Dandelion Mané <dandelion@google.com>2017-03-13 12:53:40 -0800
committerGravatar TensorFlower Gardener <gardener@tensorflow.org>2017-03-13 14:13:10 -0700
commit92f285f281328aa003e4e0449371beab5add316d (patch)
treef475915981e7581e75a9a833f106bd3b458aeeb2 /configure
parent32c11fd917f82619f76273f6b83d7e21fb68c173 (diff)
Refactor the PluginAsset class so that PluginAssets are not directly responsible for serialization.
In the current PluginAsset api, the PluginAsset provides a serialize_to_directory method in which it directly writes contents to disk. This means that we as framework maintainers don't have the flexibility to change the serialization strategy in different contexts, e.g. providing good ways to serialize in contexts where we are writing to a db rather than to disk. Also, it presents a trivial landmine where users may use standard python file APIs rather than gfile and thus provide implementations that work externally but break within g3. After the change, the PluginAsset instead provides an 'assets' method, which provides asset names and asset contents. How this gets written out is now an implementation detail handled by the tf.summary.FileWriter. We haven't yet exposed the PluginAsset class as part of the TensorFlow API (it's hidden) so this isn't an API break. Change: 149985564
Diffstat (limited to 'configure')
0 files changed, 0 insertions, 0 deletions