diff options
author | Jason Zaman <jasonzaman@gmail.com> | 2018-06-01 11:52:17 +0800 |
---|---|---|
committer | Gunhan Gulsoy <gunan@google.com> | 2018-05-31 20:52:17 -0700 |
commit | 1039ff9ee8c8c7ed09f9bb106131a50285866dd4 (patch) | |
tree | 2632563535c3867b74934ef159916f3be7a9ba87 /configure.py | |
parent | ae3456402ca15309a2fcb85adbaa8b464ca2d065 (diff) |
BUILD: dont force stripping (#19599)
* BUILD: dont force stripping
Build systems must not strip binaries, it makes it impossible for
distros to ship debugging symbols for packages.
bazel build has a --strip option to allow the user to generate stripped
binaries in a configurable way, that should be used instead.
https://fedoraproject.org/wiki/Packaging:Debuginfo
https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Backtraces#Stripping
Signed-off-by: Jason Zaman <jason@perfinion.com>
* configure: add --strip=always to bazelrc
Diffstat (limited to 'configure.py')
-rw-r--r-- | configure.py | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/configure.py b/configure.py index b6c32543cf..96caa2e2dd 100644 --- a/configure.py +++ b/configure.py @@ -1427,6 +1427,10 @@ def set_grpc_build_flags(): write_to_bazelrc('build --define grpc_no_ares=true') +def set_build_strip_flag(): + write_to_bazelrc('build --strip=always') + + def set_windows_build_flags(): if is_windows(): # The non-monolithic build is not supported yet @@ -1549,6 +1553,7 @@ def main(): set_grpc_build_flags() set_cc_opt_flags(environ_cp) + set_build_strip_flag() set_windows_build_flags() if workspace_has_any_android_rule(): |