diff options
author | Eugene Brevdo <ebrevdo@google.com> | 2017-06-05 11:54:49 -0700 |
---|---|---|
committer | Amit Patankar <amitpatankar@google.com> | 2017-06-05 17:38:33 -0700 |
commit | 51c404968a442fe1e561c3f5d672cf6eb2772e44 (patch) | |
tree | 3b2c4b5af60ff94821a5d04ba02bd16c69afc3a3 /ACKNOWLEDGMENTS | |
parent | a823c8d40185bf6ba0ec47488f8e9fb20de1d20e (diff) |
Fix memory leak in python caused by @tf_should_use.
The issue is that python's GC has trouble collecting objects with __del__ methods.
The solution is two pronged:
* Keep track of usage state outside of the class, via a dict mapping
id(object) => state
* Remove __del__ (this was the source: python's GC couldn't collect wrapped
objects), and instead use weakref.finalize to emit warnings just as the object
is being garbage collected.
* Added tests for garbage collection [they were failing before i fixed the issue]
PiperOrigin-RevId: 158042388
Diffstat (limited to 'ACKNOWLEDGMENTS')
0 files changed, 0 insertions, 0 deletions