aboutsummaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorGravatar A. Unique TensorFlower <gardener@tensorflow.org>2017-02-03 17:02:55 -0800
committerGravatar TensorFlower Gardener <gardener@tensorflow.org>2017-02-03 17:23:46 -0800
commitd08b6eb365f38f54408f4caee489c796dff71a56 (patch)
tree3ff1023a7de5276e7e634076f3307cbf466d8a2a
parentd6df72dd75226b74c6733c6ee9bf92ae48beabb2 (diff)
Add TODOs on several REGISTER_OP calls that should get deprecated.
Remove HistogramAccumulatorSummary from hidden_ops.txt and logging_ops.py; this op no longer exists. Change: 146534447
-rw-r--r--tensorflow/core/ops/data_flow_ops.cc9
-rw-r--r--tensorflow/core/ops/io_ops.cc4
-rw-r--r--tensorflow/python/ops/hidden_ops.txt1
-rw-r--r--tensorflow/python/ops/logging_ops.py1
4 files changed, 13 insertions, 2 deletions
diff --git a/tensorflow/core/ops/data_flow_ops.cc b/tensorflow/core/ops/data_flow_ops.cc
index a19d9483a1..365716b372 100644
--- a/tensorflow/core/ops/data_flow_ops.cc
+++ b/tensorflow/core/ops/data_flow_ops.cc
@@ -1431,6 +1431,7 @@ REGISTER_OP("TensorArray")
.SetIsStateful()
.SetShapeFn([](InferenceContext* c) { return Status::OK(); })
.Deprecated(16, "Use TensorArrayV3");
+// TODO(cwhipkey): mark this deprecated in favor of V3.
REGISTER_OP("TensorArrayV2")
.Input("size: int32")
.Attr("dtype: type")
@@ -1455,6 +1456,7 @@ REGISTER_OP("TensorArrayGrad")
.SetIsStateful()
.SetShapeFn([](InferenceContext* c) { return Status::OK(); })
.Deprecated(16, "Use TensorArrayGradV3");
+// TODO(cwhipkey): mark this deprecated in favor of V3.
REGISTER_OP("TensorArrayGradV2")
.Input("handle: string")
.Input("flow_in: float")
@@ -1479,6 +1481,7 @@ REGISTER_OP("TensorArrayWrite")
.Attr("T: type")
.SetShapeFn([](InferenceContext* c) { return Status::OK(); })
.Deprecated(16, "Use TensorArrayWriteV3");
+// TODO(cwhipkey): mark this deprecated in favor of V3.
REGISTER_OP("TensorArrayWriteV2")
.Input("handle: string")
.Input("index: int32")
@@ -1506,6 +1509,7 @@ REGISTER_OP("TensorArrayRead")
.Attr("dtype: type")
.SetShapeFn([](InferenceContext* c) { return Status::OK(); })
.Deprecated(16, "Use TensorArrayReadV3");
+// TODO(cwhipkey): mark this deprecated in favor of V3.
REGISTER_OP("TensorArrayReadV2")
.Input("handle: string")
.Input("index: int32")
@@ -1548,6 +1552,7 @@ REGISTER_OP("TensorArrayGather")
.Attr("element_shape: shape = { unknown_rank: true }")
.SetShapeFn([](InferenceContext* c) { return Status::OK(); })
.Deprecated(16, "Use TensorArrayGatherV3");
+// TODO(cwhipkey): mark this deprecated in favor of V3.
REGISTER_OP("TensorArrayGatherV2")
.Input("handle: string")
.Input("indices: int32")
@@ -1574,6 +1579,7 @@ REGISTER_OP("TensorArrayScatter")
.Attr("T: type")
.SetShapeFn([](InferenceContext* c) { return Status::OK(); })
.Deprecated(19, "Use TensorArrayGradV3");
+// TODO(cwhipkey): mark this deprecated in favor of V3.
REGISTER_OP("TensorArrayScatterV2")
.Input("handle: string")
.Input("indices: int32")
@@ -1628,6 +1634,7 @@ REGISTER_OP("TensorArraySplit")
.Attr("T: type")
.SetShapeFn([](InferenceContext* c) { return Status::OK(); })
.Deprecated(16, "Use TensorArraySplitV3");
+// TODO(cwhipkey): mark this deprecated in favor of V3.
REGISTER_OP("TensorArraySplitV2")
.Input("handle: string")
.Input("value: T")
@@ -1652,6 +1659,7 @@ REGISTER_OP("TensorArraySize")
.Output("size: int32")
.SetShapeFn([](InferenceContext* c) { return Status::OK(); })
.Deprecated(16, "Use TensorArraySizeV3");
+// TODO(cwhipkey): mark this deprecated in favor of V3.
REGISTER_OP("TensorArraySizeV2")
.Input("handle: string")
.Input("flow_in: float")
@@ -1668,6 +1676,7 @@ REGISTER_OP("TensorArrayClose")
.Input("handle: Ref(string)")
.SetShapeFn([](InferenceContext* c) { return Status::OK(); })
.Deprecated(16, "Use TensorArrayCloseV3");
+// TODO(cwhipkey): mark this deprecated in favor of V3.
REGISTER_OP("TensorArrayCloseV2")
.Input("handle: string")
.SetShapeFn([](InferenceContext* c) {
diff --git a/tensorflow/core/ops/io_ops.cc b/tensorflow/core/ops/io_ops.cc
index 864f131caa..3e2583f706 100644
--- a/tensorflow/core/ops/io_ops.cc
+++ b/tensorflow/core/ops/io_ops.cc
@@ -397,6 +397,7 @@ shared_name: If non-empty, this reader is named in the given bucket
with this shared_name. Otherwise, the node name is used instead.
)doc");
+// TODO(cwhipkey): mark this deprecated in favor of V2.
REGISTER_OP("TextLineReader")
.Output("reader_handle: Ref(string)")
.Attr("skip_header_lines: int = 0")
@@ -433,6 +434,7 @@ shared_name: If non-empty, this reader is named in the given bucket
with this shared_name. Otherwise, the node name is used instead.
)doc");
+// TODO(cwhipkey): mark this deprecated in favor of V2.
REGISTER_OP("FixedLengthRecordReader")
.Output("reader_handle: Ref(string)")
.Attr("header_bytes: int = 0")
@@ -471,6 +473,7 @@ shared_name: If non-empty, this reader is named in the given bucket
with this shared_name. Otherwise, the node name is used instead.
)doc");
+// TODO(cwhipkey): mark this deprecated in favor of V2.
REGISTER_OP("TFRecordReader")
.Output("reader_handle: Ref(string)")
.Attr("container: string = ''")
@@ -505,6 +508,7 @@ shared_name: If non-empty, this reader is named in the given bucket
with this shared_name. Otherwise, the node name is used instead.
)doc");
+// TODO(cwhipkey): mark this deprecated in favor of V2.
REGISTER_OP("IdentityReader")
.Output("reader_handle: Ref(string)")
.Attr("container: string = ''")
diff --git a/tensorflow/python/ops/hidden_ops.txt b/tensorflow/python/ops/hidden_ops.txt
index a86379bcb6..e76976368c 100644
--- a/tensorflow/python/ops/hidden_ops.txt
+++ b/tensorflow/python/ops/hidden_ops.txt
@@ -204,7 +204,6 @@ Svd
Assert
AudioSummary
AudioSummaryV2
-HistogramAccumulatorSummary
HistogramSummary
ImageSummary
MergeSummary
diff --git a/tensorflow/python/ops/logging_ops.py b/tensorflow/python/ops/logging_ops.py
index cb13887b56..f0fdb7b0bf 100644
--- a/tensorflow/python/ops/logging_ops.py
+++ b/tensorflow/python/ops/logging_ops.py
@@ -332,7 +332,6 @@ def scalar_summary(tags, values, collections=None, name=None):
return val
-ops.NotDifferentiable("HistogramAccumulatorSummary")
ops.NotDifferentiable("HistogramSummary")
ops.NotDifferentiable("ImageSummary")
ops.NotDifferentiable("AudioSummary")