diff options
author | 2018-05-05 10:44:20 -0400 | |
---|---|---|
committer | 2018-05-05 10:44:20 -0400 | |
commit | c92de2f3fc81c701ab29408a8a84cd6e41e96fe5 (patch) | |
tree | 45d013825b4bd40cbab4d565ce5de8cf3165d949 | |
parent | dd1ef8fa8f6861e53e8a7953c171b3e9253043ed (diff) |
Skip all ops with function attribute by default
19 files changed, 13 insertions, 72 deletions
diff --git a/tensorflow/core/api_def/BUILD b/tensorflow/core/api_def/BUILD index 06b797e32e..1454a1d9b2 100644 --- a/tensorflow/core/api_def/BUILD +++ b/tensorflow/core/api_def/BUILD @@ -30,12 +30,6 @@ filegroup( visibility = ["//tensorflow:internal"], ) -filegroup( - name = "java_api_def", - srcs = glob(["java_api/*"]), - visibility = ["//tensorflow:internal"], -) - cc_library( name = "excluded_ops_lib", srcs = ["excluded_ops.cc"], diff --git a/tensorflow/core/api_def/java_api/api_def_FilterDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_FilterDataset.pbtxt deleted file mode 100644 index debd7e5709..0000000000 --- a/tensorflow/core/api_def/java_api/api_def_FilterDataset.pbtxt +++ /dev/null @@ -1,4 +0,0 @@ -op { - graph_op_name: "FilterDataset" - visibility: SKIP -} diff --git a/tensorflow/core/api_def/java_api/api_def_FlatMapDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_FlatMapDataset.pbtxt deleted file mode 100644 index 329ab15ef5..0000000000 --- a/tensorflow/core/api_def/java_api/api_def_FlatMapDataset.pbtxt +++ /dev/null @@ -1,4 +0,0 @@ -op { - graph_op_name: "FlatMapDataset" - visibility: SKIP -} diff --git a/tensorflow/core/api_def/java_api/api_def_For.pbtxt b/tensorflow/core/api_def/java_api/api_def_For.pbtxt deleted file mode 100644 index caabc947bb..0000000000 --- a/tensorflow/core/api_def/java_api/api_def_For.pbtxt +++ /dev/null @@ -1,4 +0,0 @@ -op { - graph_op_name: "For" - visibility: SKIP -} diff --git a/tensorflow/core/api_def/java_api/api_def_GeneratorDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_GeneratorDataset.pbtxt deleted file mode 100644 index a6e5167c30..0000000000 --- a/tensorflow/core/api_def/java_api/api_def_GeneratorDataset.pbtxt +++ /dev/null @@ -1,4 +0,0 @@ -op { - graph_op_name: "GeneratorDataset" - visibility: SKIP -} diff --git a/tensorflow/core/api_def/java_api/api_def_GroupByWindowDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_GroupByWindowDataset.pbtxt deleted file mode 100644 index 4c0b2084a8..0000000000 --- a/tensorflow/core/api_def/java_api/api_def_GroupByWindowDataset.pbtxt +++ /dev/null @@ -1,4 +0,0 @@ -op { - graph_op_name: "GroupByWindowDataset" - visibility: SKIP -} diff --git a/tensorflow/core/api_def/java_api/api_def_If.pbtxt b/tensorflow/core/api_def/java_api/api_def_If.pbtxt deleted file mode 100644 index 13b8635ca7..0000000000 --- a/tensorflow/core/api_def/java_api/api_def_If.pbtxt +++ /dev/null @@ -1,4 +0,0 @@ -op { - graph_op_name: "If" - visibility: SKIP -} diff --git a/tensorflow/core/api_def/java_api/api_def_InterleaveDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_InterleaveDataset.pbtxt deleted file mode 100644 index ed748d4d2a..0000000000 --- a/tensorflow/core/api_def/java_api/api_def_InterleaveDataset.pbtxt +++ /dev/null @@ -1,4 +0,0 @@ -op { - graph_op_name: "InterleaveDataset" - visibility: SKIP -} diff --git a/tensorflow/core/api_def/java_api/api_def_MapAndBatchDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_MapAndBatchDataset.pbtxt deleted file mode 100644 index cb96bf63d8..0000000000 --- a/tensorflow/core/api_def/java_api/api_def_MapAndBatchDataset.pbtxt +++ /dev/null @@ -1,4 +0,0 @@ -op { - graph_op_name: "MapAndBatchDataset" - visibility: SKIP -} diff --git a/tensorflow/core/api_def/java_api/api_def_MapDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_MapDataset.pbtxt deleted file mode 100644 index e0ab8dd9db..0000000000 --- a/tensorflow/core/api_def/java_api/api_def_MapDataset.pbtxt +++ /dev/null @@ -1,4 +0,0 @@ -op { - graph_op_name: "MapDataset" - visibility: SKIP -} diff --git a/tensorflow/core/api_def/java_api/api_def_OneShotIterator.pbtxt b/tensorflow/core/api_def/java_api/api_def_OneShotIterator.pbtxt deleted file mode 100644 index 13130e6882..0000000000 --- a/tensorflow/core/api_def/java_api/api_def_OneShotIterator.pbtxt +++ /dev/null @@ -1,4 +0,0 @@ -op { - graph_op_name: "OneShotIterator" - visibility: SKIP -} diff --git a/tensorflow/core/api_def/java_api/api_def_ParallelInterleaveDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_ParallelInterleaveDataset.pbtxt deleted file mode 100644 index 6a985d24fa..0000000000 --- a/tensorflow/core/api_def/java_api/api_def_ParallelInterleaveDataset.pbtxt +++ /dev/null @@ -1,4 +0,0 @@ -op { - graph_op_name: "ParallelInterleaveDataset" - visibility: SKIP -} diff --git a/tensorflow/core/api_def/java_api/api_def_ParallelMapDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_ParallelMapDataset.pbtxt deleted file mode 100644 index 64f25b9e5e..0000000000 --- a/tensorflow/core/api_def/java_api/api_def_ParallelMapDataset.pbtxt +++ /dev/null @@ -1,4 +0,0 @@ -op { - graph_op_name: "ParallelMapDataset" - visibility: SKIP -} diff --git a/tensorflow/core/api_def/java_api/api_def_RemoteCall.pbtxt b/tensorflow/core/api_def/java_api/api_def_RemoteCall.pbtxt deleted file mode 100644 index 2ccb5c8cf3..0000000000 --- a/tensorflow/core/api_def/java_api/api_def_RemoteCall.pbtxt +++ /dev/null @@ -1,4 +0,0 @@ -op { - graph_op_name: "RemoteCall" - visibility: SKIP -} diff --git a/tensorflow/core/api_def/java_api/api_def_ScanDataset.pbtxt b/tensorflow/core/api_def/java_api/api_def_ScanDataset.pbtxt deleted file mode 100644 index 3463e60049..0000000000 --- a/tensorflow/core/api_def/java_api/api_def_ScanDataset.pbtxt +++ /dev/null @@ -1,4 +0,0 @@ -op { - graph_op_name: "ScanDataset" - visibility: SKIP -} diff --git a/tensorflow/core/api_def/java_api/api_def_SymbolicGradient.pbtxt b/tensorflow/core/api_def/java_api/api_def_SymbolicGradient.pbtxt deleted file mode 100644 index 88c3acea74..0000000000 --- a/tensorflow/core/api_def/java_api/api_def_SymbolicGradient.pbtxt +++ /dev/null @@ -1,4 +0,0 @@ -op { - graph_op_name: "SymbolicGradient" - visibility: SKIP -} diff --git a/tensorflow/core/api_def/java_api/api_def_While.pbtxt b/tensorflow/core/api_def/java_api/api_def_While.pbtxt deleted file mode 100644 index 33756682c3..0000000000 --- a/tensorflow/core/api_def/java_api/api_def_While.pbtxt +++ /dev/null @@ -1,4 +0,0 @@ -op { - graph_op_name: "While" - visibility: SKIP -}
\ No newline at end of file diff --git a/tensorflow/java/BUILD b/tensorflow/java/BUILD index 7cd0208dbf..0cc8e7c3e2 100644 --- a/tensorflow/java/BUILD +++ b/tensorflow/java/BUILD @@ -72,7 +72,6 @@ tf_java_op_gen_srcjar( name = "java_op_gen_sources", api_def_srcs = [ "//tensorflow/core/api_def:base_api_def", - "//tensorflow/core/api_def:java_api_def", ], base_package = "org.tensorflow.op", gen_tool = ":java_op_gen_tool", diff --git a/tensorflow/java/src/gen/cc/op_generator.cc b/tensorflow/java/src/gen/cc/op_generator.cc index 7355b3a395..f4cefbe933 100644 --- a/tensorflow/java/src/gen/cc/op_generator.cc +++ b/tensorflow/java/src/gen/cc/op_generator.cc @@ -420,6 +420,18 @@ void GenerateOp(const OpSpec& op, const EndpointSpec& endpoint, writer.EndType(); } +bool CanGenerateOp(const OpDef& op_def, const ApiDef& api_def) { + if (api_def.visibility() == ApiDef::SKIP) { + return false; + } + for (const auto& attr : op_def.attr()) { + if (attr.type() == "func") { + return false; // TODO(karllessard) add support for function attributes + } + } + return true; +} + } // namespace Status OpGenerator::Run(const OpList& op_list, const string& base_package, @@ -441,7 +453,7 @@ Status OpGenerator::Run(const OpList& op_list, const string& base_package, api_map.UpdateDocs(); for (const auto& op_def : op_list.op()) { const ApiDef* api_def = api_map.GetApiDef(op_def.name()); - if (api_def->visibility() != ApiDef::SKIP) { + if (CanGenerateOp(op_def, *api_def)) { OpSpec op(OpSpec::Create(op_def, *api_def)); for (const EndpointSpec& endpoint : op.endpoints()) { GenerateOp(op, endpoint, base_package, output_dir, env_); |