diff options
author | James Keeling <jtkeeling@google.com> | 2018-09-14 02:26:55 -0700 |
---|---|---|
committer | TensorFlower Gardener <gardener@tensorflow.org> | 2018-09-14 02:31:50 -0700 |
commit | c335f3ae6872715c4873eb8af3ff2e42833bc6c0 (patch) | |
tree | 8fd4f3c4f2e478d28025a0926353156918fc984f | |
parent | e9f5df6d48eb0999281d73b85ce4a126fcfaab98 (diff) |
[Grappler] s/std::string/string/
string and std::string are not necessarily the same thing in TF, but this code assumed that they are.
PiperOrigin-RevId: 212952877
-rw-r--r-- | tensorflow/core/grappler/costs/graph_properties.cc | 8 | ||||
-rw-r--r-- | tensorflow/core/grappler/costs/utils.cc | 8 | ||||
-rw-r--r-- | tensorflow/core/grappler/costs/utils.h | 2 | ||||
-rw-r--r-- | tensorflow/core/grappler/costs/virtual_scheduler_test.cc | 8 | ||||
-rw-r--r-- | tensorflow/core/grappler/inputs/utils.cc | 7 | ||||
-rw-r--r-- | tensorflow/core/grappler/inputs/utils.h | 4 | ||||
-rw-r--r-- | tensorflow/core/grappler/op_types.cc | 2 | ||||
-rw-r--r-- | tensorflow/core/grappler/optimizers/arithmetic_optimizer_test.cc | 4 | ||||
-rw-r--r-- | tensorflow/core/grappler/optimizers/data/graph_utils.cc | 2 |
9 files changed, 23 insertions, 22 deletions
diff --git a/tensorflow/core/grappler/costs/graph_properties.cc b/tensorflow/core/grappler/costs/graph_properties.cc index d273eddf81..56c8339d57 100644 --- a/tensorflow/core/grappler/costs/graph_properties.cc +++ b/tensorflow/core/grappler/costs/graph_properties.cc @@ -260,13 +260,13 @@ typename DisjointSet<Handle>::Rep* DisjointSet<Handle>::Find(Handle value) { } bool IsEnqueue(const NodeDef& n) { - return (n.op().find("Enqueue") != std::string::npos && - n.op().find("EnqueueMany") == std::string::npos); + return (n.op().find("Enqueue") != string::npos && + n.op().find("EnqueueMany") == string::npos); } bool IsDequeue(const NodeDef& n) { - return (n.op().find("Dequeue") != std::string::npos && - n.op().find("DequeueMany") == std::string::npos); + return (n.op().find("Dequeue") != string::npos && + n.op().find("DequeueMany") == string::npos); } bool HasAnyUnknownDimensions(const TensorShapeProto& proto) { diff --git a/tensorflow/core/grappler/costs/utils.cc b/tensorflow/core/grappler/costs/utils.cc index aad00ce039..83434ea40f 100644 --- a/tensorflow/core/grappler/costs/utils.cc +++ b/tensorflow/core/grappler/costs/utils.cc @@ -127,7 +127,7 @@ static void ExtractExtraProperties( // For filename input, the file size can also be useful. if (op_def && i < op_def->input_arg_size() && - op_def->input_arg(i).name().find("filename") != std::string::npos) { + op_def->input_arg(i).name().find("filename") != string::npos) { Tensor tensor; if (!tensor.FromProto(t)) { continue; @@ -153,7 +153,7 @@ static void ExtractExtraProperties( // When the input is a handle (e.g. look up table handle), the information // in the op itself is not sufficient to predict the op memory. if (op_def && i < op_def->input_arg_size() && - op_def->input_arg(i).name().find("handle") != std::string::npos) { + op_def->input_arg(i).name().find("handle") != string::npos) { string new_key = strings::StrCat("parent_", i, "_op"); AttrValue attr; attr.set_s(input_node->op()); @@ -320,8 +320,8 @@ void TensorSizeHistogram::Merge(const TensorSizeHistogram& src) { buckets_.begin(), std::plus<uint64>()); } -std::string TensorSizeHistogram::ToString() const { - std::string r; +string TensorSizeHistogram::ToString() const { + string r; char buf[200]; snprintf(buf, sizeof(buf), "Count: %lld, Average: ", num_elem_); r.append(buf); diff --git a/tensorflow/core/grappler/costs/utils.h b/tensorflow/core/grappler/costs/utils.h index d2c7c67666..5fd6717712 100644 --- a/tensorflow/core/grappler/costs/utils.h +++ b/tensorflow/core/grappler/costs/utils.h @@ -80,7 +80,7 @@ class TensorSizeHistogram { uint64 Max() const { return max_; } uint64 NumElem() const { return num_elem_; } uint64 SumElem() const { return sum_elem_; } - std::string ToString() const; + string ToString() const; protected: const int Index(const uint64 value) const; diff --git a/tensorflow/core/grappler/costs/virtual_scheduler_test.cc b/tensorflow/core/grappler/costs/virtual_scheduler_test.cc index 02a379fca8..80889afc86 100644 --- a/tensorflow/core/grappler/costs/virtual_scheduler_test.cc +++ b/tensorflow/core/grappler/costs/virtual_scheduler_test.cc @@ -1999,13 +1999,13 @@ TEST_F(VirtualSchedulerTest, InterDeviceTransfer) { // Helper lambda to extract port num from _Send and _Recv op name. auto get_port_num = [](const string& name) -> int { - if (name.find("bn_0") != std::string::npos) { + if (name.find("bn_0") != string::npos) { return 0; - } else if (name.find("bn_1") != std::string::npos) { + } else if (name.find("bn_1") != string::npos) { return 1; - } else if (name.find("bn_2") != std::string::npos) { + } else if (name.find("bn_2") != string::npos) { return 2; - } else if (name.find("bn_minus1") != std::string::npos) { + } else if (name.find("bn_minus1") != string::npos) { return -1; } return -999; diff --git a/tensorflow/core/grappler/inputs/utils.cc b/tensorflow/core/grappler/inputs/utils.cc index 5029dff877..def9198a69 100644 --- a/tensorflow/core/grappler/inputs/utils.cc +++ b/tensorflow/core/grappler/inputs/utils.cc @@ -14,10 +14,11 @@ limitations under the License. ==============================================================================*/ #include "tensorflow/core/grappler/inputs/utils.h" -#include "tensorflow/core/platform/env.h" #include <vector> +#include "tensorflow/core/platform/env.h" + namespace tensorflow { namespace grappler { @@ -29,12 +30,12 @@ bool FilesExist(const std::set<string>& files) { return FilesExist(std::vector<string>(files.begin(), files.end()), nullptr); } -bool FileExists(const std::string& file, Status* status) { +bool FileExists(const string& file, Status* status) { *status = Env::Default()->FileExists(file); return status->ok(); } -Status ReadGraphDefFromFile(const std::string& graph_def_pbtxt_path, +Status ReadGraphDefFromFile(const string& graph_def_pbtxt_path, GraphDef* result) { Status status; if (FileExists(graph_def_pbtxt_path, &status)) { diff --git a/tensorflow/core/grappler/inputs/utils.h b/tensorflow/core/grappler/inputs/utils.h index 627dd5359f..4b9cb0a9ad 100644 --- a/tensorflow/core/grappler/inputs/utils.h +++ b/tensorflow/core/grappler/inputs/utils.h @@ -29,9 +29,9 @@ bool FilesExist(const std::vector<string>& files, std::vector<Status>* status = nullptr); bool FilesExist(const std::set<string>& files); -bool FileExists(const std::string& file, Status* status); +bool FileExists(const string& file, Status* status); -Status ReadGraphDefFromFile(const std::string& graph_def_pbtxt_path, +Status ReadGraphDefFromFile(const string& graph_def_pbtxt_path, GraphDef* result); } // end namespace grappler diff --git a/tensorflow/core/grappler/op_types.cc b/tensorflow/core/grappler/op_types.cc index e78239bd43..3521669b63 100644 --- a/tensorflow/core/grappler/op_types.cc +++ b/tensorflow/core/grappler/op_types.cc @@ -491,7 +491,7 @@ bool IsFreeOfSideEffect(const NodeDef& node) { } } // Queue ops modify the queue which is a side effect. - if (node.op().find("Queue") != std::string::npos) { + if (node.op().find("Queue") != string::npos) { return false; } return !ModifiesInputsInPlace(node); diff --git a/tensorflow/core/grappler/optimizers/arithmetic_optimizer_test.cc b/tensorflow/core/grappler/optimizers/arithmetic_optimizer_test.cc index 39517edc06..bc838c6659 100644 --- a/tensorflow/core/grappler/optimizers/arithmetic_optimizer_test.cc +++ b/tensorflow/core/grappler/optimizers/arithmetic_optimizer_test.cc @@ -581,7 +581,7 @@ TEST_F(ArithmeticOptimizerTest, TrivialSumsSimple) { const NodeDef* new_const = node_map.GetNode(optimized_const_name); ASSERT_NE(new_const, nullptr); EXPECT_EQ("^x", new_const->input(0)); - EXPECT_EQ(std::string("\0\0\0@", 4), + EXPECT_EQ(string("\0\0\0@", 4), new_const->attr().at("value").tensor().tensor_content()); const NodeDef* new_mul = node_map.GetNode(optimized_mul_name); @@ -625,7 +625,7 @@ TEST_F(ArithmeticOptimizerTest, TrivialSumsSimpleWithControlDep) { const NodeDef* new_const = node_map.GetNode(optimized_const_name); ASSERT_NE(new_const, nullptr); EXPECT_EQ("^x", new_const->input(0)); - EXPECT_EQ(std::string("\0\0\0@", 4), + EXPECT_EQ(string("\0\0\0@", 4), new_const->attr().at("value").tensor().tensor_content()); const NodeDef* new_mul = node_map.GetNode(optimized_mul_name); diff --git a/tensorflow/core/grappler/optimizers/data/graph_utils.cc b/tensorflow/core/grappler/optimizers/data/graph_utils.cc index 5a7fe19265..d4ab444036 100644 --- a/tensorflow/core/grappler/optimizers/data/graph_utils.cc +++ b/tensorflow/core/grappler/optimizers/data/graph_utils.cc @@ -273,7 +273,7 @@ void SetUniqueGraphNodeName(StringPiece prefix, GraphDef* graph, string name = string(prefix); int id = graph->node_size(); while (ContainsGraphNodeWithName(name, *graph)) { - if (name.rfind("_generated") != std::string::npos && + if (name.rfind("_generated") != string::npos && (name.rfind("_generated") == (name.size() - strlen("_generated")))) { name.insert(name.rfind("_generated"), strings::StrCat("/_", id)); } else { |