diff options
| author |  A. Unique TensorFlower <gardener@tensorflow.org> | 2017-03-28 20:52:32 -0800 |
|---|---|---|
| committer | TensorFlower Gardener <gardener@tensorflow.org> | 2017-03-28 22:13:35 -0700 |
| commit | 8e46bc5420217b6460f6aaae0a3616fe8a04cff8 (patch) | |
| tree | bfd87ce1ffed3c0066cb0972c6b29da52b10b7ff | |
| parent | 3d8cf6fb14dac7b2ce6ba195b1b90784429ec0ce (diff) | |
[XLA] Change TODO(leary) to TODO(b/...)
Change: 151537962
| -rw-r--r-- | tensorflow/compiler/xla/client/computation.cc | 2 | ||||
| -rw-r--r-- | tensorflow/compiler/xla/client/computation_builder.h | 4 | ||||
| -rw-r--r-- | tensorflow/compiler/xla/service/compiler.h | 3 | ||||
| -rw-r--r-- | tensorflow/compiler/xla/service/executable.h | 3 |
4 files changed, 4 insertions, 8 deletions
diff --git a/tensorflow/compiler/xla/client/computation.cc b/tensorflow/compiler/xla/client/computation.cc index cd7d8df58b..0f9ca7b4fe 100644 --- a/tensorflow/compiler/xla/client/computation.cc +++ b/tensorflow/compiler/xla/client/computation.cc @@ -33,7 +33,7 @@ Computation::Computation(Computation&& computation) } void Computation::Reset() { - // TODO(leary) deallocate any owned computation. + // TODO(b/34469253) deallocate any owned computation. ResetWithoutFreeing(); } diff --git a/tensorflow/compiler/xla/client/computation_builder.h b/tensorflow/compiler/xla/client/computation_builder.h index 8a358d9533..87ceb43d1f 100644 --- a/tensorflow/compiler/xla/client/computation_builder.h +++ b/tensorflow/compiler/xla/client/computation_builder.h @@ -541,8 +541,8 @@ class ComputationBuilder { // (float32 is specified as there is an implicit float32 -1.0f constant // exponent). // - // TODO(leary) axe F32 suffix, can be determined by reflecting on the shape of - // the operand. + // TODO(b/34468990) axe F32 suffix, can be determined by reflecting on the + // shape of the operand. ComputationDataHandle ReciprocalF32(const ComputationDataHandle& operand); // Enqueues a negate instruction onto the computation. diff --git a/tensorflow/compiler/xla/service/compiler.h b/tensorflow/compiler/xla/service/compiler.h index 45cbe2b7ae..6f43c9b804 100644 --- a/tensorflow/compiler/xla/service/compiler.h +++ b/tensorflow/compiler/xla/service/compiler.h @@ -110,8 +110,7 @@ class Compiler { // The compiler may optionally specialize to the individual device // (not just type of device) indicated by the executor. // - // TODO(leary) will need to update this API when a single computation can run - // across multiple devices simultaneously. + // Use the overload below to compile computations that run in parallel. virtual StatusOr<std::unique_ptr<Executable>> Compile( std::unique_ptr<HloModule> module, std::unique_ptr<HloModuleConfig> module_config, HloDumper dump_hlo, diff --git a/tensorflow/compiler/xla/service/executable.h b/tensorflow/compiler/xla/service/executable.h index b5307ad1df..eb36aba33a 100644 --- a/tensorflow/compiler/xla/service/executable.h +++ b/tensorflow/compiler/xla/service/executable.h @@ -39,9 +39,6 @@ namespace xla { // A given platform's compiler will produce an Executable -- this is a uniform // interface that is used for launching compiled programs across platforms. -// -// TODO(leary) will need to extend this to support multiple streams/devices as -// we begin to compile single programs to run on multiple devices. class Executable { public: explicit Executable(std::unique_ptr<HloModule> hlo_module, |