diff options
| author |  Dimitris Vardoulakis <dimvar@google.com> | 2018-09-18 15:24:59 -0700 |
|---|---|---|
| committer |  TensorFlower Gardener <gardener@tensorflow.org> | 2018-09-18 15:29:43 -0700 |
| commit | 228572ecf387931b14e92555a2234dc085813e21 (patch) | |
| tree | bb4b6c448cef5c8e9fc895b29554c40dad20c209 | |
| parent | c2d392e36a3f68c2e1b8fdfa280953efc6426c52 (diff) | |
[TF:XLA] Document that the order of control predecessors matters.
PiperOrigin-RevId: 213528296
| -rw-r--r-- | tensorflow/compiler/xla/service/hlo_instruction.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/tensorflow/compiler/xla/service/hlo_instruction.h b/tensorflow/compiler/xla/service/hlo_instruction.h index 4f6cac1396..1ef8cd5036 100644 --- a/tensorflow/compiler/xla/service/hlo_instruction.h +++ b/tensorflow/compiler/xla/service/hlo_instruction.h @@ -1616,6 +1616,10 @@ class HloInstruction { InstructionVector operands_; // The set of control predecessors of this instruction. + // Note that the order of the instructions in the vector influences the order + // computed in HloComputation::ComputeInstructionPostOrder, which may + // influence the result of the compilation by changing the scheduling. We are + // not sure if it matters. std::vector<HloInstruction*> control_predecessors_; // The users of this instruction. Users are HLOs where this instruction is an |