diff options
author | Guenther Schmuelling <guschmue@microsoft.com> | 2017-05-04 22:01:18 -0700 |
---|---|---|
committer | Vijay Vasudevan <vrv@google.com> | 2017-05-04 22:01:18 -0700 |
commit | 20b5a90c24d514673204b87f2dc604e2a818a22a (patch) | |
tree | ca81d3e13d4becb7be9f40f77c0f48a80c69712e | |
parent | d24befd445ce74a611c95533b11ceb2a09841d47 (diff) |
This fixes some issue introduced in the previous version where RTTI (#9671)
was removed from the exclusion list. Because of this the number of
symbols in the def file was close to 64K for gpu builds and yesterday
a few added symbols pushed us over the 64K limit for the windows linker.
Adding RTTI back to the exclusion list.
-rw-r--r-- | tensorflow/contrib/cmake/tools/create_def_file.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/tensorflow/contrib/cmake/tools/create_def_file.py b/tensorflow/contrib/cmake/tools/create_def_file.py index 9bd287d0d7..b16a5eadb0 100644 --- a/tensorflow/contrib/cmake/tools/create_def_file.py +++ b/tensorflow/contrib/cmake/tools/create_def_file.py @@ -44,7 +44,7 @@ UNDNAME = "undname.exe" DUMPBIN = "dumpbin.exe" # Exclude if matched -EXCLUDE_RE = re.compile(r"deleting destructor|::internal::") +EXCLUDE_RE = re.compile(r"RTTI|deleting destructor|::internal::") # Include if matched before exclude INCLUDEPRE_RE = re.compile(r"google::protobuf::internal::ExplicitlyConstructed|" @@ -141,17 +141,17 @@ def main(): continue if not INCLUDE_RE.search(line): continue - + if "deleting destructor" in line: # Some of the symbols convered by INCLUDEPRE_RE export deleting # destructor symbols, which is a bad idea. # So we filter out such symbols here. continue - + if DATA_EXCLUDE_RE.search(line): def_fp.write("\t" + decorated + "\n") else: - def_fp.write("\t" + decorated + " DATA\n") + def_fp.write("\t" + decorated + " DATA\n") taken.add(decorated) exit_code = proc.wait() if exit_code != 0: |