1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
|
/*
* Copyright 2018 Google Inc.
*
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
#include "bookmaker.h"
#ifdef SK_BUILD_FOR_WIN
#include <windows.h>
#endif
/* SkDebugf works in both visual studio and git shell, but
in git shell output is not piped to grep.
printf does not generate output in visual studio, but
does in git shell and can be piped.
*/
#ifdef SK_BUILD_FOR_WIN
#define PRINTF(...) \
do { \
if (IsDebuggerPresent()) { \
SkDebugf(__VA_ARGS__); \
} else { \
printf(__VA_ARGS__); \
} \
} while (false)
#else
#define PRINTF(...) \
printf(__VA_ARGS__)
#endif
// Check that mutiple like-named methods are under one Subtopic
// Check that SeeAlso reference each other
// Would be nice to check if other classes have 'create' methods that are included
// SkSurface::makeImageSnapShot should be referenced under SkImage 'creators'
class SelfChecker {
public:
SelfChecker(const BmhParser& bmh)
: fBmhParser(bmh)
{}
bool check() {
for (const auto& topic : fBmhParser.fTopicMap) {
Definition* topicDef = topic.second;
if (topicDef->fParent) {
continue;
}
if (!topicDef->isRoot()) {
return fBmhParser.reportError<bool>("expected root topic");
}
fRoot = topicDef->asRoot();
if (!this->checkSeeAlso()) {
return false;
}
// report functions that are not covered by related hierarchy
if (!this->checkRelatedFunctions()) {
return false;
}
}
return true;
}
protected:
void checkMethod(string topic, const Definition* csChild, vector<string>* reported) {
if (MarkType::kSubtopic == csChild->fMarkType) {
for (auto child : csChild->fChildren) {
checkMethod(topic, child, reported);
}
return;
} else if (MarkType::kMethod != csChild->fMarkType) {
// only check methods for now
return;
}
bool containsMarkTypeIn = csChild->fDeprecated // no markup for deprecated
|| Definition::MethodType::kConstructor == csChild->fMethodType
|| Definition::MethodType::kDestructor == csChild->fMethodType
|| Definition::MethodType::kOperator == csChild->fMethodType
|| csChild->fClone;
for (auto child : csChild->fChildren) {
if (MarkType::kIn == child->fMarkType) {
containsMarkTypeIn = true;
string subtopic(child->fContentStart,
child->fContentEnd - child->fContentStart);
string fullname = topic + '_' + subtopic;
auto topEnd = fBmhParser.fTopicMap.end();
auto topFind = fBmhParser.fTopicMap.find(fullname);
auto reportEnd = reported->end();
auto reportFind = std::find(reported->begin(), reported->end(), subtopic);
if (topEnd == topFind) {
if (reportEnd == reportFind) {
reported->push_back(subtopic);
}
}
}
}
if (!containsMarkTypeIn) {
PRINTF("No #In: %s\n", csChild->fName.c_str());
}
}
bool checkRelatedFunctions() {
const Definition* cs = this->classOrStruct();
if (!cs) {
return true;
}
const Definition* topic = cs->fParent;
SkASSERT(topic);
SkASSERT(MarkType::kTopic == topic->fMarkType);
string topicName = topic->fName;
vector<string> methodNames;
vector<string> reported;
string prefix = cs->fName + "::";
for (auto& csChild : cs->fChildren) {
checkMethod(topicName, csChild, &reported);
}
for (auto missing : reported) {
string fullname = topicName + '_' + missing;
PRINTF("No #Subtopic: %s\n", fullname.c_str());
}
return true;
}
bool checkSeeAlso() {
return true;
}
const Definition* classOrStruct() {
for (auto& rootChild : fRoot->fChildren) {
if (rootChild->isStructOrClass()) {
return rootChild;
}
}
return nullptr;
}
enum class Optional {
kNo,
kYes,
};
private:
const BmhParser& fBmhParser;
RootDefinition* fRoot;
};
bool SelfCheck(const BmhParser& bmh) {
SelfChecker checker(bmh);
return checker.check();
}
|
