1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
|
/*
* Copyright 2015 Google Inc.
*
* Use of this source code is governed by a BSD-style license that can be
* found in the LICENSE file.
*/
#include "SkBitmap.h"
#include "SkCanvas.h"
#include "SkPath.h"
#include "SkRect.h"
#include "SkRectPriv.h"
#include "Test.h"
static bool has_green_pixels(const SkBitmap& bm) {
for (int j = 0; j < bm.height(); ++j) {
for (int i = 0; i < bm.width(); ++i) {
if (SkColorGetG(bm.getColor(i, j))) {
return true;
}
}
}
return false;
}
static void test_stroke_width_clipping(skiatest::Reporter* reporter) {
SkBitmap bm;
bm.allocN32Pixels(100, 10);
bm.eraseColor(SK_ColorTRANSPARENT);
SkCanvas canvas(bm);
SkPaint paint;
paint.setStyle(SkPaint::kStroke_Style);
paint.setStrokeWidth(10);
paint.setColor(0xff00ff00);
// clip out the left half of our canvas
canvas.clipRect(SkRect::MakeXYWH(51, 0, 49, 100));
// no stroke bleed should be visible
canvas.drawRect(SkRect::MakeWH(44, 100), paint);
REPORTER_ASSERT(reporter, !has_green_pixels(bm));
// right stroke edge should bleed into the visible area
canvas.scale(2, 2);
canvas.drawRect(SkRect::MakeWH(22, 50), paint);
REPORTER_ASSERT(reporter, has_green_pixels(bm));
}
static void test_skbug4406(skiatest::Reporter* reporter) {
SkBitmap bm;
bm.allocN32Pixels(10, 10);
bm.eraseColor(SK_ColorTRANSPARENT);
SkCanvas canvas(bm);
const SkRect r = { 1.5f, 1, 3.5f, 3 };
// draw filled green rect first
SkPaint paint;
paint.setStyle(SkPaint::kFill_Style);
paint.setColor(0xff00ff00);
paint.setStrokeWidth(1);
paint.setAntiAlias(true);
canvas.drawRect(r, paint);
// paint black with stroke rect (that asserts in bug 4406)
// over the filled rect, it should cover it
paint.setStyle(SkPaint::kStroke_Style);
paint.setColor(0xff000000);
paint.setStrokeWidth(1);
canvas.drawRect(r, paint);
REPORTER_ASSERT(reporter, !has_green_pixels(bm));
// do it again with thinner stroke
paint.setStyle(SkPaint::kFill_Style);
paint.setColor(0xff00ff00);
paint.setStrokeWidth(1);
paint.setAntiAlias(true);
canvas.drawRect(r, paint);
// paint black with stroke rect (that asserts in bug 4406)
// over the filled rect, it doesnt cover it completelly with thinner stroke
paint.setStyle(SkPaint::kStroke_Style);
paint.setColor(0xff000000);
paint.setStrokeWidth(0.99f);
canvas.drawRect(r, paint);
REPORTER_ASSERT(reporter, has_green_pixels(bm));
}
DEF_TEST(Rect, reporter) {
test_stroke_width_clipping(reporter);
test_skbug4406(reporter);
}
DEF_TEST(Rect_grow, reporter) {
test_stroke_width_clipping(reporter);
test_skbug4406(reporter);
}
DEF_TEST(Rect_path_nan, reporter) {
SkRect r = { 0, 0, SK_ScalarNaN, 100 };
SkPath p;
p.addRect(r);
// path normally just jams its bounds to be r, but it must notice that r is non-finite
REPORTER_ASSERT(reporter, !p.isFinite());
}
DEF_TEST(Rect_largest, reporter) {
REPORTER_ASSERT(reporter, !SkRectPriv::MakeILarge().isEmpty());
REPORTER_ASSERT(reporter, SkRectPriv::MakeILargestInverted().isEmpty());
REPORTER_ASSERT(reporter, !SkRectPriv::MakeLargest().isEmpty());
REPORTER_ASSERT(reporter, !SkRectPriv::MakeLargeS32().isEmpty());
REPORTER_ASSERT(reporter, SkRectPriv::MakeLargestInverted().isEmpty());
}
/*
* Test the setBounds always handles non-finite values correctly:
* - setBoundsCheck should return false, and set the rect to all zeros
* - setBoundsNoCheck should ensure that rect.isFinite() is false (definitely NOT all zeros)
*/
DEF_TEST(Rect_setbounds, reporter) {
const SkPoint p0[] = { { SK_ScalarInfinity, 0 }, { 1, 1 }, { 2, 2 }, { 3, 3 } };
const SkPoint p1[] = { { 0, SK_ScalarInfinity }, { 1, 1 }, { 2, 2 }, { 3, 3 } };
const SkPoint p2[] = { { SK_ScalarNaN, 0 }, { 1, 1 }, { 2, 2 }, { 3, 3 } };
const SkPoint p3[] = { { 0, SK_ScalarNaN }, { 1, 1 }, { 2, 2 }, { 3, 3 } };
SkRect r;
const SkRect zeror = { 0, 0, 0, 0 };
for (const SkPoint* pts : { p0, p1, p2, p3 }) {
for (int n = 1; n <= 4; ++n) {
bool isfinite = r.setBoundsCheck(pts, n);
REPORTER_ASSERT(reporter, !isfinite);
REPORTER_ASSERT(reporter, r == zeror);
r.setBoundsNoCheck(pts, n);
if (r.isFinite())
r.setBoundsNoCheck(pts, n);
REPORTER_ASSERT(reporter, !r.isFinite());
}
}
}
|
