aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools
Commit message (Collapse)AuthorAge
* GN: add sanitize argGravatar mtklein2016-09-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Attempt to take over all *SAN builds. MSAN has a lot of coordination required between gn/BUILD.gn and gn_flavor.py. I'd like to follow up to move more of this into gn/BUILD.gn, to make it easier to use locally. The compile steps should be much faster now. We no longer build CMake and Clang for every run, instead using the clang_linux CIPD package. This removes the need for all the third_party/externals/llvm/... dependencies. Similarly, since we're using the clang_linux package, we no longer depend on Chrome's Clang, and thus no longer need to sync chromium on these bots. Instead of packaging up MSAN libraries and llvm-symbolizer in the compile output, I have the test / perf bots also depend on the clang_linux package. These do not vary from build to build. No more need for the xsan.blacklist -include hack: Clang, GN, and Ninja all track changes to xsan.blacklist without our help. This has the incidental effect of upgrading the compiler used by *SAN bots from Clang 3.8 to Clang 3.9. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2289343002 Review-Url: https://codereview.chromium.org/2289343002
* Further increase run_benchmark timeoutGravatar Ravi Mistry2016-09-08
| | | | | | | | | | | | | | | Looks like the chromium page sets still hit the 10 min timeout. BUG=skia:5700 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342 # This code is not exercised by trybots. NOTRY=true Change-Id: I57aba4c1541a840d7e4e97112a6485abc20aa3c7 Reviewed-on: https://skia-review.googlesource.com/2342 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* interpolation of coincidence must be local to a single spanGravatar caryclark2016-09-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Pathops makes up intersections that it doesn't detect directly, but do exist. For instance, if a is coincident with b, and b is coincident with c, then for where they overlap a is coincident with c. The intersections are made up in different ways. In a few places, the t values that are detected are interpolated to guess the t values that represent invented intersections. The interpolated t is not necessarily linear, but a linear guess is good enough if the invented t lies between known t values. Additionally, improve debugging. This passes the extended release test suite and additionally passes the first 17 levels in the tiger test suite; previously, path ops passed 7 levels. The tiger suite is composed of 37 levels in increasing complexity, described by about 300K tests. TBR=reed@google.com BUG=skia:5131 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300203002 Review-Url: https://codereview.chromium.org/2300203002
* Add some required packages to tools/install_dependencies.shGravatar tikuta2016-09-02
| | | | | | | | | | | | | | | | | | https://skia.org/user/quick/linux I added following to build skia library. * freeglut3-dev * libglu1-mesa-dev * libosmesa6-dev Minor: * fix indent * sort package list in alphabetical order BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2303733003 Review-Url: https://codereview.chromium.org/2303733003
* Remove tsan.supp.Gravatar mtklein2016-09-01
| | | | | | | | | | | | The remaining suppression (libwebp) is already covered by the compile-time blacklist, tools/xsan.blacklist. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300193002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot,Test-Ubuntu-Clang-Golo-GPU-GT610-x86_64-Release-TSAN-Trybot Review-Url: https://codereview.chromium.org/2300193002
* Try removing Ganesh suppression.Gravatar mtklein2016-09-01
| | | | | | | | | Seems ok: https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-Clang-Golo-GPU-GT610-x86_64-Release-TSAN-Trybot/builds/2 BUG=skia:2459 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301163002 Review-Url: https://codereview.chromium.org/2301163002
* Lift SkString TSAN suppression, to see what yells.Gravatar mtklein2016-09-01
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2295843005 Review-Url: https://codereview.chromium.org/2295843005
* Remove empty {lsan,ubsan}.supp files.Gravatar mtklein2016-09-01
| | | | | | | | | | | | We never used ubsan.supp, and LSAN suppressions are now built into the test binaries. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2302803003 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot Review-Url: https://codereview.chromium.org/2302803003
* Build LSAN suppressions into the test binaries.Gravatar mtklein2016-09-01
| | | | | | | | | | | | | | | | | This way you don't need to set LSAN_SUPPRESSIONS in your environment... sort of foolproof this way. I _think_ the strdup() business from skia:2916 is actually rooted in libfontconfig, so one suppression should cover both old ones. I'll leave the file empty until I clean up mention of it in bot recipes. BUG=skia:2916 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2295153003 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot Review-Url: https://codereview.chromium.org/2295153003
* pathops coincident workGravatar caryclark2016-08-31
| | | | | | | | | | | | | This is working towards fixing all bugs around simplifying the tiger. This installment simplifies the point-t intersection list as it is built rather than doing the analysis once the intersections are complete. This avoids getting the list in an inconsistent state and makes coincident checks faster and more stable. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2237223002 TBR=reed@google.com BUG=skia:5131 Review-Url: https://codereview.chromium.org/2237223002
* Have GrSurfaceProxys and GrGpuResources draw from the same pool of unique idsGravatar robertphillips2016-08-31
| | | | | | | | | | The idea here is that, for wrapped Proxy objects, we want the uniqueID to reflect that of the wrapped object. For this to work the IDs for the non-wrapped versions can't conflict with GrGpuResource's pool of IDs. Split off of: https://codereview.chromium.org/2215323003/ (Start using RenderTargetProxy (omnibus)) GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2301523003 Review-Url: https://codereview.chromium.org/2301523003
* In VulkanWindowContext add check to see if ganesh changed the layout of the ↵Gravatar egdaniel2016-08-31
| | | | | | | | image. BUG=skia: Review-Url: https://codereview.chromium.org/2299663002
* Add some copy support for vulkan msaaGravatar egdaniel2016-08-31
| | | | | | | | | | | | | | This allows us to do copies from: msaa->msaa with same sample count msaa->no-msaa with a resolve Still missing support for no-msaa to msaa which will require a copyAsDraw which is currently stalled and fixing possible driver bugs. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294533002 Review-Url: https://codereview.chromium.org/2294533002
* GN: add sources_when_disabled to optionalGravatar mtklein2016-08-31
| | | | | | | | | | | | | Also make sources_when_disabled and public_defines optional arguments. These are the two mechanisms code uses to turn itself off... probably at most one is ever used per optional. Update fiddle to not crash when there's no PDF backend. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2292343003 Review-Url: https://codereview.chromium.org/2292343003
* SkTextBlob: Begin implementing Extended TextBlob APIGravatar halcanary2016-08-30
| | | | | | | BUG=skia:5434 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2084533004 Review-Url: https://codereview.chromium.org/2084533004
* Increase run_benchmarks timeout because the two Chromium page sets can take ↵Gravatar rmistry2016-08-30
| | | | | | | | | | | | a while BUG=skia:5700 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2298453002 # Trybots do not exercise this code. NOTRY=true TBR=borenet Review-Url: https://codereview.chromium.org/2298453002
* Some tests around surface creation and snapshotting with color spaceGravatar brianosman2016-08-30
| | | | | | | | | | | | Verify the rules that we're converging on for surfaces: - For 8888, we only support sRGB-like gamma, or no color space at all. - For F16, we require a color space, with linear gamma. - For all other formats, we do not support color spaces. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2270823002 Review-Url: https://codereview.chromium.org/2270823002
* Add width, height, unique ID, alpha to debugger DrawImageCommandGravatar msarett2016-08-29
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2290683002 Review-Url: https://codereview.chromium.org/2290683002
* Update ANGLE to latest as of August 25, 2016Gravatar brianosman2016-08-26
| | | | | | | | | | | | | | | | | | With this version, it's now exposing GL_EXT_color_buffer_half_float, but it's (incorrectly) using GL_HALF_FLOAT rather than GL_HALF_FLOAT_OES. In addition, release builds were crashing in EGLImageTest due to an apparent disagreement about calling convention on function-pointer to exported symbol. There is a proper typedef for that in one of their headers, but I can't seem to include it without creating more problems, so I just fixed the decoration on our local typedef. With those changes, all tests pass, and (on my Windows machine), all GMs and SKPs produce identical results vs. master in angle and angle-gl. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2282733003 Review-Url: https://codereview.chromium.org/2282733003
* Do not spam the debugging informationGravatar liyuqian2016-08-25
| | | | | | | | | | | Currently, whenever there's a frame being rendered, we log such an invalidation event. This is very spammy for animations or frame rates test. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2276303003 Review-Url: https://codereview.chromium.org/2276303003
* SkDrawCommand: hintingGravatar halcanary2016-08-25
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2274373003 Review-Url: https://codereview.chromium.org/2274373003
* update Android auto-detection.Gravatar mtklein2016-08-25
| | | | | | | | | | | | Clang defines __ANDROID__ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2278483004 No public API changes. TBR=reed@google.com Review-Url: https://codereview.chromium.org/2278483004
* Made shadows blurry (thru implementing variance mapping)Gravatar vjiaoblack2016-08-25
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2224163005 Review-Url: https://codereview.chromium.org/2224163005
* Fix touch event parameter orderGravatar liyuqian2016-08-22
| | | | | | | | | | | The issue is so obvious... However, all newer Android devices (e.g., Nexus 6P, 5X, 9) are immune to this bug. So I didn't notice this until I tested Viewer app on Nexus 7 yesterday... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2254223002 Review-Url: https://codereview.chromium.org/2254223002
* Build command buffer with is_component_build=falseGravatar borenet2016-08-22
| | | | | | | BUG=skia:5630 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2265913002 Review-Url: https://codereview.chromium.org/2265913002
* Plumb drawArc to SkDevice.Gravatar bsalomon2016-08-19
| | | | | | | | | Plumbs the drawArc canvas method down to SkDevice without converting to a path. Plumbs through the various recording canvas classes. BUG=skia:5227 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2257023003 Review-Url: https://codereview.chromium.org/2257023003
* Add mssa configs for vulkan, and simple bug fixGravatar egdaniel2016-08-17
| | | | | | | BUG=skia:5127 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2251473002 Review-Url: https://codereview.chromium.org/2251473002
* Only open X Display once for all test GLX contextsGravatar bsalomon2016-08-11
| | | | | | | | Saves about 4 seconds of runtime for 'dm --src gm --config gpu' on my system. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2240673002 Review-Url: https://codereview.chromium.org/2240673002
* Improvements to build_command_buffer.pyGravatar bsalomon2016-08-11
| | | | | | | | | | | | Allows a shortcut, -t, for --chrome-build-type and clarifies meaning of the value in help. Removes --fetch. This used to work with gyp builds but since it doesn't run gn it currently fails to build after fetching the src. Also, it wasn't being used. Adds --no-hooks. Like --no-sync it but also doesn't run gclient runhooks. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2236953002 Review-Url: https://codereview.chromium.org/2236953002
* Fix crash in viewer on certain android devicesGravatar egdaniel2016-08-11
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2239493002 Review-Url: https://codereview.chromium.org/2239493002
* Clean up Xlib viewerGravatar jvanverth2016-08-11
| | | | | | | | | | * Make event handling closer to GLFW's * Fix Vulkan refreshing BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2226413002 Review-Url: https://codereview.chromium.org/2226413002
* Update VERSION of "svg" asset.Gravatar rmistry2016-08-10
| | | | | | | | | Removing the SVG due to the reason in https://docs.google.com/document/d/1kYRvUxZTnm1tI_0bTU0BX9jqSSTqPUhGXJVcD3Rcg2c/edit?disco=AAAAAqQSPSc BUG=skia:5628 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2232003002 Review-Url: https://codereview.chromium.org/2232003002
* Add more error printing to know why command buffer lib failed to load.Gravatar bsalomon2016-08-10
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2233073002 Review-Url: https://codereview.chromium.org/2233073002
* Add flag for window rectangles to GrRenderTargetGravatar csmartdalton2016-08-10
| | | | | | | | | | | Adds a flag to GrRenderTarget that indicates whether it can be used with window rectangles. Also attempts to clean up some of the mixed samples API. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2225303002 Review-Url: https://codereview.chromium.org/2225303002
* SVG tool that downloads SVGs from a txt file into a specified dirGravatar rmistry2016-08-10
| | | | | | | BUG=skia:5628 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2234823002 Review-Url: https://codereview.chromium.org/2234823002
* Add RasterWindowContext_macGravatar jvanverth2016-08-09
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2228883003 Review-Url: https://codereview.chromium.org/2228883003
* Check more GLES versions when creating contextGravatar martina.kollarova2016-08-09
| | | | | | | | | Unifies the context creation for GL and GLES into a single loop. BUG=skia:5403 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201033003 Review-Url: https://codereview.chromium.org/2201033003
* Use sse4.2 CRC32 instructions to hash when available.Gravatar mtklein2016-08-08
| | | | | | | | | | | | About 9x faster than Murmur3 for long inputs. Most of this is a mechanical change from SkChecksum::Murmur3(...) to SkOpts::hash(...). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2208903002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot;master.client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot Review-Url: https://codereview.chromium.org/2208903002
* Speculative fix for SKP partner-dir uploadGravatar borenet2016-08-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2229433002 Review-Url: https://codereview.chromium.org/2229433002
* Add new GM for occluded blurmask filter drawsGravatar robertphillips2016-08-04
| | | | | | | | This splits out just the GM portion of https://codereview.chromium.org/2201993003/ (Add GM to test out blurmaskfilter occluders) which included some API changes GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2214033002 Review-Url: https://codereview.chromium.org/2214033002
* Get Mac viewer working with SDLGravatar jvanverth2016-08-04
| | | | | | | | | Also fixes SkiaSDLExample. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2210603003 Review-Url: https://codereview.chromium.org/2210603003
* Move builder_spec, [dm|nanobench]_flags, builder_name_schema to recipesGravatar borenet2016-08-04
| | | | | | | | | | | | | | - builder_name_schema becomes its own recipe module. - builder_spec, dm, and nanobench flags move into vars module. - recipe expectation diffs include: - no more buildbot_spec.py step - "real" dm and nanobench flags, instead of --dummy-flags - some inconsequential stuff in visualbench, which is removed anyway. BUG=skia:5578 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2215803002 Review-Url: https://codereview.chromium.org/2215803002
* Add new bench for occluded blurmaskfilter drawsGravatar robertphillips2016-08-04
| | | | | | | | | | | | w/ occluders 44/44 MB 6 497us 500us 500us 502us 0% .oOOooooOO gpu bluroccludedrrect w/o occluders 41/41 MB 5 1.08ms 1.09ms 1.12ms 1.47ms 11% .........O gpu bluroccludedrrect GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2203153002 Review-Url: https://codereview.chromium.org/2203153002
* Convert SkAutoTUnref<SkData> to sk_sp<SkData>.Gravatar bungeman2016-08-03
| | | | | | | | | With the move from SkData::NewXXX to SkData::MakeXXX most SkAutoTUnref<SkData> were changed to sk_sp<SkData>. However, there are still a few SkAutoTUnref<SkData> around, so clean them up. Review-Url: https://codereview.chromium.org/2212493002
* SkShaper: optionally disable harfbuzzGravatar halcanary2016-08-03
| | | | | | | | | | | also, re-enable warnings. motivation: used by me for PDF testing. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2201153002 Review-Url: https://codereview.chromium.org/2201153002
* Fix fake_specs.py, update recipe expectationGravatar borenet2016-08-03
| | | | | | | BUG=skia:5578 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2200763002 Review-Url: https://codereview.chromium.org/2200763002
* Move off SK_SUPPORT_LEGACY_DATA_FACTORIES.Gravatar bungeman2016-08-02
| | | | | | | This moves Skia code off of SK_SUPPORT_LEGACY_DATA_FACTORIES. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2206633004 Review-Url: https://codereview.chromium.org/2206633004
* gn: fix fiddleGravatar mtklein2016-08-02
| | | | | | | | | | | | | - __SK_FORCE_IMAGE_DECODER_LINKING makes sure the PNG encoder is linked - updated path to make working with sample draw.cpp easier. No public API changes. TBR=reed@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2202353002 Review-Url: https://codereview.chromium.org/2202353002
* Add code to lua paths to get the fill path and get lists of verbs andGravatar hstern2016-08-02
| | | | | | | | | points BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2199823002 Review-Url: https://codereview.chromium.org/2199823002
* Fix build_command_buffer for WindowsGravatar borenet2016-08-02
| | | | | | | BUG=skia:5597 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2207563002 Review-Url: https://codereview.chromium.org/2207563002