GN: add sources_when_disabled to optional

Also make sources_when_disabled and public_defines optional arguments.
These are the two mechanisms code uses to turn itself off...
probably at most one is ever used per optional.

Update fiddle to not crash when there's no PDF backend.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2292343003

Review-Url: https://codereview.chromium.org/2292343003

1 files changed, 6 insertions, 4 deletions

diff --git a/tools/fiddle/fiddle_main.cpp b/tools/fiddle/fiddle_main.cpp
index bf6a8c27d5..0fa6158666 100644
--- a/tools/fiddle/fiddle_main.cpp
+++ b/tools/fiddle/fiddle_main.cpp
@@ -136,10 +136,12 @@ int main() {
     if (options.pdf) {
         SkDynamicMemoryWStream pdfStream;
         sk_sp<SkDocument> document(SkDocument::MakePDF(&pdfStream));
-        srand(0);
-        draw(document->beginPage(options.size.width(), options.size.height()));
-        document->close();
-        pdfData.reset(pdfStream.copyToData());
+        if (document) {
+            srand(0);
+            draw(document->beginPage(options.size.width(), options.size.height()));
+            document->close();
+            pdfData.reset(pdfStream.copyToData());
+        }
     }
     if (options.skp) {
         SkSize size;