aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools
Commit message (Collapse)AuthorAge
* Revert "Revert "Revert "replace SkXfermode obj with SkBlendMode enum in ↵Gravatar Mike Reed2016-10-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | paints""" This reverts commit I86875511a13497112827cbaed1dbd7639e9e3d10. legacy (100K) skp failure Original change's description: > Revert "Revert "replace SkXfermode obj with SkBlendMode enum in paints"" > > This reverts commit ce02e7175872abde3721df9e5d3ec0ab8384cd8e. > > BUG=skia: > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2878 > > Change-Id: I86875511a13497112827cbaed1dbd7639e9e3d10 > Reviewed-on: https://skia-review.googlesource.com/2878 > Reviewed-by: Matt Sarett <msarett@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=msarett@google.com,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ife6f0cf3a22b3e8cf885a188f7f44e1ff62e06a5 Reviewed-on: https://skia-review.googlesource.com/2881 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Revert "replace SkXfermode obj with SkBlendMode enum in paints""Gravatar Mike Reed2016-10-03
| | | | | | | | | | | | | This reverts commit ce02e7175872abde3721df9e5d3ec0ab8384cd8e. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2878 Change-Id: I86875511a13497112827cbaed1dbd7639e9e3d10 Reviewed-on: https://skia-review.googlesource.com/2878 Reviewed-by: Matt Sarett <msarett@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "replace SkXfermode obj with SkBlendMode enum in paints"Gravatar Mike Reed2016-10-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit I4fb489ba6b3f77b458f7e4a99f79c7ad10859135. Reason for revert: <INSERT REASONING HERE> Original change's description: > replace SkXfermode obj with SkBlendMode enum in paints > > BUG=skia:5814 > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2714 > > Change-Id: I4fb489ba6b3f77b458f7e4a99f79c7ad10859135 > Reviewed-on: https://skia-review.googlesource.com/2714 > Reviewed-by: Florin Malita <fmalita@chromium.org> > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Mike Reed <reed@google.com> > TBR=bsalomon@google.com,fmalita@chromium.org,fmalita@google.com,reed@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: I3e43f79ef5c1709929663fe63cc1f67cd78270b7 Reviewed-on: https://skia-review.googlesource.com/2871 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* replace SkXfermode obj with SkBlendMode enum in paintsGravatar Mike Reed2016-10-03
| | | | | | | | | | | | BUG=skia:5814 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2714 Change-Id: I4fb489ba6b3f77b458f7e4a99f79c7ad10859135 Reviewed-on: https://skia-review.googlesource.com/2714 Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Add fence support for TransferBuffersGravatar jvanverth2016-09-30
| | | | | | | BUG=skia:4604 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2384463003 Review-Url: https://codereview.chromium.org/2384463003
* Use SkOnce to squelch command buffer spamGravatar brianosman2016-09-29
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2382793002 Review-Url: https://codereview.chromium.org/2382793002
* Revert of Explicit control in tools of ANGLE frontend and backend (patchset ↵Gravatar bsalomon2016-09-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #6 id:90001 of https://codereview.chromium.org/2381033002/ ) Reason for revert: Broke bots Original issue's description: > Explicit control in tools of ANGLE frontend and backend > > Update the ANGLE test GL context, GrContextFactory, and config parsing to allow explicit control of ANGLE front/backend. > > This will allow us to explicitly test ES2 vs ES3 interfaces to ANGLE as well as D3D9, D3D11, and OpenGL backends. > > Also makes the angle api types valid in all builds (but will just fail when SK_ANGLE=1 or not on windows for the d3d backends). > > BUG=skia:5804 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2381033002 > > Committed: https://skia.googlesource.com/skia/+/50094fb489543655df026be4e4f99e09e57a1f49 TBR=brianosman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:5804 Review-Url: https://codereview.chromium.org/2384483003
* Explicit control in tools of ANGLE frontend and backendGravatar bsalomon2016-09-29
| | | | | | | | | | | | | | | | Update the ANGLE test GL context, GrContextFactory, and config parsing to allow explicit control of ANGLE front/backend. This will allow us to explicitly test ES2 vs ES3 interfaces to ANGLE as well as D3D9, D3D11, and OpenGL backends. Also makes the angle api types valid in all builds (but will just fail when SK_ANGLE=1 or not on windows for the d3d backends). BUG=skia:5804 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2381033002 NOTREECHECKS=true NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2381033002
* skpbench: use accumulative result as the defaultGravatar csmartdalton2016-09-29
| | | | | | | | | | | Uses accum instead of median for the first column in skpbench.cpp, and the default result for parseskpbench.py. The accum is empirically proving to be more repeatable than the median. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2378383002 Review-Url: https://codereview.chromium.org/2378383002
* skpbench: use double buffering instead of tripleGravatar csmartdalton2016-09-28
| | | | | | | | | | | We have no need for our command stream to get more than a couple of frames deep. Any more and we only increase our chances of sporadic flushing and unreliable timings. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2376043002 Review-Url: https://codereview.chromium.org/2376043002
* Tag checkerboard bitmaps as sRGBGravatar brianosman2016-09-28
| | | | | | | | | | | | | | | Significantly reduces the diff between legacy and sRGB/F16 on about 25 GMs. This is just the biggest piece of low-hanging fruit. Many GMs create N32 raster surfaces to procedurally generate source textures, and I'd like to fix all of them. It's much easier to reason about the GMs (is sRGB doing the right thing) when everything is tagged like this - the only expected differences are due to filtering and blending. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368933003 Committed: https://skia.googlesource.com/skia/+/fe843cea499ba163d53281425af210b1887d28e7 Review-Url: https://codereview.chromium.org/2368933003
* skpbench: run for a fixed durationGravatar csmartdalton2016-09-28
| | | | | | | | | Runs for a fixed amount of time instead of a fixed amount of samples. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2374093002 Review-Url: https://codereview.chromium.org/2374093002
* Use brackets for explicit GPU config params in toolsGravatar bsalomon2016-09-28
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2378163003 Review-Url: https://codereview.chromium.org/2378163003
* monobench: usability tweaksGravatar Mike Klein2016-09-28
| | | | | | | | | | | | | | | - Allow an second argument to limit the number of samples. - If no benchmarks match, warn and exit instead of infinitely looping. The default limit of 2147483647 10ms samples will run for 9 months, which I think is long enough to not need any special infinity logic. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2747 Change-Id: Id70cf77b624e19dc04e1d75a71385aee3c988a80 Reviewed-on: https://skia-review.googlesource.com/2747 Reviewed-by: Herb Derby <herb@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Move toXYZD50() to SkColorSpace_BaseGravatar msarett2016-09-28
| | | | | | | | | | | | SkColorSpace needs to become more versatile, in order to support profiles that cannot specified with just a "to XYZ D50" matrix. This a just first step to clean up the public API. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2381553002 Review-Url: https://codereview.chromium.org/2381553002
* Make GPU configs use kRGBA color type not kN32.Gravatar bsalomon2016-09-28
| | | | | | | | | This makes ES msaa contexts testable on systems where kN32 is compiled as kBGRA due to the fact that render buffers are not always supported for GL_BGRA with GL_EXT_texture_format_BGRA8888. BUG=skia:5804 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2378713002 Review-Url: https://codereview.chromium.org/2378713002
* Revert of Tag checkerboard bitmaps as sRGB (patchset #1 id:1 of ↵Gravatar brianosman2016-09-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2368933003/ ) Reason for revert: Regression on displacement GM when sRGB support is lacking. Original issue's description: > Tag checkerboard bitmaps as sRGB > > Significantly reduces the diff between legacy and sRGB/F16 on about 25 > GMs. This is just the biggest piece of low-hanging fruit. Many GMs create > N32 raster surfaces to procedurally generate source textures, and I'd like > to fix all of them. It's much easier to reason about the GMs (is sRGB > doing the right thing) when everything is tagged like this - the only > expected differences are due to filtering and blending. > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368933003 > > Committed: https://skia.googlesource.com/skia/+/fe843cea499ba163d53281425af210b1887d28e7 TBR=mtklein@google.com,reed@google.com,robertphillips@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: Review-Url: https://codereview.chromium.org/2375063002
* Remove gen_bench_expectations_from_codereviewGravatar borenet2016-09-27
| | | | | | | | | It hasn't been used in a long time. BUG=skia:2969 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2373803002 Review-Url: https://codereview.chromium.org/2373803002
* remove more stray semicolons from Vulkan codeGravatar Mike Klein2016-09-27
| | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2707 Change-Id: Idc00efeda2f9901a6f33c987202be2a781b24269 Reviewed-on: https://skia-review.googlesource.com/2707 Reviewed-by: Mike Klein <mtklein@chromium.org>
* We really shouldn't pass SkFontStyle to printf as %d.Gravatar Mike Klein2016-09-27
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2721 Change-Id: I362063bea3909b2581d8e9b7860d4ac321082808 Reviewed-on: https://skia-review.googlesource.com/2721 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Remove stray semicolons.Gravatar Mike Klein2016-09-27
| | | | | | | | | | | | | | | | Turns out function declarations don't end in semicolons... BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2720 No public API changes. TBR=reed@google.com Change-Id: I72b56d52e1ff7fa6e89c295b0de8c46599791ebb Reviewed-on: https://skia-review.googlesource.com/2720 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Revert of Fix bufferIndex check in VulkanWindowContext (patchset #1 id:1 of ↵Gravatar egdaniel2016-09-26
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2363353003/ ) Reason for revert: Fix not correct. Original issue's description: > Fix bufferIndex check in VulkanWindowContext > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363353003 > > Committed: https://skia.googlesource.com/skia/+/e6bd20e62b827a1f26fa491fc628f015d208350f TBR=jvanverth@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2370953002
* Fix bufferIndex check in VulkanWindowContextGravatar egdaniel2016-09-26
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2363353003 Review-Url: https://codereview.chromium.org/2363353003
* Tag checkerboard bitmaps as sRGBGravatar brianosman2016-09-26
| | | | | | | | | | | | | | Significantly reduces the diff between legacy and sRGB/F16 on about 25 GMs. This is just the biggest piece of low-hanging fruit. Many GMs create N32 raster surfaces to procedurally generate source textures, and I'd like to fix all of them. It's much easier to reason about the GMs (is sRGB doing the right thing) when everything is tagged like this - the only expected differences are due to filtering and blending. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2368933003 Review-Url: https://codereview.chromium.org/2368933003
* -Wcomma may be good to go now.Gravatar Mike Klein2016-09-26
| | | | | | | | | | | | | This cleans up 3 remaining sites using , that probably meant ; BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2605 Change-Id: I5e48bcd85d72a205d2b0c860461dab1ec793dd18 Reviewed-on: https://skia-review.googlesource.com/2605 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* bin/coverage: a GN version of the coverage scriptGravatar halcanary2016-09-26
| | | | | | | | intended to replace tools/coverage when GYP is gone. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343243002 Review-Url: https://codereview.chromium.org/2343243002
* fix tiger bGravatar caryclark2016-09-26
| | | | | | | | | | | | | | | The tiger tests have uncovered numerous bugs. This CL fixes the last of them. If a pair of curves do not intersect, but have one or both ends very close to the opposite curve, consider that an intersection. TBR=reed@google.com BUG=skia:5131 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2356363003 Review-Url: https://codereview.chromium.org/2356363003
* Add SkColor4f serializationGravatar brianosman2016-09-25
| | | | | | | | | | Adjusted usage in color shader, and will also be using this in gradients, soon. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2334123003 Review-Url: https://codereview.chromium.org/2334123003
* Add Pixel C knobs to skpbenchGravatar csmartdalton2016-09-23
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2369533002 Review-Url: https://codereview.chromium.org/2369533002
* split tight quads and conicsGravatar caryclark2016-09-23
| | | | | | | | | | | | Tight quads and conics may nearly fold over on themselves, confusing coincidence against other curves. Split them at their max curvature early on to avoid complicating later logic. TBR=reed@google.com BUG=skia:5131 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357353002 Review-Url: https://codereview.chromium.org/2357353002
* skpbench fixes for linuxGravatar csmartdalton2016-09-22
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2354273004 Review-Url: https://codereview.chromium.org/2354273004
* GN: build skiaserveGravatar mtklein2016-09-22
| | | | | | | | | | | | | | | | | I trimmed the libmicrohttpd sources and defines down to the minimum needed to build and run. This builds and runs on Linux and Android for me. Request.h was missing an include for SkTypes.h, which supplies the default for SK_GPU_SUPPORTED if not otherwise defined. To build on Android, exit() -> _exit(). build.py was unused. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2367513002 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2367513002
* Clean up dead code.Gravatar mtklein2016-09-22
| | | | | | | | | SkOSEnvironment was used to set --enable-gl-path-rendering, and is now unused. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2365483002 Review-Url: https://codereview.chromium.org/2365483002
* Add hardware monitoring to skpbenchGravatar csmartdalton2016-09-22
| | | | | | | | | | | | | | | Adds a Hardware class with hooks for entering and exiting "benchmarking" mode (e.g. locking clocks, etc.) as well as periodic polling of hardware to verify the environment is stable. Adds a partial implementation for generic Android hardware, but ultimately we will need to write specific classes tailored to each unique platform we need to test. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2360473002 Review-Url: https://codereview.chromium.org/2360473002
* GN: take over CommandBuffer botGravatar mtklein2016-09-21
| | | | | | | | | | As you suspected, I see nothing preventing us from building our side of things unconditionally. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2358173002 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2358173002
* Support use of non-coherent memory allocations in Vulkan.Gravatar jvanverth2016-09-20
| | | | | | | BUG=skia:5034 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2348523002 Review-Url: https://codereview.chromium.org/2348523002
* abstract name of clipping ops, to transtion to a more restricted setGravatar reed2016-09-20
| | | | | | | | | | | SkRegion::Op --> SkCanvas::ClipOp (alias) --> SkClipOp pre-CL needed in chrome : https://codereview.chromium.org/2355583002/ BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2355483002 Review-Url: https://codereview.chromium.org/2355483002
* Auto-generate much of the help text for --config to reduce maintenanceGravatar brianosman2016-09-20
| | | | | | | | | | The list of configs, and the details about all predefined configs are now built directly from the gPredefinedConfigs array. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2354943002 Review-Url: https://codereview.chromium.org/2354943002
* Add ability to pick a different gamut in GPU f16 or sRGB configsGravatar brianosman2016-09-19
| | | | | | | | | | | | | | | | | | | | | | | For now, the only options are sRGB or WideGamutRGB Basically, the color option to the gpu config is now of the form: 8888|srgb[_gamut]|f16[_gamut] color=8888 still implies legacy behavior srgb implies 8-bit gamma-correct rendering (via sRGB format) f16 implies 16-bit gamma-correct rendering (via F16 format) Either of the last two options can then optionally include a gamut specifier, either _srgb or _wide. _srgb selects the (default) sRGB gamut _wide selects the Adobe Wide Gamut RGB gamut, which is nice for testing, in that it's significantly wider than sRGB, so rendering differences are obvious. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350003003 Review-Url: https://codereview.chromium.org/2350003003
* Add adb support to skpbenchGravatar csmartdalton2016-09-19
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2350003002 Review-Url: https://codereview.chromium.org/2350003002
* skpbenchGravatar csmartdalton2016-09-19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | skpbench is a benchmarking suite for skps that aims to generate 100% repeatable results. The initial commit consists of three parts: skpbench A minimalist program whose sole purpose is to open an skp file, benchmark it on a single config, and exit. No tiling, looping, or other fanciness is used; it just draws the skp whole into a size- matched render target and syncs the GPU after each draw. Limiting the entire process to a single config/skp pair helps to keep the results repeatable. skpbench.py A wrapper to execute the skpbench binary with various configs and skps. It also monitors the output in order to filter out and re-run results with an unacceptable stddev. In the future this script will lock down and monitor clocks and temperatures. parseskpbench.py A utility for parsing skpbench output into a spreadsheet. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2341823002 Review-Url: https://codereview.chromium.org/2341823002
* Delete unused coverage recipe code.Gravatar mtklein2016-09-19
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2353483003 Review-Url: https://codereview.chromium.org/2353483003
* Is it just me or is this logging just noise?Gravatar mtklein2016-09-16
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2343233002 Review-Url: https://codereview.chromium.org/2343233002
* Fix Seal_of_Mississippi URL and update version of SVG asset.Gravatar rmistry2016-09-16
| | | | | | | | | BUG=skia:5757 BUG=skia:5767 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2342323002 Review-Url: https://codereview.chromium.org/2342323002
* SkFontData to use smart pointers.Gravatar bungeman2016-09-16
| | | | | | | | | | | | | | | | | The SkFontData type is not exposed externally, so any method which uses it can be updated to use smart pointers without affecting external users. Updating this first will make updating the public API much easier. This also updates SkStreamAsset* SkStream::NewFromFile(const char*) to std::unique_ptr<SkStreamAsset> SkStream::MakeFromFile(const char*). It appears that no one outside Skia is currently using SkStream::NewfromFile so this is a good time to update it as well. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002 Committed: https://skia.googlesource.com/skia/+/d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c Review-Url: https://codereview.chromium.org/2339273002
* Tweak valgrind suppressions for intentional leaks.Gravatar mtklein2016-09-16
| | | | | | | | | | | | | | | | | | | | | | | | | This is a follow up to building the Valgrind bots with GN. It's not clear why these need to leak, but we might as well update the suppressions. The stacks now look like this: Memcheck:Leak match-leak-kinds: possible fun:calloc fun:_dl_allocate_tls fun:pthread_create@@GLIBC_2.2.5 fun:_ZN8SkThreadC1EPFvPvES0_ fun:_Z14nanobench_mainv fun:(below main) We suppress fun:main in that last slot, so just make it ... TBR= BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347153002 Review-Url: https://codereview.chromium.org/2347153002
* Revert of SkFontData to use smart pointers. (patchset #3 id:40001 of ↵Gravatar bungeman2016-09-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2339273002/ ) Reason for revert: Killing Mac Original issue's description: > SkFontData to use smart pointers. > > The SkFontData type is not exposed externally, so any method which uses > it can be updated to use smart pointers without affecting external > users. Updating this first will make updating the public API much > easier. > > This also updates SkStreamAsset* SkStream::NewFromFile(const char*) to > std::unique_ptr<SkStreamAsset> SkStream::MakeFromFile(const char*). It > appears that no one outside Skia is currently using SkStream::NewfromFile > so this is a good time to update it as well. > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002 > > Committed: https://skia.googlesource.com/skia/+/d8c2476a8b1e1e1a1771b17e8dd4db8645914f8c TBR=mtklein@chromium.org,halcanary@google.com,mtklein@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2343933002
* SkFontData to use smart pointers.Gravatar bungeman2016-09-15
| | | | | | | | | | | | | | | | The SkFontData type is not exposed externally, so any method which uses it can be updated to use smart pointers without affecting external users. Updating this first will make updating the public API much easier. This also updates SkStreamAsset* SkStream::NewFromFile(const char*) to std::unique_ptr<SkStreamAsset> SkStream::MakeFromFile(const char*). It appears that no one outside Skia is currently using SkStream::NewfromFile so this is a good time to update it as well. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339273002 Review-Url: https://codereview.chromium.org/2339273002
* quad and conic do not intersectGravatar caryclark2016-09-15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a quad a conic intersect only where the end of one is contained by the convex hull of the other, and the curve contained by the hull is nearly a straight line, treating it as a line may move the end point to the other side of the curve. Detect this by checking to see if the end point is in the hull, and if so, continue to subdivide the curve rather than treating it as a line. This fixes several existing tests that were disabled earlier this year. A typo in SkDCurve::nearPoint() prevented detecting when the end of a line was nearly touching a curve. Also fixed concidence a bit to get the second half of tiger further along. All existing tests, including extended testing in Release and the first half of tiger, work. TBR=reed@google.com BUG=skia:5131 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2338323002 Review-Url: https://codereview.chromium.org/2338323002
* Fix SkDrawTextBlobCommand null blob crashGravatar fmalita2016-09-14
| | | | | | | | | | After https://codereview.chromium.org/2335493005, we're moving the param into a local field -> we should no longer access it. TBR=robertphillips@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2344523003 Review-Url: https://codereview.chromium.org/2344523003
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-08 00:05:18 +0000