aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools
Commit message (Collapse)AuthorAge
* hide Config in SkImageDecoder -- use SkColorType insteadGravatar reed2014-06-12
| | | | | | | | | | patch from issue 334613003 TBR=scroggo Author: reed@chromium.org Review URL: https://codereview.chromium.org/334793002
* Cleanup: Delete sk_tools::make_filepath() in favor of SkOSPath::SkPathJoin().Gravatar tfarina2014-06-12
| | | | | | | | | | BUG=None TEST=make tools tests && out/Debug/tests R=epoger@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/327403002
* Suppress libpoppler and its dependent liblcms in TSAN.Gravatar mtklein2014-06-11
| | | | | | | | | | | This will let us eventually turn PDF back on in DM. BUG=skia: R=halcanary@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/330433003
* Cleanup: Delete sk_tools::get_basename() in favor of SkOSPath::SkBasename().Gravatar tfarina2014-06-11
| | | | | | | | | | BUG=None TEST=make tests && out/Debug/tests R=epoger@google.com Author: tfarina@chromium.org Review URL: https://codereview.chromium.org/321693002
* Silence TSAN warnings about is_lcd_supported for now.Gravatar mtklein2014-06-10
| | | | | | | | | | | BUG=skia:1792 NOTRY=true R=bungeman@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/328663006
* hide SkBitmap::setConfigGravatar reed2014-06-09
| | | | | | | | | | patch from issue 325733002 TBR=scroggo Author: reed@chromium.org Review URL: https://codereview.chromium.org/322963002
* bench_record: No need for --flags if there are no RecordingFlags anymore.Gravatar mtklein2014-06-09
| | | | | | | | | BUG=skia: R=robertphillips@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/327533002
* remove GM result-grooming tools that use skia-autogenGravatar epoger2014-06-09
| | | | | | | | | BUG=skia:553 R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/320443002
* Remove SkPicture::kUsePathBoundsForClip_RecordingFlagGravatar robertphillips2014-06-09
| | | | | | | | | | The real question is whether we ever want to record a picture without using the path bounds for a conservative (but faster) clip answer? R=reed@google.com, mtklein@google.com, djsollen@google.com, scroggo@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/316143003
* Add SkBarriers_tsan.h.Gravatar mtklein2014-06-06
| | | | | | | | | | | | | | Slight counterproposal to crrev.com/310663002. BUG=skia: No API changes. R=bungeman@google.com, mtklein@google.com, reed@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/306373002
* reland "rebaseline_server: download actual-results.json files from GCS ↵Gravatar epoger2014-06-05
| | | | | | | | | | | | | instead of SVN" relands https://codereview.chromium.org/310093003 with modifications. BUG=skia:2641 R=jcgregorio@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/313343003
* Fix submit_tryGravatar borenet2014-06-05
| | | | | | | | | BUG=skia:2643 R=epoger@google.com, tfarina@chromium.org Author: borenet@google.com Review URL: https://codereview.chromium.org/317823003
* Revert "rebaseline_server: download actual-results.json files from GCS ↵Gravatar epoger2014-06-04
| | | | | | | | | | | | | | | | instead of SVN" This reverts commit f4666045f378dee22ce40108e90bf5195634ebfc. BUG=skia:2641 NOTREECHECKS=True NOTRY=True R=jcgregorio@google.com TBR=jcgregorio Author: epoger@google.com Review URL: https://codereview.chromium.org/317783004
* rebaseline_server: download actual-results.json files from GCS instead of SVNGravatar epoger2014-06-04
| | | | | | | | | BUG=skia:553 R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/310093003
* Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer)Gravatar robertphillips2014-06-04
| | | | | | | | R=reed@google.com, bsalomon@google.com, mtklein@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/313613004
* Added grid data to logging outputGravatar kelvinly2014-06-03
| | | | | | | | | BUG=skia: R=bensong@google.com, jcgregorio@google.com Author: kelvinly@google.com Review URL: https://codereview.chromium.org/318433003
* Revert of Try TSAN blacklist for SkGLContextHelper::init. ↵Gravatar mtklein2014-06-02
| | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/309823004/) Reason for revert: the bot's clang doesn't know -fsanitize-blacklist Original issue's description: > Try TSAN blacklist for SkGLContextHelper::init. > > Submitting to test this; this particular problem only happens on the bot. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/ab2ec19b975a898d4ee2278ddad7d4268f134478 R=mtklein@chromium.org TBR=mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Author: mtklein@google.com Review URL: https://codereview.chromium.org/314543002
* Try TSAN blacklist for SkGLContextHelper::init.Gravatar mtklein2014-06-02
| | | | | | | | | | | Submitting to test this; this particular problem only happens on the bot. BUG=skia: R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/309823004
* Tweak TSAN suppressions.Gravatar mtklein2014-06-02
| | | | | | | | | BUG=skia: R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/312613002
* use most innocuous characters possible within skimage output filenamesGravatar epoger2014-06-02
| | | | | | | | | BUG=skia:2634 R=scroggo@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/302323003
* Revert of stop using brackets within skimage output filenames ↵Gravatar epoger2014-06-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/303263012/) Reason for revert: Broke http://108.170.220.120:10117/builders/Test-ChromeOS-Link-HD4000-x86_64-Release/builds/2806/steps/UploadSKImageResults/logs/stdio : [13:38:43.401942] /bin/sh: 1: Syntax error: "(" unexpected [13:38:43.902632] Command /home/chrome-bot/buildbot/skiabot-shuttle-ubuntu12-003/buildbot/third_party/chromium_buildbot/scripts/slave/../../third_party/gsutil/gsutil cp -a private /home/chrome-bot/buildbot/skiabot-shuttle-ubuntu12-003/buildbot/third_party/chromium_buildbot/slave/Test-ChromeOS-Link-HD4000-x86_64-Release/build/skia/out/Release/skimage_out/images/bitmap-64bitMD5/webp-test-webp-(123,263,587,394)/16263897892077508819.png gs://chromium-skia-gm/skimage/output/images/bitmap-64bitMD5/webp-test-webp-(123,263,587,394)/16263897892077508819.png failed with retcode 2, try 1. Original issue's description: > stop using brackets within skimage output filenames > > BUG=skia:2634 > > Committed: https://skia.googlesource.com/skia/+/f07892413cd2359549dc187f1d10bc48d7d263ba R=scroggo@google.com TBR=scroggo@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2634 Author: epoger@google.com Review URL: https://codereview.chromium.org/314443002
* stop using brackets within skimage output filenamesGravatar epoger2014-06-02
| | | | | | | | | BUG=skia:2634 R=scroggo@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/303263012
* Update TSAN suppressions.Gravatar mtklein2014-06-02
| | | | | | | | | | | | | | | TSAN suppressions need to be on their own line, even free of comments. Also, temporarily add SK_ANNOTATE_UNPROTECTED_READ to sk_acquire_load. Will remove this when we're done iterating on SkBarriers_tsan.h: TSAN has an atomic load that makes the annotation moot. BUG=skia: R=bungeman@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/308073013
* Sanitizing source files in Housekeeper-NightlyGravatar skia.committer@gmail.com2014-05-30
| | | | git-svn-id: http://skia.googlecode.com/svn/trunk@14984 2bbb7eff-a529-9590-31e7-b0007b416f81
* Reland https://codereview.chromium.org/286903025Gravatar commit-bot@chromium.org2014-05-29
| | | | | | | | | | | BUG=skia: R=bensong@google.com, epoger@google.com Author: kelvinly@google.com Review URL: https://codereview.chromium.org/304613002 git-svn-id: http://skia.googlecode.com/svn/trunk@14966 2bbb7eff-a529-9590-31e7-b0007b416f81
* Remove SkRecorder's kWriteOnly mode.Gravatar commit-bot@chromium.org2014-05-29
| | | | | | | | | | | | | | | | | | | I'm soon going to have SkRecorder start calling getTotalMatrix(), which would be broken in write-only mode. That change is big and nebulous, but it's clear kWriteOnly needs to go, so we might as well kill it now. My notes in bench_playback about kWriteOnly mode being important were probably overly cautious. I now think this is a fair enough comparison even re-recording into a read-write canvas. BUG=skia:2378 R=fmalita@chromium.org, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/290653004 git-svn-id: http://skia.googlecode.com/svn/trunk@14963 2bbb7eff-a529-9590-31e7-b0007b416f81
* Bench rebaseline from codereview: fix is_finishedGravatar commit-bot@chromium.org2014-05-29
| | | | | | | | | | | | | | R=epoger@google.com, bensong@google.com TBR=benchen, epoger BUG=skia:2225 NOTREECHECKS=true NOTRY=true Author: borenet@google.com Review URL: https://codereview.chromium.org/304943002 git-svn-id: http://skia.googlecode.com/svn/trunk@14962 2bbb7eff-a529-9590-31e7-b0007b416f81
* Bench Rebaseline from Codereview: separate out all_trybots_finished()Gravatar commit-bot@chromium.org2014-05-29
| | | | | | | | | | | | BUG=skia:2225 NOTREECHECKS=true R=epoger@google.com, bensong@google.com Author: borenet@google.com Review URL: https://codereview.chromium.org/301143002 git-svn-id: http://skia.googlecode.com/svn/trunk@14951 2bbb7eff-a529-9590-31e7-b0007b416f81
* add a verbose flag to skdiff that shows the progress and status ofGravatar commit-bot@chromium.org2014-05-28
| | | | | | | | | | | | | each comparison BUG= R=bungeman@google.com Author: humper@google.com Review URL: https://codereview.chromium.org/302443012 git-svn-id: http://skia.googlecode.com/svn/trunk@14923 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add script to rebaseline benches from codereview trybot resultsGravatar commit-bot@chromium.org2014-05-28
| | | | | | | | | | | | | | | | | | | | | | This script is designed to be used by the RecreateSKPs bot. Eventually, the bot will: 1. Generate new SKPs 2. Upload the new SKPs to a subdirectory with an ID or generation number. 3. Change Skia to use the new SKPs: a. Create and upload a Skia CL which changes the "current SKP generation" file to point to the new SKPs b. Launch Perf trybots on that CL. c. Call this script every 5 minutes until it successfully creates new baselines for each of the launched Perf bots. d. Add the new baselines to the CL e. Upload a second patch set of the CL f. Check the CQ bit on the CL BUG=skia:2225 R=epoger@google.com, halcanary@google.com, bensong@google.com Author: borenet@google.com Review URL: https://codereview.chromium.org/297893004 git-svn-id: http://skia.googlecode.com/svn/trunk@14921 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of PictureBenchmark JSON logging ↵Gravatar commit-bot@chromium.org2014-05-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/286903025/) Reason for revert: Broke some Windows builds; see http://skbug.com/2609 ('certain Windows Build-* bots failing since r14905'). Before re-landing with a fix, please send to some of the trybots that failed the first time. Original issue's description: > Add JSON logging support to bench_pictures by adding a PictureResultsWriter class (in tools/PictureResultsWriter.h) to process logging information, using a very similar style as bench/ResultsWriter.h > > JSON format described in code, above PictureJSONResultsWriter class > > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=14906 R=bensong@google.com, jcgregorio@google.com, kelvinly@google.com TBR=bensong@google.com, jcgregorio@google.com, kelvinly@google.com NOTREECHECKS=true NOTRY=true BUG=skia:2609 Author: epoger@google.com Review URL: https://codereview.chromium.org/306483010 git-svn-id: http://skia.googlecode.com/svn/trunk@14910 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add JSON logging support to bench_pictures by adding a PictureResultsWriter ↵Gravatar commit-bot@chromium.org2014-05-27
| | | | | | | | | | | | | | | class (in tools/PictureResultsWriter.h) to process logging information, using a very similar style as bench/ResultsWriter.h JSON format described in code, above PictureJSONResultsWriter class BUG=skia: R=bensong@google.com, jcgregorio@google.com Author: kelvinly@google.com Review URL: https://codereview.chromium.org/286903025 git-svn-id: http://skia.googlecode.com/svn/trunk@14906 2bbb7eff-a529-9590-31e7-b0007b416f81
* hide discardable factory from public imagegenerator apiGravatar commit-bot@chromium.org2014-05-27
| | | | | | | | | | | BUG=skia: R=halcanary@google.com, scroggo@google.com, djsollen@google.com Author: reed@google.com Review URL: https://codereview.chromium.org/295243006 git-svn-id: http://skia.googlecode.com/svn/trunk@14889 2bbb7eff-a529-9590-31e7-b0007b416f81
* Revert of Turn on preprocessing by default ↵Gravatar commit-bot@chromium.org2014-05-23
| | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/299033002/) Reason for revert: Don't want this enabled by default right now Original issue's description: > Turn on preprocessing by default > > The idea is to commit this late at night and then revert it after all the perf bots are running. It should only effect the GPU configs. > > Committed: http://code.google.com/p/skia/source/detail?r=14860 R=bsalomon@google.com TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true Author: robertphillips@google.com Review URL: https://codereview.chromium.org/299123002 git-svn-id: http://skia.googlecode.com/svn/trunk@14861 2bbb7eff-a529-9590-31e7-b0007b416f81
* Turn on preprocessing by defaultGravatar commit-bot@chromium.org2014-05-22
| | | | | | | | | | | | The idea is to commit this late at night and then revert it after all the perf bots are running. It should only effect the GPU configs. R=bsalomon@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/299033002 git-svn-id: http://skia.googlecode.com/svn/trunk@14860 2bbb7eff-a529-9590-31e7-b0007b416f81
* Call write() within render_pictures but not bench_picturesGravatar commit-bot@chromium.org2014-05-22
| | | | | | | | | | | BUG=skia:2584 R=bsalomon@google.com, robertphillips@google.com, bensong@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/291843010 git-svn-id: http://skia.googlecode.com/svn/trunk@14837 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix ANGLE config (take 2)Gravatar commit-bot@chromium.org2014-05-21
| | | | | | | | | | | | | | Bot was failing with: "sequence item 7: expected string, int found" R=borenet@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/292313002 git-svn-id: http://skia.googlecode.com/svn/trunk@14834 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix problems with angle bot's configurationsGravatar commit-bot@chromium.org2014-05-21
| | | | | | | | | | | BUG=skia:2577 R=borenet@google.com Author: robertphillips@google.com Review URL: https://codereview.chromium.org/296693009 git-svn-id: http://skia.googlecode.com/svn/trunk@14831 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix windows compiler failures by using SkIsFinite.Gravatar djsollen@google.com2014-05-21
| | | | | | | | BUG=skia:2574 Review URL: https://codereview.chromium.org/296103003 git-svn-id: http://skia.googlecode.com/svn/trunk@14821 2bbb7eff-a529-9590-31e7-b0007b416f81
* speed up benches: postpone hash computation in PictureRenderer.cppGravatar commit-bot@chromium.org2014-05-21
| | | | | | | | | | | | fixes phantom performance regression after https://codereview.chromium.org/273783004 R=borenet@google.com, bensong@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/299763002 git-svn-id: http://skia.googlecode.com/svn/trunk@14819 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix skpdiff segfault caused by NaN computation.Gravatar commit-bot@chromium.org2014-05-21
| | | | | | | | | | | BUG=skia:2574 R=mtklein@google.com, rmistry@google.com Author: djsollen@google.com Review URL: https://codereview.chromium.org/296033004 git-svn-id: http://skia.googlecode.com/svn/trunk@14818 2bbb7eff-a529-9590-31e7-b0007b416f81
* Since we're only using it on Linux now, just require poppler as a system ↵Gravatar commit-bot@chromium.org2014-05-20
| | | | | | | | | | | | | | | | | dependency. The Ubuntu package needed is libpoppler-cpp-dev. iconv and fontconfig were only used as Poppler dependencies. bson_c is also unused. BUG=skia: R=reed@google.com, rmistry@google.com, borenet@google.com, halcanary@google.com, mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/294683003 git-svn-id: http://skia.googlecode.com/svn/trunk@14802 2bbb7eff-a529-9590-31e7-b0007b416f81
* Update valgrind suppression fileGravatar commit-bot@chromium.org2014-05-19
| | | | | | | | | | | BUG=skia: R=bsalomon@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/292453010 git-svn-id: http://skia.googlecode.com/svn/trunk@14791 2bbb7eff-a529-9590-31e7-b0007b416f81
* make render_pictures properly handle empty expectations fileGravatar commit-bot@chromium.org2014-05-19
| | | | | | | | | | | | | note that this changes the parameters taken by ImageResultsAndExpectations::Parse() BUG=skia:1942 R=scroggo@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/289063010 git-svn-id: http://skia.googlecode.com/svn/trunk@14779 2bbb7eff-a529-9590-31e7-b0007b416f81
* make buildbot_globals.py read global_variables.json file from googlesourceGravatar commit-bot@chromium.org2014-05-16
| | | | | | | | | | | | BUG=skia:2564 NOTRY=True R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/291563008 git-svn-id: http://skia.googlecode.com/svn/trunk@14770 2bbb7eff-a529-9590-31e7-b0007b416f81
* Add lua scripts to scrape dashing infoGravatar commit-bot@chromium.org2014-05-15
| | | | | | | | | | | BUG=skia: R=reed@google.com Author: egdaniel@google.com Review URL: https://codereview.chromium.org/288883003 git-svn-id: http://skia.googlecode.com/svn/trunk@14754 2bbb7eff-a529-9590-31e7-b0007b416f81
* Factor out DumpRecord method from dump_record tool for later useGravatar commit-bot@chromium.org2014-05-15
| | | | | | | | | | R=mtklein@google.com Author: halcanary@google.com Review URL: https://codereview.chromium.org/282233003 git-svn-id: http://skia.googlecode.com/svn/trunk@14751 2bbb7eff-a529-9590-31e7-b0007b416f81
* render_pictures: add --mismatchPath flagGravatar commit-bot@chromium.org2014-05-15
| | | | | | | | | | | | | When set, it will only write out images that don't match expectations. BUG=skia:1942 R=rmistry@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/283123002 git-svn-id: http://skia.googlecode.com/svn/trunk@14748 2bbb7eff-a529-9590-31e7-b0007b416f81
* delete no-longer-used update-doxygen.shGravatar commit-bot@chromium.org2014-05-15
| | | | | | | | | | | | BUG=skia:2470 NOTRY=True R=borenet@google.com Author: epoger@google.com Review URL: https://codereview.chromium.org/290033002 git-svn-id: http://skia.googlecode.com/svn/trunk@14747 2bbb7eff-a529-9590-31e7-b0007b416f81
* Fix goauth pathGravatar commit-bot@chromium.org2014-05-14
| | | | | | | | | | | BUG=skia:2551 R=scroggo@google.com Author: borenet@google.com Review URL: https://codereview.chromium.org/288763002 git-svn-id: http://skia.googlecode.com/svn/trunk@14737 2bbb7eff-a529-9590-31e7-b0007b416f81