aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools
diff options
context:
space:
mode:
authorGravatar mtklein <mtklein@chromium.org>2014-06-02 16:40:06 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2014-06-02 16:40:06 -0700
commita78ef795b032680c1d0141ae2b31dc05a74c1096 (patch)
treedf9bc6597939d204be0ffcfe587b4c2d59ed75be /tools
parent73be51ee5e9de55e31f7768f3e1d86fc21a24971 (diff)
Tweak TSAN suppressions.
BUG=skia: R=mtklein@google.com Author: mtklein@chromium.org Review URL: https://codereview.chromium.org/312613002
Diffstat (limited to 'tools')
-rw-r--r--tools/tsan.supp17
1 files changed, 14 insertions, 3 deletions
diff --git a/tools/tsan.supp b/tools/tsan.supp
index aab8211cec..c997058db2 100644
--- a/tools/tsan.supp
+++ b/tools/tsan.supp
@@ -6,15 +6,26 @@
race:third_party/externals/libwebp
# skia:2459 Seemingly misdiagnosed use-after-free, having something to do with software GL drivers.
-# We don't always get swrast_dri.so in the stack or we'd use that.
-race:SkGLContextHelper::init
+# Having trouble getting this suppression to match.
+# We've tried: race:swrast_dri.so
+# race:SkGLContextHelper::init
+# Maybe because it's diagnosed as a use-after-free, not as a race?
+race:SkGLContextHelper
# Threadsafe, should be ported to SkLazyPtr.
race:SkFontHost_FreeType
# Not threadsafe, should be fixed.
-race:SkFontHost_fontconfig_ref_global
+race:RefFCI
race:SkString::RefRec
# Not threadsafe, should be deleted.
race:SkPDF
+
+# Should be these can be removed once TSAN learns sk_acquire_load / sk_release_store.
+race:SkOnce
+race:SkRefCntBase
+
+# This is SkLazyPtr. Also can be cleaned up when TSAN learns sk_acquire_load / sk_release_store.
+race:sk_acquire_load
+race:__tsan_atomic64_compare_exchange_val