aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools
Commit message (Collapse)AuthorAge
* Add unit test to feed valid SVG sequences to make sure thatGravatar caryclark2016-02-09
| | | | | | | | | | | | | path strings can be parsed without returning an error. Draw the output through Skia and SVG to make sure they are parsed correctly. R=fmalita@chromium.org BUG=skia:4549 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1675053002 Review URL: https://codereview.chromium.org/1675053002
* Create a thermal manager class and wire it in to nanobench behind a flagGravatar joshualitt2016-02-09
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1671573002 Review URL: https://codereview.chromium.org/1671573002
* Optionally run RAW images seriallyGravatar scroggo2016-02-08
| | | | | | | | | | | | | | | | | RAW images use a lot of memory. Add a new FLAG to run one at a time so we have less risk of running out of memory. Isolate RAW images to their own thread on particular devices where our images cause OOM errors. Locally, this drops the max memory use from 3945 MB to 1664 MB (running only --image --images <RAW images we test>) BUG=skia:4912 BUG=skia:4878 BUG=b/27035849 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1681553003 Review URL: https://codereview.chromium.org/1681553003
* Skia serve now supports favicon correctlyGravatar joshualitt2016-02-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1676403002 Review URL: https://codereview.chromium.org/1676403002
* Blacklist RAW images on GPU testsGravatar msarett2016-02-08
| | | | | | | BUG=skia:4888 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1677133002 Review URL: https://codereview.chromium.org/1677133002
* Test CodecImageGenerator on GPU botsGravatar msarett2016-02-08
| | | | | | | | | | | | | | | | | | In crrev.com/1549473003, CodecImageGenerator implemented getYUV8Planes, so that we can test on a GPU bot. Update the arguments to DM so that we run CodecImageGenerator on GPU bots. This is adapted from: https://codereview.chromium.org/1663453002/ This will cause many untriaged images on Gold. The GPU converts YUV->RGBA differently than we do in software. BUG=skia:4888 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1676663002 Review URL: https://codereview.chromium.org/1676663002
* Create image cache for use by json canvasGravatar joshualitt2016-02-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1670153005 Review URL: https://codereview.chromium.org/1670153005
* msan: build expat from sourceGravatar mtklein2016-02-07
| | | | | | | | | | | This should let us test it on the MSAN bot. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1674053002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot Review URL: https://codereview.chromium.org/1674053002
* msan: initialize buffer BlurLargeImage blursGravatar mtklein2016-02-07
| | | | | | | | CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot BUG=skia: Review URL: https://codereview.chromium.org/1676103002
* msan: these might be okay with libjpeg guarded.Gravatar mtklein2016-02-07
| | | | | | | | | BUG=skia:4550 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1677913002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot Review URL: https://codereview.chromium.org/1677913002
* flags and hacks to get MSAN bot goingGravatar mtklein2016-02-06
| | | | | | | | | | | | | | | | | | | | | This disables a few tests in DM: - one BlurLargeImage GM maybe is really broken - FontMgrAndroidParser uses libexpat, which I've not (yet?) built from source, so MSAN can't see into it. This extends some of the MSAN stifling we added around SkImageDecoder_libjpeg to SkCodec, and skips .wbmps, .pngs, and .bmps. We're only seeing issues in colortables for .png and .bmp. I think I can probably back out disabling Codec and the RAW image decodes... they should all be covered by the libjpeg stifles. BUG=skia:4550,skia:4900 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1673663002 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot,Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN-Trybot TBR=msarett@google.com Review URL: https://codereview.chromium.org/1673663002
* Added JSON support for TextBlob et al.Gravatar ethannicholas2016-02-05
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1674643002 Review URL: https://codereview.chromium.org/1674643002
* dont upload to Gold from MSAN botGravatar mtklein2016-02-05
| | | | | | | | | NOTRY=true NOTREECHECKS=true BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1673643002 Review URL: https://codereview.chromium.org/1673643002
* Fixed references to MakeMatrix functionGravatar ethannicholas2016-02-04
| | | | | | | TBR=joshualitt@chromium.org GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1666213002 Review URL: https://codereview.chromium.org/1666213002
* JSON API cleanupsGravatar ethannicholas2016-02-04
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1664263002 Review URL: https://codereview.chromium.org/1664263002
* Improved support for images/bitmaps in SkJSONCanvasGravatar ethannicholas2016-02-04
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1662063003 Review URL: https://codereview.chromium.org/1662063003
* Modify skia serve to return clip rect and view matrixGravatar joshualitt2016-02-04
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1662003002 Review URL: https://codereview.chromium.org/1662003002
* Treat bad values passed to --images as a fatal errorGravatar scroggo2016-02-03
| | | | | | | | | | | | | | | If an option is passed to --images that is either a non-existent path or a folder with no images matching the supported types, assume this is an error and exit, so they can supply a valid path instead. Share code between DM and nanobench in SkCommonFlags. nanobench now behaves more like DM - it will check a directory for images that match the supported extensions. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1611323004 Review URL: https://codereview.chromium.org/1611323004
* Hack together MSAN build.Gravatar mtklein2016-02-03
| | | | | | | | | | | | | | | | | | | | | | - Build our own: freetype. - Avoid using: fontconfig, expat, GPU drivers. - Lie about safety: libjpeg (only from src/images... need to in src/codec?) To run: $ tools/xsan_build memory dm $ out/Debug/dm -v --match ~Codec ~BlurLargeImage ~FontMgrAndroidParser Notes: - Codec triggers issues in piex. - BlurLargeImage probably has bugs in the GM only. - FontMgrAndroidParser uses expat. BUG=skia:4550 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1665823002 NOTREECHECKS=true Review URL: https://codereview.chromium.org/1665823002
* Revert of Test CodecImageGenerator on GPU bots (patchset #1 id:1 of ↵Gravatar jcgregorio2016-02-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1663453002/ ) Reason for revert: Failures: D/skia ( 3581): gpu image gen frame_larger_than_image.gif: Could not create a surface. D/skia ( 3581): gpu image gen offsets_too_large.gif: Could not create a surface. D/skia ( 3581): gpu image gen PANO_20121023_214540.jpg: Could not create a surface. D/skia ( 3581): gpu image gen interlaced1.png: Could not create a surface. D/skia ( 3581): gpu image gen interlaced2.png: Could not create a surface. D/skia ( 3581): gpu image gen interlaced3.png: Could not create a surface. D/skia ( 3581): gpu image gen Canon_5D2.dng: Could not create a surface. D/skia ( 3581): gpu image gen Fuji_X20.dng: Could not create a surface. D/skia ( 3581): gpu image gen HTC.dng: Could not create a surface. D/skia ( 3581): gpu image gen lg_g4_iso_800.dng: Could not create a surface. D/skia ( 3581): gpu image gen Canon_G7X.CR2: Could not create a surface. D/skia ( 3581): gpu image gen Pentax_K5.DNG: Could not create a surface. D/skia ( 3581): gpu image gen Nikon_1AW1.NEF: Could not create a surface. D/skia ( 3581): gpu image gen Nikon_1J4.NEF: Could not create a surface. D/skia ( 3581): gpu image gen Nikon_P330.NRW: Could not create a surface. D/skia ( 3581): gpu image gen Olympus_E-PL3.ORF: Could not create a surface. D/skia ( 3581): gpu image gen Olympus_PL7.ORF: Could not create a surface. D/skia ( 3581): gpu image gen Pentax_K5.PEF: Could not create a surface. D/skia ( 3581): gpu image gen Samsung_NX3000.SRW: Could not create a surface. Original issue's description: > Test CodecImageGenerator on GPU bots > > In crrev.com/1549473003, CodecImageGenerator implemented getYUV8Planes, > so that we can test on a GPU bot. Update the arguments to DM so that > we run CodecImageGenerator on GPU bots. > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1663453002 > > Committed: https://skia.googlesource.com/skia/+/c9715406c4c9c995e5661a4ea2188fb8643845c0 TBR=msarett@google.com,scroggo@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1663143002
* Do not upload to trusted partner's bucket if it is a dry runGravatar rmistry2016-02-03
| | | | | | | | | | BUG=skia:3751 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1665803002 # Trybots do not exercise this code. NOTRY=true Review URL: https://codereview.chromium.org/1665803002
* Test CodecImageGenerator on GPU botsGravatar scroggo2016-02-03
| | | | | | | | | In crrev.com/1549473003, CodecImageGenerator implemented getYUV8Planes, so that we can test on a GPU bot. Update the arguments to DM so that we run CodecImageGenerator on GPU bots. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1663453002 Review URL: https://codereview.chromium.org/1663453002
* Fix delete_path in webpages_playback.pyGravatar rmistry2016-02-03
| | | | | | | | | | BUG=skia:3751 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1662673003 # Trybots do not exercise this code. NOTRY=true Review URL: https://codereview.chromium.org/1662673003
* Delete skp dir in partner bucket before uploadingGravatar rmistry2016-02-03
| | | | | | | | | | | BUG=skia:3751 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1660363002 # Trybots do not exercise this code. NOTRY=true TBR=borenet Review URL: https://codereview.chromium.org/1660363002
* Recreate SKPs in a single directory for trusted partners.Gravatar rmistry2016-02-02
| | | | | | | | | | | | | Context: https://bugs.chromium.org/p/skia/issues/detail?id=3751#c15 BUG=skia:3751 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1662693002 # Trybots do not run this code NOTRY=true TBR=borenet Review URL: https://codereview.chromium.org/1662693002
* Modify skiaserve to support downloadsGravatar joshualitt2016-02-02
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1657403002 Review URL: https://codereview.chromium.org/1657403002
* Update SK_IMAGE_VERSION to test RAWGravatar scroggo2016-02-02
| | | | | | | | | | | | | | | | | | | | | Bump SK_IMAGE_VERSION to test the images in v2 in GoogleStorage, which includes the images from v1 plus test images for SkRawCodec. Only define skia_decodes_raw on platforms that support it, rather than defining it always and checking additional conditions to determine whether to support raw. Further, define it and SK_CODEC_DECODES_RAW for all targets, so we can use the compile flag in other targets. In DM, exclude the raw extensions if SK_CODEC_DECODES_RAW is not defined. Blacklist raw extensions on NexusPlayer, which was running out of memory when running them. BUG=skia:4829 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1612113002 Review URL: https://codereview.chromium.org/1612113002
* Modify skiaserve to support drawToGravatar joshualitt2016-02-02
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1651403003 Review URL: https://codereview.chromium.org/1651403003
* support for more features when rendering to/from JSONGravatar ethannicholas2016-02-02
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1662503003 Review URL: https://codereview.chromium.org/1662503003
* fix skiaserve crashGravatar joshualitt2016-02-02
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1659703004 Review URL: https://codereview.chromium.org/1659703004
* cleanup of skia serve url handlingGravatar joshualitt2016-02-02
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1653203002 Review URL: https://codereview.chromium.org/1653203002
* Upload SKPs to chrome-partner-telemetryGravatar rmistry2016-02-01
| | | | | | | | | | | | | | | Context: https://bugs.chromium.org/p/skia/issues/detail?id=3751#c4 and https://bugs.chromium.org/p/skia/issues/detail?id=3751#c6 BUG=skia:3751 # Trybots do not run this code. NOTRY=true GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1658653002 Review URL: https://codereview.chromium.org/1658653002
* Revert of Treat bad values passed to --images as a fatal error (patchset #17 ↵Gravatar scroggo2016-01-29
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:320001 of https://codereview.chromium.org/1611323004/ ) Reason for revert: Speculative to fix windows bots Original issue's description: > Treat bad values passed to --images as a fatal error > > If an option is passed to --images that is either a non-existent path or > a folder with no images matching the supported types, assume this is > an error and exit, so they can supply a valid path instead. > > Share code between DM and nanobench in SkCommonFlags. > > nanobench now behaves more like DM - it will check a directory for > images that match the supported extensions. > > Only consider image paths ending in RAW suffixes as images if > SK_CODE_DECODES_RAW is defined. This prevents us from seeing failure > to decode errors on platforms that cannot decode it. > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1611323004 > > Committed: https://skia.googlesource.com/skia/+/7579786f3bd5a8fda84a1abc45b16213c3371f93 TBR=mtklein@google.com,borenet@google.com,msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true # Not skipping CQ checks because original CL landed more than 1 days ago. Review URL: https://codereview.chromium.org/1653543002
* Consolidate SK_CRASH and sk_throw into SK_ABORTGravatar djsollen2016-01-29
| | | | | | | TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1648343003 Review URL: https://codereview.chromium.org/1648343003
* fix for skiaserve build errorGravatar ethannicholas2016-01-29
| | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1651443002 TBR=jcgregorio@google.com Review URL: https://codereview.chromium.org/1651443002
* added support for more features in JSON (blurs, dashing, different path fill ↵Gravatar ethannicholas2016-01-29
| | | | | | | | types, etc.) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1644903003 Review URL: https://codereview.chromium.org/1644903003
* tools/git-sync-deps: fix error in git syntax for changing originGravatar halcanary2016-01-28
| | | | | | | | Error introduced in https://crrev.com/1475513004 NOTRY=true Review URL: https://codereview.chromium.org/1646863002
* Treat bad values passed to --images as a fatal errorGravatar scroggo2016-01-28
| | | | | | | | | | | | | | | | | | | If an option is passed to --images that is either a non-existent path or a folder with no images matching the supported types, assume this is an error and exit, so they can supply a valid path instead. Share code between DM and nanobench in SkCommonFlags. nanobench now behaves more like DM - it will check a directory for images that match the supported extensions. Only consider image paths ending in RAW suffixes as images if SK_CODE_DECODES_RAW is defined. This prevents us from seeing failure to decode errors on platforms that cannot decode it. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1611323004 Review URL: https://codereview.chromium.org/1611323004
* Add a background timing thread to kilobenchGravatar joshualitt2016-01-28
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1612513002 Review URL: https://codereview.chromium.org/1612513002
* skiaserve: Clean up flags.Gravatar jcgregorio2016-01-28
| | | | | | | | | | Remove unused flags. Add --port and --source. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1643963002 Review URL: https://codereview.chromium.org/1643963002
* skiaserve: Add CORS header, and debugger code is served over HTTPS.Gravatar jcgregorio2016-01-28
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1646683002 Review URL: https://codereview.chromium.org/1646683002
* skiaserve: Enable /cmd endpoint.Gravatar jcgregorio2016-01-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1639403002 Review URL: https://codereview.chromium.org/1639403002
* Suppress jpeg valgrind errorsGravatar msarett2016-01-27
| | | | | | | | | | Do a better job suppressing these errors until I can prioritize fixing them. BUG=skia:4550 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1641763002 Review URL: https://codereview.chromium.org/1641763002
* skiaserve: Set 303 status code on redirect.Gravatar jcgregorio2016-01-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1641823002 Review URL: https://codereview.chromium.org/1641823002
* Wire up JsonCanvas in skiaserveGravatar joshualitt2016-01-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1640333002 Review URL: https://codereview.chromium.org/1640333002
* switched to SkJSONCPP for JSON outputGravatar ethannicholas2016-01-27
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1639333002 Review URL: https://codereview.chromium.org/1639333002
* Stop testing SkImageDecoder in DM/nanobenchGravatar scroggo2016-01-27
| | | | | | | | | We have already used it for comparison, and are switching forward to using SkCodec. This also allows us to simplify the code for checking the extensions we support for images. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1641663002 Review URL: https://codereview.chromium.org/1641663002
* Add primitive url handling system to skiaserveGravatar joshualitt2016-01-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1644633002 Review URL: https://codereview.chromium.org/1644633002
* Allow clients to upload skps to skiaserveGravatar joshualitt2016-01-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1638883002 Review URL: https://codereview.chromium.org/1638883002
* Initial support for turning Skia draws into a JSON document and vice versa.Gravatar ethannicholas2016-01-26
| | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1636563002 Committed: https://skia.googlesource.com/skia/+/3cb582f688822461efa5a034e18008bf2f11e4f8 Review URL: https://codereview.chromium.org/1636563002