aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools
diff options
context:
space:
mode:
authorGravatar msarett <msarett@google.com>2016-02-08 09:10:47 -0800
committerGravatar Commit bot <commit-bot@chromium.org>2016-02-08 09:10:47 -0800
commit13a036b7ebfd1faeef168979cd6dbb09d0868619 (patch)
tree969499662f9261f1fbb9cf5428a0f5fcb2c1dffd /tools
parent3c69348e725131150e4ab962dec1b3ff1148a6bd (diff)
Test CodecImageGenerator on GPU bots
In crrev.com/1549473003, CodecImageGenerator implemented getYUV8Planes, so that we can test on a GPU bot. Update the arguments to DM so that we run CodecImageGenerator on GPU bots. This is adapted from: https://codereview.chromium.org/1663453002/ This will cause many untriaged images on Gold. The GPU converts YUV->RGBA differently than we do in software. BUG=skia:4888 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1676663002 Review URL: https://codereview.chromium.org/1676663002
Diffstat (limited to 'tools')
-rw-r--r--tools/dm_flags.json7
-rwxr-xr-xtools/dm_flags.py8
2 files changed, 9 insertions, 6 deletions
diff --git a/tools/dm_flags.json b/tools/dm_flags.json
index 251a952c35..fa2acfeafa 100644
--- a/tools/dm_flags.json
+++ b/tools/dm_flags.json
@@ -232,6 +232,7 @@
"--src",
"tests",
"gm",
+ "image",
"--blacklist",
"serialize-8888",
"gm",
@@ -434,6 +435,7 @@
"--src",
"tests",
"gm",
+ "image",
"--threads",
"0",
"--blacklist",
@@ -636,6 +638,7 @@
"--src",
"tests",
"gm",
+ "image",
"--threads",
"0",
"--blacklist",
@@ -842,6 +845,7 @@
"--src",
"tests",
"gm",
+ "image",
"--blacklist",
"serialize-8888",
"gm",
@@ -1042,6 +1046,7 @@
"--src",
"tests",
"gm",
+ "image",
"--blacklist",
"serialize-8888",
"gm",
@@ -2474,6 +2479,7 @@
"--src",
"tests",
"gm",
+ "image",
"--blacklist",
"pdf",
"gm",
@@ -2717,6 +2723,7 @@
"--src",
"tests",
"gm",
+ "image",
"--blacklist",
"msaa16",
"gm",
diff --git a/tools/dm_flags.py b/tools/dm_flags.py
index 5fd8a2b878..663507ebb9 100755
--- a/tools/dm_flags.py
+++ b/tools/dm_flags.py
@@ -80,13 +80,9 @@ def get_args(bot):
args.append('--config')
args.extend(configs)
- # Run tests and gms everywhere,
- # and image decoding tests everywhere except GPU bots.
+ # Run tests, gms, and image decoding tests everywhere.
# TODO: remove skp from default --src list?
- if 'GPU' in bot:
- args.extend('--src tests gm'.split(' '))
- else:
- args.extend('--src tests gm image'.split(' '))
+ args.extend('--src tests gm image'.split(' '))
if 'GalaxyS' in bot:
args.extend(('--threads', '0'))