aboutsummaryrefslogtreecommitdiffhomepage
path: root/tools/viewer
Commit message (Collapse)AuthorAge
* Add toggle for 'real' vs. 'fake' perspective in ViewerGravatar Brian Osman2018-05-02
| | | | | | | | | | | | | | | Real perspective draws content with perspective applied. Fake perspective rasterizes in ortho, then stretches the image by the perspective matrix. Change-Id: I738cd379f9a58b965469ef8a57fb2dfd597fda10 Reviewed-on: https://skia-review.googlesource.com/125442 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Ben Wagner <bungeman@google.com>
* Take sk_sp<SkDevice> instead of SkDevice*Gravatar Herb Derby2018-05-02
| | | | | | | | | Change-Id: I0b296bf5b80adc19758a3dc99160be9d2ed05680 Reviewed-on: https://skia-review.googlesource.com/125160 Commit-Queue: Herb Derby <herb@google.com> Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Reed <reed@google.com> Auto-Submit: Herb Derby <herb@google.com>
* [skottie] Show load stats in SkottieSlideGravatar Florin Malita2018-04-30
| | | | | | | | TBR= Change-Id: Ie3a1036d9a90cb16d2795134c453759aeff06e3c Reviewed-on: https://skia-review.googlesource.com/124461 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Rotate about the slide center, and before perspectiveGravatar Brian Osman2018-04-26
| | | | | | | | | | This causes rotation to happen in the perspective plane, which is more (?) interesting/useful. Change-Id: If57a81de6662591be67cb68f0278f71038ac8d40 Reviewed-on: https://skia-review.googlesource.com/124160 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Add perspective support (rect to rect) to ViewerGravatar Brian Osman2018-04-26
| | | | | | | | | | | Change-Id: I312d5b3e6b7f37a3a7bfd5561bcdb31b43e207b8 Reviewed-on: https://skia-review.googlesource.com/123934 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com> Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com> Reviewed-by: Ben Wagner <bungeman@google.com> Auto-Submit: Brian Osman <brianosman@google.com>
* Remove the MSAA path rendererGravatar Chris Dalton2018-04-25
| | | | | | | | Bug: skia: Change-Id: Ib18bede613c8d27fd6326f655dc2d638e35870ff Reviewed-on: https://skia-review.googlesource.com/123726 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Chris Dalton <csmartdalton@google.com>
* Add Transform section to viewer tools window.Gravatar Ben Wagner2018-04-23
| | | | | | | | | This adds sliders for Zoom and Rotate. Change-Id: Ie568e5381d76bd5a457760e2d6224e42e64c7f16 Reviewed-on: https://skia-review.googlesource.com/123027 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Backspace opens slide picker (not paint) in viewer.Gravatar Ben Wagner2018-04-23
| | | | | | | | | | | | | A recent change added the "Paint" section to the viewer tools window. The code around forcing the slide picker open when the backspace key was pressed was inadvertantly separated from the slide picker section, so now the paint section is confusingly held open instead. This changes the logic so that the slide picker is once again the target of backspace. Change-Id: Ibfcb78bb0a1e2bdbb2ccce54b38e8206e0303753 Reviewed-on: https://skia-review.googlesource.com/122949 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Add paint flags to viewer GUI.Gravatar Ben Wagner2018-04-17
| | | | | | | | | | Overriding bits of the paint was added with keyboard bindings but without being reflected in the GUI. This adds these flags to the GUI. Change-Id: I633801fb776248952afe7cbe8857676ef8b57135 Reviewed-on: https://skia-review.googlesource.com/121796 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Add pixel geometry and dft selection to viewer app.Gravatar Ben Wagner2018-04-16
| | | | | | | Change-Id: I2fea84793383c44b102fa97b23f59235ef302ff9 Reviewed-on: https://skia-review.googlesource.com/121581 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Herb Derby <herb@google.com>
* Clip SlideDir slides to their declared dimensionsGravatar Florin Malita2018-04-05
| | | | | | | | | | (to avoid spilling cell content) TBR= Change-Id: I7bbbbf004d35faab5f264d9914bcd24d2bb8eaeb Reviewed-on: https://skia-review.googlesource.com/118984 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* [viewer] Consolidate external slide loadingGravatar Florin Malita2018-04-05
| | | | | | | | | | | | Handle all external slides (.skp, .jpg, .json, .svg) consistently: * support both single-file/directory flags * add "directory" slides for all types Change-Id: I4881c51f597ed4cb2a5b4c61706a168c754a5a8f Reviewed-on: https://skia-review.googlesource.com/119020 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Viewer SVG supportGravatar Florin Malita2018-04-05
| | | | | | | Change-Id: I93ee61271ebe960063bec16ba472b3fd243ee149 Reviewed-on: https://skia-review.googlesource.com/118885 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Update trans limit after zoom changes in viewerGravatar Yuqian Li2018-03-28
| | | | | | | | | | | | Previously, the trans limit assumes that only touch gesture can change the zoom level. That's not true on desktops so we need this fix. Otherwise, we won't be able to translate when we zoomed in. Bug: skia: Change-Id: I5901600a0044639a47514ab76b7e1914f04137a2 Reviewed-on: https://skia-review.googlesource.com/116987 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* Check that paint is not null in OveridePaintFilterCanvas.Gravatar Ben Wagner2018-03-28
| | | | | | | | | | | SkCanvas::drawPicture may provide nullptr for a paint. BUG=skia:7756 Change-Id: I46651f7e8f0d859a7e75206d93ed1f3b3c0a4bac Reviewed-on: https://skia-review.googlesource.com/116902 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* BUILD: build when !skia_use_expatGravatar Hal Canary2018-03-22
| | | | | | | Change-Id: I17a695c64be0e2081ad4937b23038b7ce88ae293 Reviewed-on: https://skia-review.googlesource.com/115988 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Hal Canary <halcanary@google.com>
* [skottie] Nested animation supportGravatar Florin Malita2018-02-23
| | | | | | | | | | | | | | | | Extend composition layers to support referencing external .json animations ("$"<PATH> syntax). This is a custom extension (not supported in BM/Lottie). Also make skottie::Animation ref-counted, to facilitate sharing. TBR= Change-Id: I062d031e5868d759f3930dea9b261f9b3ec81684 Reviewed-on: https://skia-review.googlesource.com/109806 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Don't consume mouse events in SkottieSlideGravatar Florin Malita2018-02-21
| | | | | | | | | | | | We want to togle inval display on click, but if we always consume the event we disable pan/zoom in viewer. TBR= Change-Id: I1f785883252c4f4a09fd35d4a05485849bf7e8ef Reviewed-on: https://skia-review.googlesource.com/109084 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Add nativeFonts flag to Viewer.Gravatar Ben Wagner2018-02-21
| | | | | | | | | | | This moves DMFontMgr and several related files which are tightly related to fonts into tools/fonts, moves some flags around to prevent duplication, and adds the nativeFonts handling to Viewer. Change-Id: Id1bdad708a6b74319ac5ac9adfe21025db4ca0b2 Reviewed-on: https://skia-review.googlesource.com/108904 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* [skottie] Show inval rects on mouse click in SkottieSlideGravatar Florin Malita2018-02-20
| | | | | | | | | | | Also fix a SlideDir sizing bug. TBR= Change-Id: Iee61bb6665dc56ddd6fc062a686a9c0ef87dea92 Reviewed-on: https://skia-review.googlesource.com/108902 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Resurrect pathfinder in viewer and rename to "bisect"Gravatar Chris Dalton2018-02-20
| | | | | | | | Bug: skia: Change-Id: If8d2f46b8f27fefc3a0f983eb649654e0fb4afcb Reviewed-on: https://skia-review.googlesource.com/108685 Commit-Queue: Chris Dalton <csmartdalton@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* Add SkRect::contains(SkScalar x, SkScalar y)Gravatar Florin Malita2018-02-20
| | | | | | | | | | Similar to its SkIRect counterpart. Change-Id: I6872694d8602ed4181a1a15b4cd1c2c32aeab3f9 Reviewed-on: https://skia-review.googlesource.com/108506 Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* [sksg] Add 'plane' geometry nodeGravatar Florin Malita2018-02-20
| | | | | | | | | | | SG geometry corresponding to SkCanvas::drawPaint(). TBR= Change-Id: I3b368adda187fb92f524756496a3694c03a3113d Reviewed-on: https://skia-review.googlesource.com/108562 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* SlideDir focus tweaksGravatar Florin Malita2018-02-20
| | | | | | | | | | | | | | * cubic-map animation * shade the background scene when focused * unfocus on click outside focus rect TBR= Bug: skia: Change-Id: I0ef8751b111b3b55c3fc36126c2ca1bc8ff6d33a Reviewed-on: https://skia-review.googlesource.com/108501 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Delete SkottieSlide2Gravatar Florin Malita2018-02-20
| | | | | | | | | | | Now superseded by the generic SlideDir. TBR= Change-Id: Ia9adfc54dcb86ebb0cd50d2e1f4739896279de8f Reviewed-on: https://skia-review.googlesource.com/108503 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Pass Viewer touch events to slidesGravatar Florin Malita2018-02-20
| | | | | | | Change-Id: Ia7b097c22e497e4e84be45108ac9796d89305ef3 Reviewed-on: https://skia-review.googlesource.com/108363 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* SlideDir focus w/ animationGravatar Florin Malita2018-02-19
| | | | | | | | | | | | | | Add an animated "focus" mode for SlideDir. Clicking a cell focuses. SPACE unfocuses. When a slide is focused, mouse and key events are passed through. TBR= Change-Id: Iec47e2327e3b21bd626846bb0d3f9107bf680b1b Reviewed-on: https://skia-review.googlesource.com/108101 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Mike Reed <reed@google.com>
* Generic "directory" viewer slideGravatar Florin Malita2018-02-16
| | | | | | | | | | | | | | | This is a generalization of "skottie-dir", based on SkSG and operating at the Slide API level. For now it is only instantiated for Json slides, but could be used for other slide "directories" in the future. TBR= NOTRY=true Change-Id: If12429084bddeb172b234344f23eabcdadedcceb Reviewed-on: https://skia-review.googlesource.com/108002 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Add text rendering related overrides to Viewer.Gravatar Ben Wagner2018-02-12
| | | | | | | | | | | | | | This combines the AAA and DAA settings into one Antialias setting which also exposes alias and normal settings. It also fixes restoring the AAA and DAA global state when not overriding. This adds hinting, subpixel positioning, and subpixel rendering tri-state toggles as well. Change-Id: I845fa5be1fed4142e82796e6ef417b276fa76111 Reviewed-on: https://skia-review.googlesource.com/106761 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* [skottie] Fix viewer slide sizing on AndroidGravatar Florin Malita2018-02-09
| | | | | | | | | TBR= Change-Id: Ibbf4d22ba01e39b80c1f76d9af6bef647454996f Reviewed-on: https://skia-review.googlesource.com/106160 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Map Viewer mouse events to Slide space.Gravatar Florin Malita2018-02-05
| | | | | | | | | There isn't much Slide can do with Window-space mouse events. Change-Id: I36509d4aa1b2ed510b8d8739d39cf5204ad486cc Reviewed-on: https://skia-review.googlesource.com/102149 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Revert "Revert "Revert "Revert "Revert "Revert "Redefine the meaning of ↵Gravatar Brian Salomon2018-02-03
| | | | | | | | | | | | | sample counts in GPU backend."""""" This reverts commit 3a2cc2c2ec124de36d2544b2a523ef1dd317ca32. Fix code with samplecnt=0 that slipped in between trybots/CQ and landing of previous version Change-Id: Iab19f2e8d1e9901601c8c76244d7a88c5d707fab Reviewed-on: https://skia-review.googlesource.com/103181 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Revert "Revert "Revert "Revert "Revert "Redefine the meaning of sample ↵Gravatar Brian Salomon2018-02-03
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | counts in GPU backend.""""" This reverts commit 5bb82cbecd740d21b92e8d2944280ab6eb6af7a6. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "Revert "Revert "Revert "Redefine the meaning of sample counts in GPU backend."""" > > This reverts commit 18c52a7b52211de5d0dcd86dc048adef758c6c75. > > Also relands "More sample count cleanup:" and "Add new GrContext queries for imagability, surfacability, and max sample count of color types" > > > Bug: skia: > Change-Id: I4028105a3a1f16ce3944e134619eb6245af6b947 > Reviewed-on: https://skia-review.googlesource.com/102940 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=egdaniel@google.com,bsalomon@google.com Change-Id: Idee23be2f1719f0bdc9305043e95a2d589bee8d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/103220 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Revert "Revert "Revert "Revert "Redefine the meaning of sample counts in GPU ↵Gravatar Brian Salomon2018-02-02
| | | | | | | | | | | | | | | backend."""" This reverts commit 18c52a7b52211de5d0dcd86dc048adef758c6c75. Also relands "More sample count cleanup:" and "Add new GrContext queries for imagability, surfacability, and max sample count of color types" Bug: skia: Change-Id: I4028105a3a1f16ce3944e134619eb6245af6b947 Reviewed-on: https://skia-review.googlesource.com/102940 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Revert "Revert "Revert "Redefine the meaning of sample counts in GPU backend."""Gravatar Brian Salomon2018-02-02
| | | | | | | | | | | | | | | | | | | | This reverts commit d0d7270fcc32546005b8e847df516cb11592cd30. Revert "More sample count cleanup:" This reverts commit d653cac70ed17983125ceed053138c09f1401846. Revert "Add new GrContext queries for imagability, surfacability, and max sample count of color types" This reverts commit 85ae7159c9c8a9186a4c7e74304eabb35bca9a79. Need to understand NVPR perf changes before relanding Change-Id: I0db075fb42438ef2a1f9885df184dce52892ac4b Reviewed-on: https://skia-review.googlesource.com/102780 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Revert "Revert "Redefine the meaning of sample counts in GPU backend.""Gravatar Brian Salomon2018-02-01
| | | | | | | | | | | | Fixes gpu config default samples to be 1 and updates config parsing test accordingly. This reverts commit c1ce2f7966babaae0deb150f93f1227ee5af9285. Bug: skia: Change-Id: I456973b1f52ced85a2011ea10fc49449bfc5846f Reviewed-on: https://skia-review.googlesource.com/102147 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Revert "Redefine the meaning of sample counts in GPU backend."Gravatar Brian Salomon2018-02-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 48825b11ad25c98b9a4884d5cc0edd4e290c4409. Reason for revert: nanobench Original change's description: > Redefine the meaning of sample counts in GPU backend. > > Old: 0 -> nonMSAA > 1+ -> MSAA > > New: > 0 -> error/unsupported > 1 -> nonMSAA > 2+ -> MSAA > > We still allow 0 to mean nonMSAA in three sets of public APIs for backwards compatibility: > > 1) SkSurface factories > 2) GrBackendRenderTarget constructors > 3) GrCaps::getSampleCnt()'s requestedCount parameter > > However, we immediately clamp to 1 and treat 0 as invalid/non-renderable internally. > > This also changes the behavior when using a large sample count. We now fail in that case rather than using the largest sample available sample count. GrCaps::getSampleCount() will return 0 in this case. > > > Bug: skia: > Change-Id: Ida22c6b22c1365e563c9046b611e88bf5eb3ff33 > Reviewed-on: https://skia-review.googlesource.com/101560 > Reviewed-by: Greg Daniel <egdaniel@google.com> > Commit-Queue: Brian Salomon <bsalomon@google.com> TBR=egdaniel@google.com,bsalomon@google.com Change-Id: Ic257619a8a5ee9ac15419ecf10259e42daed7f82 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/102662 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* Redefine the meaning of sample counts in GPU backend.Gravatar Brian Salomon2018-02-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | Old: 0 -> nonMSAA 1+ -> MSAA New: 0 -> error/unsupported 1 -> nonMSAA 2+ -> MSAA We still allow 0 to mean nonMSAA in three sets of public APIs for backwards compatibility: 1) SkSurface factories 2) GrBackendRenderTarget constructors 3) GrCaps::getSampleCnt()'s requestedCount parameter However, we immediately clamp to 1 and treat 0 as invalid/non-renderable internally. This also changes the behavior when using a large sample count. We now fail in that case rather than using the largest sample available sample count. GrCaps::getSampleCount() will return 0 in this case. Bug: skia: Change-Id: Ida22c6b22c1365e563c9046b611e88bf5eb3ff33 Reviewed-on: https://skia-review.googlesource.com/101560 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com>
* [skottie] Convert SkottieSlide2 to SkSceneGraph animators.Gravatar Florin Malita2018-02-01
| | | | | | | | | | | | Instead of dispatching ticks explicitly, bind Animations to the Scene using ForwardingAnimator adaptors. TBR= Change-Id: I9faffed5c96157c781cc96729395b52d3f841e2b Reviewed-on: https://skia-review.googlesource.com/102500 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* [sksg] Initial text supportGravatar Florin Malita2018-01-31
| | | | | | | | | | | Use the new node type for SkottieSlide2 labels. TBR= Change-Id: Icd6a4faf1c281bd83a2331c0072d1a6ed71acc09 Reviewed-on: https://skia-review.googlesource.com/102441 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* [skottie] Convert (most of) SkottieSlide2 to SkSceneGraphGravatar Florin Malita2018-01-31
| | | | | | | | | | | Each Skottie animation is now a transformed sksg node. TBR= Change-Id: Ib5c153e8279e1a74a242b0eb193c4463898b09ea Reviewed-on: https://skia-review.googlesource.com/102201 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Fix startup for SampleSlideGravatar Jim Van Verth2018-01-22
| | | | | | | | | | | | When we start up Viewer with a SampleSlide as the first slide, nothing gets rendered because SampleSlide depends on the backend being initialized before setting its dimensions. This pushes the first slide's initialization after the backend creation. Change-Id: I8f83fe7b3973c40234104f1a83c0a60750694311 Reviewed-on: https://skia-review.googlesource.com/98161 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* Add Chinese zoom Sample.Gravatar Jim Van Verth2018-01-22
| | | | | | | | | | Bug: skia: Change-Id: Ibe5ffee64fe9fccd6b8d86c1310a78d2d51e424e Reviewed-on: https://skia-review.googlesource.com/97065 Commit-Queue: Jim Van Verth <jvanverth@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Fix Viewer slide load on backend change - take 2Gravatar Florin Malita2018-01-17
| | | | | | | | | | | Split the slide switching logic (including load/unload) into setCurrentSlide(), while keeping setupCurrentSlide() to deal with config only. Change-Id: I5bd2363ffd401c1b756217f845d4dbd16d6be5d6 Reviewed-on: https://skia-review.googlesource.com/94864 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Skotty -> SkottieGravatar Florin Malita2018-01-17
| | | | | | | Change-Id: If8b6516024c69b0fc256208874f6666a4e70e12c Reviewed-on: https://skia-review.googlesource.com/95241 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* Revert "Fix Viewer slide load on backend change"Gravatar Florin Malita2018-01-16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 5fb009df3c87167762b33483ee82b5fe632837a9. Reason for revert: Broke first slide. Original change's description: > Fix Viewer slide load on backend change > > Currently Viewer fires unbalanced load events on backend change. > > Instead of calling setupCurrentSlide() with an invalid prevSlide and > always forcing a slide load, pass a |force| argument on backend change. > > Change-Id: I146b42331f5aa9721d4f407b81c13f4512d67d61 > Reviewed-on: https://skia-review.googlesource.com/94960 > Reviewed-by: Brian Osman <brianosman@google.com> > Commit-Queue: Florin Malita <fmalita@chromium.org> TBR=brianosman@google.com,fmalita@chromium.org Change-Id: I52bbc9fb44f6ed4e04bcc549b2ec72c8600c823a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/94861 Reviewed-by: Florin Malita <fmalita@google.com> Commit-Queue: Florin Malita <fmalita@google.com>
* Fix Viewer slide load on backend changeGravatar Florin Malita2018-01-16
| | | | | | | | | | | | Currently Viewer fires unbalanced load events on backend change. Instead of calling setupCurrentSlide() with an invalid prevSlide and always forcing a slide load, pass a |force| argument on backend change. Change-Id: I146b42331f5aa9721d4f407b81c13f4512d67d61 Reviewed-on: https://skia-review.googlesource.com/94960 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org>
* [skotty] Minor tools tweaksGravatar Florin Malita2018-01-09
| | | | | | | | | | | * fix "show inval" persistency in SkottySlide * add frame-stamp to DM film strip TBR= Change-Id: I965b28fa25b4d6ddfa1ddf80f5f9187dff3f943c Reviewed-on: https://skia-review.googlesource.com/92941 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* [skotty,sksg] Initial image supportGravatar Florin Malita2018-01-08
| | | | | | | | TBR= Change-Id: Ib3c918b1d746e4f190ae05708681f2d5519afdb2 Reviewed-on: https://skia-review.googlesource.com/91980 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org>
* add skotty-dir slideGravatar Mike Reed2018-01-08
| | | | | | | | | | Shows a directory of skotties in a grid Bug: skia: Change-Id: I96b0700d8809c94a394cf517222123967afb20dc Reviewed-on: https://skia-review.googlesource.com/91407 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>