| Commit message (Collapse) | Author | Age |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is mostly dead code.
In order to make it truly dead, we need to opt drawing unpremul images
into SkRasterPipelineBlitter. They had been handled by
SkLinearBitmapPipeline, but can't be draw by SkBitmapProcLegacyShader.
Drawing unpremul images is tested by the GM all_variants_8888, which
gave us trouble last time around (serialize-8888 drew right, 8888 wrong)
but now draws fine. I think this was probably also the root of the
revert, drawing some unpremul image in Chrome's tests somewhere.
Change-Id: I453f9df44ade807316935921cbae82961e2f08aa
Reviewed-on: https://skia-review.googlesource.com/24862
Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Mike Klein <mtklein@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 51f6a0f89e55b2c0f102aa7963320a23c586e71d.
Reason for revert: try to fix chrome roll
Original change's description:
> Remove deadcode for sRGB image shading.
>
> Change-Id: I9d98da67d97b64ab55cf44b9ae447882dccda1ca
> Reviewed-on: https://skia-review.googlesource.com/20695
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Commit-Queue: Herb Derby <herb@google.com>
TBR=mtklein@chromium.org,mtklein@google.com,herb@google.com,reed@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I90409a08409177d9dc3b094d736af0fdaf7d6cdd
Reviewed-on: https://skia-review.googlesource.com/20824
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit e08e639063dd5476b5a1a24c0f0dc8f1139bfd8d.
Reason for revert: revert was not clean
Original change's description:
> Revert "Remove deadcode for sRGB image shading."
>
> This reverts commit 51f6a0f89e55b2c0f102aa7963320a23c586e71d.
>
> Reason for revert: crazy attempt to fix chrome roll
>
> Original change's description:
> > Remove deadcode for sRGB image shading.
> >
> > Change-Id: I9d98da67d97b64ab55cf44b9ae447882dccda1ca
> > Reviewed-on: https://skia-review.googlesource.com/20695
> > Reviewed-by: Mike Klein <mtklein@chromium.org>
> > Commit-Queue: Herb Derby <herb@google.com>
>
> TBR=mtklein@chromium.org,mtklein@google.com,herb@google.com,reed@google.com
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Change-Id: Icab02936d6c18e50b8de353aa1cd4c225e15e0bf
> Reviewed-on: https://skia-review.googlesource.com/20800
> Reviewed-by: Mike Reed <reed@google.com>
TBR=mtklein@chromium.org,mtklein@google.com,herb@google.com,reed@google.com
Change-Id: Ibc579a5a95e78cb257e8d443dbb905db3761e84a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/20802
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Reed <reed@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 51f6a0f89e55b2c0f102aa7963320a23c586e71d.
Reason for revert: crazy attempt to fix chrome roll
Original change's description:
> Remove deadcode for sRGB image shading.
>
> Change-Id: I9d98da67d97b64ab55cf44b9ae447882dccda1ca
> Reviewed-on: https://skia-review.googlesource.com/20695
> Reviewed-by: Mike Klein <mtklein@chromium.org>
> Commit-Queue: Herb Derby <herb@google.com>
TBR=mtklein@chromium.org,mtklein@google.com,herb@google.com,reed@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: Icab02936d6c18e50b8de353aa1cd4c225e15e0bf
Reviewed-on: https://skia-review.googlesource.com/20800
Reviewed-by: Mike Reed <reed@google.com>
|
|
|
|
|
|
|
| |
Change-Id: I9d98da67d97b64ab55cf44b9ae447882dccda1ca
Reviewed-on: https://skia-review.googlesource.com/20695
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Herb Derby <herb@google.com>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gonna start using this, might as well define it once centrally.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2126253002
No public API changes.
TBR=reed@google.com
Review-Url: https://codereview.chromium.org/2126253002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1775963002
Review URL: https://codereview.chromium.org/1775963002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1757193002
Review URL: https://codereview.chromium.org/1757193002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1723683002
Review URL: https://codereview.chromium.org/1723683002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1711963003
curr/maxrss loops min median mean max stddev samples config bench
10/10 MB 1 481µs 504µs 512µs 580µs 6% ▁▁▄▆▂▃▁▁▁▁▁▁▃▇█▅▃█▃▅ nonrendering SkBitmapFPAffineXClampYClampFilterOrig
10/10 MB 1 2.21ms 2.31ms 2.31ms 2.53ms 4% ▁▁▆▃▃▃▄▅▂▁▄▁█▅▁▁▄▂▆▁ nonrendering SkBitmapFPAffineXClampYClampFilterLinr
10/10 MB 1 2.49ms 2.63ms 2.61ms 2.78ms 4% ▄▃▇▄▅▇▆▁▆▁▁▁▅▂▁▄▃█▆▃ nonrendering SkBitmapFPAffineXClampYClampFiltersRGB
10/10 MB 2 150µs 151µs 153µs 162µs 2% ▅▇▂▂▁▁▂▂▁▁▂▂▁▁▁▁▇█▂▁ nonrendering SkBitmapFPAffineXClampYClampNearestOrig
10/10 MB 1 552µs 553µs 562µs 658µs 4% ▁▁▁▁▁▁▁▁▁▄▃▁▁▁▁▁▁▁▁█ nonrendering SkBitmapFPAffineXClampYClampNearestLinr
10/10 MB 1 718µs 742µs 748µs 808µs 4% ▃▃▁▁▅▁▁▁▁▃▃▃▃▇▇▇▁▁▇█ nonrendering SkBitmapFPAffineXClampYClampNearestsRGB
10/10 MB 1 277µs 286µs 292µs 341µs 7% █▁▁▁▁▁▁▁▁▁▃▂▃▃▆█▄▂▂▂ nonrendering SkBitmapFPScaleXClampYClampFilterOrig
10/10 MB 1 2.21ms 2.41ms 2.39ms 2.55ms 4% ▄▆▃▅▇▂▁▁▇▅▆▅▅▆▄▅█▅▆▅ nonrendering SkBitmapFPScaleXClampYClampFilterLinr
10/10 MB 1 2.55ms 2.68ms 2.69ms 2.94ms 4% ▂▃▁▁▄▄▅▅▄▃█▄▃▇▂▁▃▃▂▂ nonrendering SkBitmapFPScaleXClampYClampFiltersRGB
10/10 MB 4 59.9µs 60.6µs 61.6µs 71.1µs 5% ▂▃▄▁▁▁▁█▇▁▂▁▁▁▁▁▁▁▁▁ nonrendering SkBitmapFPScaleXClampYClampNearestOrig
10/10 MB 1 534µs 560µs 559µs 613µs 5% ▇▂▁▅▅▅█▅▅▃▁▁▁▁▂▄▅▁▁▁ nonrendering SkBitmapFPScaleXClampYClampNearestLinr
10/10 MB 1 639µs 658µs 666µs 731µs 5% ▅█▃▂▃▇▆▁▁▁▁▁▂▁▁▁▁▄█▄ nonrendering SkBitmapFPScaleXClampYClampNearestsRGB
10/10 MB 4 61.6µs 65.7µs 65.5µs 70.4µs 5% ▃▃▃█▆▆▂▂▂▅▄▄▇▄▁▂▁▄██ nonrendering SkBitmapFPIdentityXClampYClampFilterOrig
10/10 MB 1 2.22ms 2.34ms 2.35ms 2.57ms 3% ▂█▅▄▃▃▃▄▂▄▄▄▂▄▁▆▃▁▄▃ nonrendering SkBitmapFPIdentityXClampYClampFilterLinr
10/10 MB 1 2.42ms 2.52ms 2.52ms 2.76ms 4% ▁▁▄▂▄▄▃▅█▄▅▁▃▁▁▃▁▄▃▃ nonrendering SkBitmapFPIdentityXClampYClampFiltersRGB
10/10 MB 4 59.7µs 64.7µs 64.8µs 73.3µs 7% ▂▂▄▁▂▁▁▂▁▁▆▄▆▆▇▄▆▇▂█ nonrendering SkBitmapFPIdentityXClampYClampNearestOrig
10/10 MB 1 376µs 388µs 387µs 429µs 4% ▃▃▆▁▄▄▁▃█▁▁▁▁▁▃▃▄▁▁▁ nonrendering SkBitmapFPIdentityXClampYClampNearestLinr
10/10 MB 1 496µs 511µs 518µs 568µs 5% ▂▆▆█▆▃▂▂█▇▃▁▁▁▁▁▁▁▁▁ nonrendering SkBitmapFPIdentityXClampYClampNearestsRGB
Review URL: https://codereview.chromium.org/1711963003
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1712653002
Review URL: https://codereview.chromium.org/1712653002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713653002
Review URL: https://codereview.chromium.org/1713653002
|
|
|
|
|
|
|
| |
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1705203002
Review URL: https://codereview.chromium.org/1705203002
|
|
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1704583003
Review URL: https://codereview.chromium.org/1704583003
|