aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
...
* change SkStreams to work with sk_sp<SkData> instead of SkData*Gravatar reed2016-09-12
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333713002 Review-Url: https://codereview.chromium.org/2333713002
* Add workaround for Adreno copyImageToBuffer calls on VulkanGravatar egdaniel2016-09-12
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2328823003 Review-Url: https://codereview.chromium.org/2328823003
* Fix GaussianEdgeShader GLSL codeGravatar jvanverth2016-09-12
| | | | | | | | | | | | Implicit conversion of int constants to float is not always guaranteed GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2328263004 TBR=herbderby@google.com NOTRY=true NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2328263004
* Remove unneeded GrGLSLTransformedCoordsArray typeGravatar bsalomon2016-09-12
| | | | | | | Rename GrGLSLFragmentBuilder::ensureFSCoords2D to ensureCoords2D and make it take an arbitrary GrShaderVar. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324663004 Review-Url: https://codereview.chromium.org/2324663004
* Revert of Turned on SkSL->GLSL compiler (patchset #12 id:220001 of ↵Gravatar ethannicholas2016-09-12
| | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2288033003/ ) Reason for revert: Compilation errors on some bots. Original issue's description: > Turned on SkSL->GLSL compiler > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288033003 > > Committed: https://skia.googlesource.com/skia/+/9b0fe3d125f237d9884732a48414fa85fc71b4e3 TBR=benjaminwagner@google.com,bsalomon@google.com,egdaniel@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2337553002
* Remove unneeded bounds outset in GrDrawContext::drawVertices.Gravatar bsalomon2016-09-12
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2329403004 Review-Url: https://codereview.chromium.org/2329403004
* glTexStorage requires sized formats, ensure that we're following that ruleGravatar brianosman2016-09-12
| | | | | | | | | | In some situations (at least ANGLE ES3), we were passing GL_BGRA, rather than GL_BGRA8. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2336613002 Review-Url: https://codereview.chromium.org/2336613002
* Remove ability to skip coord transform comparison in pipeline comparison.Gravatar bsalomon2016-09-12
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316413003 Review-Url: https://codereview.chromium.org/2316413003
* SkPDF: refactor & code cleanup ahead of https://crrev.com/2322403002Gravatar halcanary2016-09-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | SkPDFDevice::GraphicStateEntry: remove unnecessary fFont and fTextSize. SkPDFDevice::updateFont(): replace with update_font() and inlined code. De-duplicate this block of code. SkPDFResourceDict::GetResourceTypePrefix function made public: removes need for temporary SkString returned by SkPDFResourceDict::getResourceName() GlyphPositioner: delay writing intial matrix until first glyph. Assert that widechars is a constant. SkPDFFont::FontType(): make public so that PDFDevice can know about multibyte status. SkPDFFont::countStretch() removed, and the stretch loop flattened. *no changes in PDF output* BUG=skia:5434 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2327953002 Review-Url: https://codereview.chromium.org/2327953002
* Two changes:Gravatar brianosman2016-09-12
| | | | | | | | | | | | | | | | | 1. Remove special premul handling from gamut xform code Alpha is a constant, so the gamut transformation results remain unchanged (it distributes across the linear matrix multiply). 2. Use SkMatrix44 rather than array of floats Preserves semantic intention, and makes upcoming code (where we transform colors on the CPU by that matrix) simpler. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2329553002 Review-Url: https://codereview.chromium.org/2329553002
* Turned on SkSL->GLSL compilerGravatar ethannicholas2016-09-12
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2288033003 Review-Url: https://codereview.chromium.org/2288033003
* Update SampleAndroidShadows to use algorithm closer to Android OpenGLGravatar jvanverth2016-09-12
| | | | | | | | | | | | | | | Includes: * Update light position to be at a similar distance to Android OS * Scale spot shadows correctly * Compute stroke shapes and radii correctly * Allow for larger blur radius for shadows GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319003003 TBR=reed@google.com NOTRY=true NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2319003003
* check for identity in translateGravatar reed2016-09-12
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2331943002 TBR= NOTREECHECKS=True NOTRY=True Review-Url: https://codereview.chromium.org/2331943002
* fix code behind SK_SUPPORT_LEGACY_MINOR_EFFECT_PTRGravatar reed2016-09-12
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2337433002 TBR= NOTREECHECKS=True NOTRY=True Review-Url: https://codereview.chromium.org/2337433002
* use expected name for setDrawLooper/getDrawLooperGravatar reed2016-09-11
| | | | | | | | | | | | Needed for future pipe cl. Next cl should be to guard the looper entirely (since its deprecated) BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2326173002 TBR= Review-Url: https://codereview.chromium.org/2326173002
* Adds missing and removes duplicate tracing macros.Gravatar carlosk2016-09-09
| | | | | | | | | | | | | | This fixes the missing tracing nested instant call without any arguments and removes the duplicate of the one with 2 arguments. This is a follow up on https://crrev.com/2326483004 BUG=645308 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321283002 NOPRESUBMIT=true CQ_EXCLUDE_TRYBOTS=client.skia.fyi:skia_presubmit-Trybot Review-Url: https://codereview.chromium.org/2321283002
* made point lights linear attenuation; also fixed point light depth bugGravatar vjiaoblack2016-09-09
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323383002 Review-Url: https://codereview.chromium.org/2323383002
* Fix color gamut xform matrices in GPU codeGravatar brianosman2016-09-09
| | | | | | | | | | | Now that we're not storing them transposed, we can plumb them to the shader column-major all the way, and then multiply colors on the right, as it should be. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2326093002 Review-Url: https://codereview.chromium.org/2326093002
* Fix storage of gamut transform matrices in SkColorSpaceGravatar brianosman2016-09-09
| | | | | | | | | | | | | | | We were effectively storing the transpose, which made all of our operations on individual colors, and our concatenation of matrices awkward and backwards. I'm planning to push this further into Ganesh, where I had incorrectly adjusted to the previous layout, treating colors as row vectors in the shaders. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324843003 Review-Url: https://codereview.chromium.org/2324843003
* Skip adding coincident edges foundGravatar caryclark2016-09-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | during curve intersection if their ends are nearly the same. Loosen conic/line intersection point check. Detect when coincident points are unordered. This means that points a/b/c on one curve may appear in b/c/a order on the opposite curve. Restructure addMissing to return success and return if a coincidence was added as a parameter. With this, tiger part a works. Tiger part b exposes bugs around tight quads that are nearly coincident with themselves, and are coincident with something else. The greedy coicident matcher may cause the point order to be out of sync. Still working out what to do in this case. TBR=reed@google.com GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321773002 Review-Url: https://codereview.chromium.org/2321773002
* Added in Radial ShadowsGravatar vjiaoblack2016-09-09
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2311223004 Review-Url: https://codereview.chromium.org/2311223004
* Delete some LUTs from SkColorSpaceXformGravatar msarett2016-09-09
| | | | | | | | | | No need to keep these around. In the rare case that these are needed, we can just go ahead and build them. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2326043002 Review-Url: https://codereview.chromium.org/2326043002
* fix fuzzerGravatar caryclark2016-09-09
| | | | | | | | | | | | Earlier fix aborted coincident loop on wrong condition. This aborts only when it reaches the end, and then propagates the error out correctly. TBR=reed@google.com BUG=644680, 644684 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2327053002 Review-Url: https://codereview.chromium.org/2327053002
* SkPDF: implement drawTextBlob()Gravatar halcanary2016-09-09
| | | | | | | | | | | | | | Pass new fields from https://skia.googlesource.com/skia/+/4f0a23a into SkPDFDevice::internalDrawText() (a later CL will use them for /ActualText. No change in PDF output. BUG=skia:5434 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300393002 Review-Url: https://codereview.chromium.org/2300393002
* SkPDF: hand SfntlyWrapper::SubsetFont() ttcIndex, not fontName.Gravatar halcanary2016-09-08
| | | | | | | | Also, minor code refactoring. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2258233002 Committed: https://skia.googlesource.com/skia/+/fce190647285423bf36c44bca09db78a6af30f9f Review-Url: https://codereview.chromium.org/2258233002
* Checking for valid colorType, alphaType, colorSpace in SkCodecGravatar msarett2016-09-08
| | | | | | | | | | | | | | | | | * Refactor to share code between SkPngCodec and SkWebpCodec * Didn't end up sharing with SkJpegCodec but did refactor that code a bit * Disallow conversions to F16 with non-linear color spaces * Fail to decode if we fail to create a SkColorSpaceXform (should be an assert soon). We used to fallback on a legacy decode if we failed to create the transform. * A bunch of name changes BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319293003 Committed: https://skia.googlesource.com/skia/+/7a9900d6d34e437bb24beb5524a1f6488ae138c9 Review-Url: https://codereview.chromium.org/2319293003
* Move prepareForExternalIO implementation from GrContext to GrDrawingManagerGravatar bsalomon2016-09-08
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324473002 Review-Url: https://codereview.chromium.org/2324473002
* Apple devices do not support CRC32 instructions. Don't believe Clang's lies.Gravatar mtklein2016-09-08
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2322033002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Review-Url: https://codereview.chromium.org/2322033002
* Revert of Checking for valid colorType, alphaType, colorSpace in SkCodec ↵Gravatar msarett2016-09-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #2 id:100001 of https://codereview.chromium.org/2319293003/ ) Reason for revert: Broken perf bots Original issue's description: > Checking for valid colorType, alphaType, colorSpace in SkCodec > > * Refactor to share code between SkPngCodec and SkWebpCodec > * Didn't end up sharing with SkJpegCodec but did refactor > that code a bit > * Disallow conversions to F16 with non-linear color spaces > * Fail to decode if we fail to create a SkColorSpaceXform > (should be an assert soon). We used to fallback on a > legacy decode if we failed to create the transform. > * A bunch of name changes > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319293003 > > Committed: https://skia.googlesource.com/skia/+/7a9900d6d34e437bb24beb5524a1f6488ae138c9 TBR=scroggo@google.com,brianosman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2328663002
* Checking for valid colorType, alphaType, colorSpace in SkCodecGravatar msarett2016-09-08
| | | | | | | | | | | | | | | | * Refactor to share code between SkPngCodec and SkWebpCodec * Didn't end up sharing with SkJpegCodec but did refactor that code a bit * Disallow conversions to F16 with non-linear color spaces * Fail to decode if we fail to create a SkColorSpaceXform (should be an assert soon). We used to fallback on a legacy decode if we failed to create the transform. * A bunch of name changes BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319293003 Review-Url: https://codereview.chromium.org/2319293003
* Cache the inverse matrix on SkColorSpace. Rename xyz() to toXYZ().Gravatar brianosman2016-09-08
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2323003002 Review-Url: https://codereview.chromium.org/2323003002
* Push usage of GrColor4f into OverrideInputGravatar brianosman2016-09-08
| | | | | | | | | Just a change to preserve precision. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324553002 Review-Url: https://codereview.chromium.org/2324553002
* removed const from ASTVarDeclaration::fName to avoid a Chromium build failureGravatar ethannicholas2016-09-08
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2325673002 Review-Url: https://codereview.chromium.org/2325673002
* Add GM/slide to simulate Android-style reveal clipGravatar robertphillips2016-09-08
| | | | | | | | | Hopefully, this will let us play w/ geometric and shader-based solutions. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003 Committed: https://skia.googlesource.com/skia/+/ffac5c4aae18fc706e4077763c190a89c8507fb0 Review-Url: https://codereview.chromium.org/2316593003
* SkLiteDL: drawAsLayer()Gravatar mtklein2016-09-08
| | | | | | | | | This more or less the API you were thinking? BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2315283002 Review-Url: https://codereview.chromium.org/2315283002
* Flesh out SkOpts namespaces.Gravatar mtklein2016-09-08
| | | | | | | | | | This makes it easier to see the baseline CPU feature settings for a build when looking at a stack trace or profile. This fills out all the features we currently might care about. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318313003 Review-Url: https://codereview.chromium.org/2318313003
* Add color xform support to SkWebpCodecGravatar msarett2016-09-08
| | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294993002 Committed: https://skia.googlesource.com/skia/+/828ed1777da74692d0c8a5834017929f5aedcc6b Review-Url: https://codereview.chromium.org/2294993002
* GN: default to -O1Gravatar mtklein2016-09-07
| | | | | | | | | | | | | | | | | | | In a GN world we are no longer tied to the Debug/Release dichotomy of GYP, and extra_cflags makes it trivially easy to override any flags we set by default. These two together mean we don't have to make the default Debug build pointlessly unoptimized. -O1 takes negligibly longer to compile than -O0, doesn't make debugging difficult, and the code is considerably better. DM runs ~4x faster this way. Backstory: I just re-noticed we do this for our Debug MSAN builds, which has had a serious wall-time slimming effect. I was about to restore it to my GN MSAN builds when I realized, hey, maybe we should do this for all builds. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2322753002 Review-Url: https://codereview.chromium.org/2322753002
* Rename SkColorSpace::GammaNamed to SkColorSpace::RenderTargetGammaGravatar msarett2016-09-07
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319293002 Review-Url: https://codereview.chromium.org/2319293002
* Revert of Add color xform support to SkWebpCodec (patchset #2 id:80001 of ↵Gravatar msarett2016-09-07
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/2294993002/ ) Reason for revert: Windows bots hate it when I upload new images. Original issue's description: > Add color xform support to SkWebpCodec > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294993002 > > Committed: https://skia.googlesource.com/skia/+/828ed1777da74692d0c8a5834017929f5aedcc6b TBR=scroggo@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/2318253004
* Add color xform support to SkWebpCodecGravatar msarett2016-09-07
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294993002 Review-Url: https://codereview.chromium.org/2294993002
* refactored SkSL VarDeclaration handlingGravatar ethannicholas2016-09-07
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2312233002 Review-Url: https://codereview.chromium.org/2312233002
* Delete SkColorSpace::gammaNamed() from public APIGravatar msarett2016-09-07
| | | | | | | | | Move fGammaNamed to SkColorSpace_Base. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318663003 Review-Url: https://codereview.chromium.org/2318663003
* Merge building of program desc in Vulkan into one stepGravatar egdaniel2016-09-07
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2318143002 Review-Url: https://codereview.chromium.org/2318143002
* Revert of Add GM/slide to simulate Android-style reveal clip (patchset #6 ↵Gravatar robertphillips2016-09-07
| | | | | | | | | | | | | | | | | | | | | | | | id:100001 of https://codereview.chromium.org/2316593003/ ) Reason for revert: Shader compilation failure Original issue's description: > Add GM/slide to simulate Android-style reveal clip > > Hopefully, this will let us play w/ geometric and shader-based solutions. > > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003 > > Committed: https://skia.googlesource.com/skia/+/ffac5c4aae18fc706e4077763c190a89c8507fb0 TBR=jvanverth@google.com,djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2316303002
* Add minimal support for readPixels in raster F16Gravatar brianosman2016-09-07
| | | | | | | | | | | Still doesn't support doing premul <-> unpremul conversions, but handles the simple cases (which would previously always fail). Fixes the new gamut gm (partially) in f16 config. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2321673002 Review-Url: https://codereview.chromium.org/2321673002
* Use demux API in SkWebpCodecGravatar msarett2016-09-07
| | | | | | | | | | | | | | | * Necessary to read ICC profiles * Will be necessary to implement animation * Requires consolidated data with length Doesn't affect decode performance (thought I believe our performance tests only cover SkStreams with memory bases). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2311793004 Review-Url: https://codereview.chromium.org/2311793004
* Add GM/slide to simulate Android-style reveal clipGravatar robertphillips2016-09-07
| | | | | | | | Hopefully, this will let us play w/ geometric and shader-based solutions. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003 Review-Url: https://codereview.chromium.org/2316593003
* Restructure flushing relationship between GrContext, GrDrawingManager, and ↵Gravatar bsalomon2016-09-07
| | | | | | | | | | | | | | | | | | GrResourceCache. Consolidates all flush actions into GrDrawingManager and makes GrContext::flush a passthrough. Removes the unused and untested discard flush variation. Replaces the indirect overbudget callback mechanism of GrResourceCache with a flag set by resource cache when it wants to flush that is checked after each draw by GrDrawContext. Modifies GrResourceCache::notifyFlushOccurred() to take a param indicating whether it triggered the flush that just occurred. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2307053002 Committed: https://skia.googlesource.com/skia/+/1dbb207babecdae8f1f74ed9d9900c73064df744 Review-Url: https://codereview.chromium.org/2307053002
* SkPDF: remove unused fallback clipping codeGravatar halcanary2016-09-07
| | | | | | | | | This code is untested and unnecessary. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319653002 Review-Url: https://codereview.chromium.org/2319653002