| Commit message (Collapse) | Author | Age |
... | |
|
|
|
| |
Review URL: https://codereview.chromium.org/723183002
|
|
|
|
|
|
|
|
| |
coverage stages.
BUG=skia:
Review URL: https://codereview.chromium.org/719203002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SkRecord performance is not sensitive to these values, so we can cut some
storage. This rearranges the space-remaining logic to use a count of bytes
left rather than a pointer to the end, cutting memory usage a little more.
An SkVarAlloc used to weigh 20 or 32 bytes which now becomes 16 or 24.
I think if I think about it a bit more I can trim off that Block* too,
getting us to 12 or 16 bytes.
Because we now just always grow by doubling, this CL switches from storing
fSmallest to its log base 2. This has the nice effect of never having to worry
about it overflowing, and means we can probably squeeze it down into a byte
if we want, even 6 bits.
BUG=skia:
Review URL: https://codereview.chromium.org/721313002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a port of https://codereview.chromium.org/723743002/ with the
following changes:
* drop the legacy onCreateDevice variant completely
* also convert SkXPSDevice & SkGatherPixelRefsAndRects to the new API
This is expected to break canaries and will require a manual/cowboy
roll.
TBR=reed@google.com
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/720213002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
have tiny line segments embedded and double back to create near-coincident conditions.
The fixes include
- detect when finding the active top loops between two possible answers
- preflight chasing winding to ensure answer is consistent
- binary search more often when quadratic intersection fails
- add more failure paths when an intersect is missed
While this fixes the chrome bug, reenabling path ops in svg should be deferred until additional fixes are landed.
TBR=
BUG=421132
Committed: https://skia.googlesource.com/skia/+/6f726addf3178b01949bb389ef83cf14a1d7b6b2
Review URL: https://codereview.chromium.org/633393002
|
|
|
|
|
|
|
|
|
| |
Allow the srcCoeff to be anything as long as it does not reference the dst. Previous version
required srcCoeff to be one.
BUG=skia:
Review URL: https://codereview.chromium.org/718103003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/723743002/)
Reason for revert:
mac_chromium_rel_ng unittest failures. speculating caused by this cl.
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/5262
Original issue's description:
> start to replace onCreateDevice with onCreateCompatibleDevice
>
> the new virtual takes a struct which we can amend in the future w/o having to
> update our subclasses in chrome.
>
> BUG=skia:
> NOTRY=True
>
> Committed: https://skia.googlesource.com/skia/+/b122ee50fb56cf6669fe1668b82c8815896e9943
TBR=fmalita@google.com,fmalita@chromium.org,reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/728433002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Like SkChunkAlloc, but
- does its allocation with better sympathy for malloc granularity;
- the fast path inlines entirely;
- smaller per-block overhead;
- smaller per-SkVarAlloc overhead;
- growth parameters are a little more tunable.
Its main downside is less flexibility; it supports fewer methods than SkChunkAlloc.
These current parameters bring the first allocation down from 4K to 1K,
without affecting recording time on my desktop. skiaperf.com will tell the
whole story.
BUG=skia:
Review URL: https://codereview.chromium.org/674263002
|
|
|
|
|
|
|
|
|
|
| |
the new virtual takes a struct which we can amend in the future w/o having to
update our subclasses in chrome.
BUG=skia:
NOTRY=True
Review URL: https://codereview.chromium.org/723743002
|
|
|
|
|
|
|
|
| |
This should fix our failing 32-bit test bots.
BUG=skia:
Review URL: https://codereview.chromium.org/715423003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/715233005
|
|
|
|
|
|
|
| |
BUG=skia:3122
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/724443002
|
|
|
|
|
|
| |
BUG=skia:2889
Review URL: https://codereview.chromium.org/702413003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/719113004
|
|
|
|
|
|
|
|
| |
SkBitmapHeap is still used---now exclusively---by pipe.
BUG=skia:
Review URL: https://codereview.chromium.org/715413002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/719133002
|
|
|
|
|
|
| |
BUG=skia:3117
Review URL: https://codereview.chromium.org/718103002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/698873003/)
Reason for revert:
Failing bots.
Original issue's description:
> Sk4x_sse.h
>
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/e4bf793120d3bfc9b003d11880a3fb73ff2b89e9
TBR=reed@google.com,mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/719143002
|
|
|
|
|
|
|
|
| |
First step: no more paint flattening or deduplication.
BUG=skia:
Review URL: https://codereview.chromium.org/723593002
|
|
|
|
|
|
|
|
| |
This will help with the ability to subclass, add to, etc. GrInvariantOutput. Also it was simply
getting a little too big to be a "supporting" subclass
BUG=skia:
Review URL: https://codereview.chromium.org/699943003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/698873003
|
|
|
|
|
|
|
|
|
|
|
| |
This define was added in
"SK_USE_SCALED_FONTMETRICS for correct scaling"
c17c6582ec0b7bc211d7de9e8d634692d239c123.
Users all now define this flag, so it may now be removed.
BUG=chromium:420901
Review URL: https://codereview.chromium.org/720743003
|
|
|
|
|
|
|
|
|
|
| |
Now that CollectLayers directly uses FillBounds we can:
skip the explicit intersection with the clipBounds after an adjustAndMap call
skip the storage and use of the clipBounds in SaveLayerInfo
Review URL: https://codereview.chromium.org/719793002
|
|
|
|
|
|
| |
Rather then exposing parts of FillBounds (as in Expose FillBounds to allow GrPictureUtils::CollectLayers to be layered on top of it - https://codereview.chromium.org/698643002/), this CL moves CollectLayers into SkRecordDraw.cpp to accomplish the layering.
Review URL: https://codereview.chromium.org/716913003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/716793004
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/715873002
|
|
|
|
|
|
|
|
| |
Internal only helper class for manipulating and accessing cache keys.
BUG=skia:2889
Review URL: https://codereview.chromium.org/703303003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/683133006
|
|
|
|
|
|
| |
BUG=skia:3117
Review URL: https://codereview.chromium.org/691383003
|
|
|
|
|
|
|
|
| |
This reverts commit c71ffd4e76d1abcd28ac74463349970f60a3350f.
TBR=
Review URL: https://codereview.chromium.org/683003003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/717753002/)
Reason for revert:
modecolorfilters, perhaps more changed
Original issue's description:
> modify nothingToDraw to notice filters
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/d5688c509293a450c058e0cc1f4673be2931bb5c
TBR=djsollen@google.com,reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/717813002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/717753002
|
|
|
|
|
|
|
| |
Need to include (transitively) SkUserConfig before checking
SK_SUPPORT_GPU.
Review URL: https://codereview.chromium.org/693613005
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/699023003
|
|
|
|
|
|
|
|
|
| |
content key can be set after pending io scheduled (e.g. when scaling up a npot texture to pot).
BUG=skia:2889
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/693843004
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=djsollen@google.com
Review URL: https://codereview.chromium.org/697363004
|
|
|
|
|
|
|
|
|
| |
Since we now snap and create the ODS one time in the inorder draw buffer,
there is no need for us to keep a cached version of it around.
BUG=skia:
Review URL: https://codereview.chromium.org/701123003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/712363003
|
|
|
|
|
|
| |
BUG=skia:2889
Review URL: https://codereview.chromium.org/705413002
|
|
|
|
|
|
|
|
|
| |
work on tests
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-ASAN-Trybot,Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot,Test-Win7-ShuttleA-HD2000-x86_64-Debug-Trybot,Test-Win7-ShuttleA-HD2000-x86-Debug-Trybot
BUG=skia:
Review URL: https://codereview.chromium.org/704923003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/696063005
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL:
1) removes the EXPERIMENTAL_optimize on SkCanvas & SkDevice
2) moves the saveLayer gathering step to endRecording
3) Replaces GPUOptimize with SkRecordComputeLayers
4) Update bench_pictures & render_pictures to provide the new flag
#2 also necessitated moving the BBH computation (and record optimization) out of SkPicture's ctor (and into endRecording)
Review URL: https://codereview.chromium.org/718443002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/709133003
|
|
|
|
|
|
|
|
| |
As suggested by reed@ in http://crrev.com/711133002
TBR=reed@google.com
Review URL: https://codereview.chromium.org/707533003
|
|
|
|
|
|
|
|
|
| |
Fixes change introduced in http://crrev.com/645563002
This will allow SkDocument to be a drop-in repalcement to
SkPDFDocument/SkPDFDevice in Chromium.
Review URL: https://codereview.chromium.org/711133002
|
|
|
|
|
|
|
|
|
| |
This removes the old guarded code and enables the new api
introduced with "Update fontMgr to take list of bcp47 language tags."
c20386e3937d3d398ac9b35f9c7d997e972ade98 . Blink on Android is
already using the new code.
Review URL: https://codereview.chromium.org/705843004
|
|
|
|
|
|
|
|
|
|
|
|
| |
We previously saw crashes decoding bad ICO files. Add tests for
known bad files.
While testing, I learned that one of them still crashes. Check for
large offset and size separately to fix the crash.
BUG=skia:2878
Review URL: https://codereview.chromium.org/712123002
|
|
|
|
|
|
| |
TBR=robertphillips@google.com
Review URL: https://codereview.chromium.org/718493002
|
|
|
|
|
|
| |
BUG=skia:2889
Review URL: https://codereview.chromium.org/707493002
|
|
|
|
|
|
| |
The year was off by 1900
Review URL: https://codereview.chromium.org/714633002
|