aboutsummaryrefslogtreecommitdiffhomepage
path: root/src
Commit message (Collapse)AuthorAge
* make internaldrawBmpText part of GrTextUtilsGravatar joshualitt2015-12-11
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1518883002
* Add check for highp support in Conic effectGravatar robertphillips2015-12-11
| | | | | | | | | | | | | | | | | | | | | This CL may not really be necessary since it seems that the Android Ones we have fall back to mediump when highp isn't supported. FYI, for bits-of-precision/precision we have: Low Med High Precision-Used A1 (Cherry One - Mali 400) 10 10 0 Med - conic looks bad N5 (Adreno 330) 10 10 23 High - conic looks bad!!! N6 (Adreno 420) 10 10 23 High - conic looks good N7v2 (Adreno 320) 10 10 23 High - conic looks bad!!! N9 (K1) 23 23 23 High - looks good N10 (Mail-604) 10 10 23 High - looks good I suspect derivative computation is broken on the Adreno 300s. BUG=555779,skia:4668 TBR=bsalomon@google.com Review URL: https://codereview.chromium.org/1513573009
* Initialize glGen* call id args to zeroGravatar kkinnunen2015-12-11
| | | | | | | | | | | | Initialize glGenTexture, glGenBuffer call id buffer items to zero before calls. Otherwise it's not easy to check if the call succeeded or not. Assert the rule in debug gl context. Make TesselatingPathRendererTests use debug gl context. It exercises some of the GenBuffers call sites. Review URL: https://codereview.chromium.org/1514033002
* Fix UB function problems for AA merger.Gravatar herb2015-12-10
| | | | | | BUG=skia:4634 Review URL: https://codereview.chromium.org/1518863002
* Change SkTaskGroup to use std::function. Ripple all the changes.Gravatar herb2015-12-10
| | | | | | BUG=skia:4634 Review URL: https://codereview.chromium.org/1519573003
* Use size_t for strlen() return valueGravatar scroggo2015-12-10
| | | | | | BUG=skia:2810 Review URL: https://codereview.chromium.org/1518843002
* try adding flag to allow lcd text even in a layerGravatar reed2015-12-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1513513002
* Address precision issue in circle blur effectGravatar robertphillips2015-12-10
| | | | | | BUG=560651 Review URL: https://codereview.chromium.org/1504333003
* Create GrTextUtilsGravatar joshualitt2015-12-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1514933002
* Add reallyHasAlpha() to SkAndroidCodecGravatar msarett2015-12-10
| | | | | | | | | This also modified the default implementation of onReallyHasAlpha() in SkCodec. BUG=skia: Review URL: https://codereview.chromium.org/1518743002
* default SkPixelSerializerGravatar halcanary2015-12-10
| | | | | | | | | | | | | | | Add SkImageEncoder::EncodeData(const SkPixmap&, ...) function. Add SkImageEncoder::CreatePixelSerializer() to return a PixelSerializer that calls into SkImageEncoder::EncodeData. SkImage::encode() make use of SkImageEncoder::CreatePixelSerializer. Committed: https://skia.googlesource.com/skia/+/b0bd1516bff3f5afcbfd615e805867531657811b Committed: https://skia.googlesource.com/skia/+/808ce2886d732b1055f89c8fb0f1b11b47fcb0ce Review URL: https://codereview.chromium.org/1507123002
* Move flush logic into GrAtlasTextBlobGravatar joshualitt2015-12-10
| | | | | | | TBR=bsalomon@google.com BUG=skia: Review URL: https://codereview.chromium.org/1518763002
* Switch SkAutoMalloc to SkAutoTMalloc to avoid castGravatar scroggo2015-12-10
| | | | | | | | | | | | Make SkAutoTMalloc's interface look more like SkAutoMalloc: - add free(), which does what you expect - make reset() return a pointer fPtr No public API changes (SkAutoTMalloc is in include/private) BUG=skia:2148 Review URL: https://codereview.chromium.org/1516833003
* Move DistanceAdjustTable to its own fileGravatar joshualitt2015-12-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1512823004
* Add Apple renderer strings to PowerVR detectionGravatar jvanverth2015-12-10
| | | | | | BUG=skia:4148 Review URL: https://codereview.chromium.org/1512903005
* SkDocument::setDCTEncoder() for old versions of webkitGravatar halcanary2015-12-10
| | | | Review URL: https://codereview.chromium.org/1505763003
* Move appending of large glyphs into GrAtlasTextBlobGravatar joshualitt2015-12-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1517563002
* Silence another PNG print statementGravatar scroggo2015-12-10
| | | | | | | It can still be turned on by using setting c_suppressPNGImageDecoderWarnings to true. Review URL: https://codereview.chromium.org/1512293003
* Move 'mustRegenerate' function into GrAtlasTextBlobGravatar joshualitt2015-12-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1515543003
* another null src, memcpy -> sk_careful_memcpyGravatar mtklein2015-12-10
| | | | | | | | https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3798/steps/dm/logs/stdio BUG=skia: Review URL: https://codereview.chromium.org/1510903005
* Remove uniform color for GrDistanceFieldGeoProcGravatar joshualitt2015-12-10
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1512533003
* Make NVPR a GL context option instead of a GL contextGravatar kkinnunen2015-12-10
| | | | | | | | | | | | | | | | | Make NVPR a GL context option instead of a GL context. This may enable NVPR to be run with command buffer interface. No functionality change in DM or nanobench. NVPR can only be run with normal GL APIs. BUG=skia:2992 Committed: https://skia.googlesource.com/skia/+/eeebdb538d476c1bfc8b63a946094ca1b505ecd1 Committed: https://skia.googlesource.com/skia/+/64492c43c3faee7ab0f69b1c84e0267616f85e52 Review URL: https://codereview.chromium.org/1448883002
* Use a pseudo-extension CHROMIUM_framebuffer_mixed_samplesGravatar kkinnunen2015-12-10
| | | | | | | | | | | Use the pseudo-extension CHROMIUM_framebuffer_mixed_samples when run with Chromium command buffer. The extension exposes NV_framebuffer_mixed_samples subset that Skia needs in order to use NV_path_rendering with mixed samples. BUG=506765 Review URL: https://codereview.chromium.org/1507373004
* Populate NVPR functions when run with command bufferGravatar kkinnunen2015-12-09
| | | | | | | | | | Populate the NV_path_rendering functions provided by CHROMIUM_path_rendering when the tools are being run with command buffer API. BUG=skia:2992 Review URL: https://codereview.chromium.org/1510163003
* Do elliptical clips in normalized space on devices with a "real" mediumpGravatar bsalomon2015-12-09
| | | | | | BUG=chromium:477684 Review URL: https://codereview.chromium.org/1517573002
* Make "alpha only" be a property of GrTextureProducerGravatar bsalomon2015-12-09
| | | | Review URL: https://codereview.chromium.org/1507973005
* Use BRGA as internal format on later iOSGravatar jvanverth2015-12-09
| | | | | | BUG=skia:2733 Review URL: https://codereview.chromium.org/1504333007
* add support for capped hairlinesGravatar caryclark2015-12-09
| | | | | | | | | Extend the ends of hairline and haircurve segments when the paint is set to square or round, and the line or curve is at the start or end of a contour. R=reed@google.com BUG=skia:4599 Review URL: https://codereview.chromium.org/1491843006
* Silence libjpeg warnings in SkImageDecoderGravatar scroggo2015-12-09
| | | | | | | | | | | | We just did the same for libpng (see crrev.com/1512043002), so we might as well do this here. SkImageDecoder is deprecated, and SkCodec already has a way to turn off its messages. BUG=skia:1649 Review URL: https://codereview.chromium.org/1505953007
* Another undefined shift caught by -fsanitize=shift.Gravatar mtklein2015-12-09
| | | | | | | | | | left was -16 I didn't see any warning about fTop, but seems simplest to fix that too. BUG=skia: Review URL: https://codereview.chromium.org/1505993007
* Another memcpy -> sk_careful_memcpyGravatar mtklein2015-12-09
| | | | | | | | | | | https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3787/steps/dm/logs/stdio dst is null. TBR=herb@google.com BUG=skia: Review URL: https://codereview.chromium.org/1507113007
* Fix compile error with GOOGLE3 define.Gravatar benjaminwagner2015-12-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1509023004
* Rewrite drawBitmap/ImageNine on top of GrTextureProducerGravatar bsalomon2015-12-09
| | | | Review URL: https://codereview.chromium.org/1504723004
* Remove no-op code in SkAlphaRuns::addGravatar scroggo2015-12-09
| | | | | | | | | | | | | | | The old code says runs += x + 1; alpha += x + 1; x = 0; lastAlpha += x; // we don't want the +1 The last line does nothing. Remove this unnecessary line. BUG=skia:401 Review URL: https://codereview.chromium.org/1506253002
* Silence libpng warnings in SkImageDecoderGravatar msarett2015-12-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1512043002
* ubsan shift fixesGravatar caryclark2015-12-09
| | | | | | | | | | | Use an inline function that does a normal shift. When built for the sanitizer, add casts so that the shift is unsigned. Also make a few fixes to do unsigned shifts or avoid the shift altogether; and add an argument spec to some macros. R=reed@google.com,mtklein@google.com BUG=skia:4633 Review URL: https://codereview.chromium.org/1503423003
* SkBitmap::installPixels(const SkPixmap&);Gravatar halcanary2015-12-09
| | | | Review URL: https://codereview.chromium.org/1505333002
* Prevent overflow in length() in GLCircularRRectEffectGravatar bsalomon2015-12-09
| | | | | | BUG=chromium:477684 Review URL: https://codereview.chromium.org/1517483002
* SkBitmap::getColor repsects swizzleGravatar halcanary2015-12-09
| | | | Review URL: https://codereview.chromium.org/1510253002
* Fix filter primitive bounds computations.Gravatar senorblanco2015-12-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make each filter responsible for expanding its destination bounds. Previously, we were using a union of all intermediate bounds sizes via join() calls in many image filters' computeFastBounds(), due to the fact that those filters could only produce bitmaps the same size as their inputs. Now, we compute optimal bounds for each filter as follows: 1) Pass the (unmodified) clip bounds to the root node of the DAG in the first recursive call to onFilterImage() as the Context's fClipBounds. 2) Reverse-map the clip: when recursing up the DAG in filterInput[GPU](), apply filter-specific expansion to the clip by calling calling onFilterNodeBounds(... kReverse). This allows upstream nodes to have a clip that respects the current node's requirements. This is done via helper function mapContext(). 3) Forward-map the source bitmap: just prior to applying the crop rect in applyCropRect(), we determine the filter's preferred bounds by mapping the source bitmap bounds forwards via onFilterNodeBounds(..., kForward). NOTE: GMs affected by this change: fast_slow_blurimagefilter: fast and slow paths now produce the same result spritebitmap: drawSprite() and drawBitmap() paths now produce the same result filterfastbounds: fast bounds are optimized; all drop-shadow results now appear apply-filter: snug and not-snug cases give same results dropshadowimagefilter: drawSprite() results now show shadows draw-with-filter: no artifacts on erode edges; blur edges no longer clipped displacement, imagefiltersbase, imagefiltersclipped, imagefilterscropexpand, imagefiltersscaled, matriximagefilter, resizeimagefilter, localmatriximagefilter, testimagefilters: fixed incorrect clipping imagefilterstransformed, morphology: no artifacts on erode edges BUG=skia:1062,skia:3194,skia:3939,skia:4337,skia:4526 Review URL: https://codereview.chromium.org/1308703007
* fix a couple flaky nonnull attribute ubsan warningsGravatar mtklein2015-12-09
| | | | | | | | | | | | | | | Errors this should fix: https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3779/steps/dm/logs/stdio https://uberchromegw.corp.google.com/i/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN/builds/3779/steps/nanobench/logs/stdio CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-ASAN-Trybot TBR=reed@google.com No API changes. BUG=skia: Review URL: https://codereview.chromium.org/1504313005
* Fix bug with GrAtlasTextContext color regenGravatar joshualitt2015-12-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1513723002
* Boost GrGLConicEffect's variables to all high precisionGravatar robertphillips2015-12-09
| | | | | | | | BUG=555779 Committed: https://skia.googlesource.com/skia/+/624c59a1c7af38eb83e803f345a6f3e225475a08 Review URL: https://codereview.chromium.org/1513483002
* Cap filtering to kMedium_SkFilterQuality when downsamplingGravatar fmalita2015-12-09
| | | | | | R=reed@google.com Review URL: https://codereview.chromium.org/1510673002
* Revert of Boost GrGLConicEffect's variables to all high precision (patchset ↵Gravatar robertphillips2015-12-09
| | | | | | | | | | | | | | | | | | | | | | #1 id:1 of https://codereview.chromium.org/1513483002/ ) Reason for revert: Broke build Original issue's description: > Boost GrGLConicEffect's variables to all high precision > > BUG=555779 > > Committed: https://skia.googlesource.com/skia/+/624c59a1c7af38eb83e803f345a6f3e225475a08 TBR=egdaniel@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=555779 Review URL: https://codereview.chromium.org/1514553002
* Revert of Make NVPR a GL context option instead of a GL context (patchset #9 ↵Gravatar borenet2015-12-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | id:160001 of https://codereview.chromium.org/1448883002/ ) Reason for revert: "Could not create surface" on Linux GTX660 bots Original issue's description: > Make NVPR a GL context option instead of a GL context > > Make NVPR a GL context option instead of a GL context. > This may enable NVPR to be run with command buffer > interface. > > No functionality change in DM or nanobench. NVPR can > only be run with normal GL APIs. > > BUG=skia:2992 > > Committed: https://skia.googlesource.com/skia/+/eeebdb538d476c1bfc8b63a946094ca1b505ecd1 > > Committed: https://skia.googlesource.com/skia/+/64492c43c3faee7ab0f69b1c84e0267616f85e52 TBR=mtklein@google.com,bsalomon@google.com,jvanverth@google.com,scroggo@google.com,kkinnunen@nvidia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:2992 Review URL: https://codereview.chromium.org/1513703002
* A small text cleanupGravatar joshualitt2015-12-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1508853005
* Boost GrGLConicEffect's variables to all high precisionGravatar robertphillips2015-12-09
| | | | | | BUG=555779 Review URL: https://codereview.chromium.org/1513483002
* Attempt to land cache purge again [and regen bot logs if still failing]Gravatar bsalomon2015-12-09
| | | | | | TBR= Review URL: https://codereview.chromium.org/1510103002
* Revert of default SkPixelSerializer (patchset #2 id:20001 of ↵Gravatar halcanary2015-12-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1507123002/ ) Reason for revert: I was overconfident. Original issue's description: > default SkPixelSerializer > > Add SkImageEncoder::EncodeData(const SkPixmap&, ...) function. > > Add SkImageEncoder::CreatePixelSerializer() to return a > PixelSerializer that calls into SkImageEncoder::EncodeData. > > SkImage::encode() make use of SkImageEncoder::CreatePixelSerializer. > > Committed: https://skia.googlesource.com/skia/+/b0bd1516bff3f5afcbfd615e805867531657811b > > Committed: https://skia.googlesource.com/skia/+/808ce2886d732b1055f89c8fb0f1b11b47fcb0ce TBR=reed@google.com,scroggo@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1511183002