aboutsummaryrefslogtreecommitdiffhomepage
path: root/src/core/SkRectPriv.h
Commit message (Collapse)AuthorAge
* remove unused/dumb methods from SkRectGravatar Mike Reed2018-04-11
| | | | | | | | Bug: skia: Change-Id: I407dc94256a347c7a9343b75a5af43c4294891d3 Reviewed-on: https://skia-review.googlesource.com/119360 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Yuqian Li <liyuqian@google.com>
* keep points as floats until after clippingGravatar Mike Reed2018-02-27
| | | | | | | | Bug: oss-fuzz:6539 Change-Id: Ia91dee2a023c9b17d06948c455b8ea6a1b213e0d Reviewed-on: https://skia-review.googlesource.com/110501 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Mike Reed <reed@google.com>
* detect fixed overflow in drawPointsGravatar Mike Reed2018-01-18
| | | | | | | | | | | | | | | | | | | | | This particular test this is addressing is: 1. very large device (>32K in a test case) 2. drawPoints has special (fast) case where it converts all of the pts (rects) into fixed point 3. overflows fixed -- assert Paths already don't draw into a device this large (they are limited by 32K I think, smaller if aa) The (theoretical) solution for paths is to tile the draw itself. Perhaps that approach could be applied everywhere in bitmapdevice... This older issue sums up this idea: https://bugs.chromium.org/p/skia/issues/detail?id=2122 Will look into this general solution in a separate CL/effort. Bug: skia:7425 Change-Id: I57f8da92df78127e6b8e42e422c43e50bb5748d6 Reviewed-on: https://skia-review.googlesource.com/96700 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* handle large rects, rename helperGravatar Mike Reed2018-01-17
| | | | | | | | | | | To fix gm/bigrect, needed to do adjust "largest" rect so it doesn't become empty when round-tripping with SkRect/SkIRect. I renamed it after this. Bug: skia: Change-Id: I747782c8456da603cf298275d2300ea1996e7629 Reviewed-on: https://skia-review.googlesource.com/95563 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Yuqian Li <liyuqian@google.com>
* shrink our 'largest' so that its non-emptyGravatar Mike Reed2018-01-09
| | | | | | | | Bug: skia: Change-Id: Ib12fd9491069440c85d5aa9c9d6d26787f03ef0d Reviewed-on: https://skia-review.googlesource.com/92643 Reviewed-by: Yuqian Li <liyuqian@google.com> Commit-Queue: Yuqian Li <liyuqian@google.com>
* use 64bit math to compute is a rect is emptyGravatar Mike Reed2018-01-09
| | | | | | | | | | | Will work next to try to make isEmpty() private Bug: skia:7470 Bug:799715 Change-Id: I7b43028ecd86dca68e0c67225712516d2f2f88a2 Reviewed-on: https://skia-review.googlesource.com/92620 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* make growToInclude privateGravatar Mike Reed2018-01-08
| | | | | | | | | Bug: skia: Change-Id: Id55344ba2f33563d22c2bf4d5829a9a31095a47d Reviewed-on: https://skia-review.googlesource.com/92143 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Cary Clark <caryclark@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* move largest apis into privateGravatar Mike Reed2018-01-08
| | | | | | | | | Related to https://skia-review.googlesource.com/c/skia/+/91860 Bug: skia: Change-Id: Ia8fd981b422bbab75541b078277d2e09e1fc9d41 Reviewed-on: https://skia-review.googlesource.com/91940 Reviewed-by: Brian Salomon <bsalomon@google.com>
* check for irect with overflow width/heightGravatar Mike Reed2018-01-03
Bug:798066 Change-Id: Iac324ac5a32fae241a528751c84279ce60ac4baf Reviewed-on: https://skia-review.googlesource.com/90544 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Reed <reed@google.com>