| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
| |
BUG=skia:3718
Review URL: https://codereview.chromium.org/1149163003
|
|
|
|
|
|
|
| |
NOTRY=true
TBR=borenet
Review URL: https://codereview.chromium.org/1153783003
|
|
|
|
|
|
|
|
|
| |
TBR=borenet
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/1145093005
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=borenet
Review URL: https://codereview.chromium.org/1137873007
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=borenet
Review URL: https://codereview.chromium.org/1131933007
|
|
|
|
|
|
|
| |
BUG=skia:3836
TBR=djsollen
Review URL: https://codereview.chromium.org/1145473002
|
|
|
|
|
|
|
|
|
|
| |
the sampleApp when starting.
BUG=skia:3815
DOCS_PREVIEW= https://skia.org/?cl=1136753003
R=bungeman@google.com, tomhudson@google.com
Review URL: https://codereview.chromium.org/1136753003
|
|
|
|
|
|
|
|
|
|
|
| |
Currently SampleApp on Android cannot find resources. This sets the
resourcePath to /data/local/tmp/skia/resources/ which is the path
used in documentationo. A future change will allow this default to be
overridden.
BUG=skia:3815
Review URL: https://codereview.chromium.org/1125363004
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1085583006
|
|
|
|
|
|
| |
BUG=skia:3774
Review URL: https://codereview.chromium.org/1122593003
|
|
|
|
|
|
| |
BUG=skia:1282
Review URL: https://codereview.chromium.org/1108013002
|
|
|
|
|
|
|
|
| |
This aliases all devices we know have NEON over to that too.
BUG=skia:
Review URL: https://codereview.chromium.org/1095953007
|
|
|
|
|
|
|
|
| |
Only affecting Build-Mac10.8-Clang-Arm7-Debug-Android.
BUG=skia:
Review URL: https://codereview.chromium.org/1093423003
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=borenet
Review URL: https://codereview.chromium.org/1087653005
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1073593002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I think Daisy's color order problems are in non-NEON ARM assembly.
NEON might actually be fine.
BUG=skia:1843
Committed: https://skia.googlesource.com/skia/+/a121c0ee6b911dd7004c6054a8692d37084b6b3d
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-Arm7-Debug-CrOS_Daisy-Trybot,Build-Ubuntu-GCC-Arm7-Debug-Android_Neon-Trybot,Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot,Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot
Review URL: https://codereview.chromium.org/1054233002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1054233002/)
Reason for revert:
whatever compiler we're using can't handle array subscripts for neon vectors
Original issue's description:
> Try ARMv7 and NEON for Daisy.
>
> I think Daisy's color order problems are in non-NEON ARM assembly.
> NEON might actually be fine.
>
> BUG=skia:1843
>
> Committed: https://skia.googlesource.com/skia/+/a121c0ee6b911dd7004c6054a8692d37084b6b3d
TBR=mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:1843
Review URL: https://codereview.chromium.org/1058173002
|
|
|
|
|
|
|
|
|
| |
I think Daisy's color order problems are in non-NEON ARM assembly.
NEON might actually be fine.
BUG=skia:1843
Review URL: https://codereview.chromium.org/1054233002
|
|
|
|
|
|
|
|
|
|
| |
It's looking like the previous CL did not fix the Daisy bot GMs,
even though that's still the only bit of code I can find that was
ignoring color order. Puzzled. Reverting arm_version=7 for now.
BUG=skia:1843
Review URL: https://codereview.chromium.org/1051423002
|
|
|
|
|
|
|
| |
BUG=skia:3600
DOCS_PREVIEW= https://skia.org/?cl=1036283002
Review URL: https://codereview.chromium.org/1036283002
|
|
|
|
|
|
|
|
| |
Enable Thumb2 iff ARM v7. (We don't turn it on today for ARM <v7, and ARM v8 doesn't support it.)
BUG=skia:
Review URL: https://codereview.chromium.org/1054993002
|
|
|
|
|
|
|
|
|
| |
This should be a ~noop as far as gold.skia.org goes.
After this, I'll try out NEON.
BUG=skia:1843
Review URL: https://codereview.chromium.org/1056793004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- remove unused alex
- streamline Link's config
- remove misleading Daisy config:
1) armv7=1 does nothing. We meant to type arm_version=7 here.
2) arm_neon=1 does nothing unless arm_version == 7.
3) arm_thumb=0 is the default when arm_version <= 7.
4) skia_arch_width=32 is the default when skia_arch_type=arm.
I'd just fix this to make Daisy arm_version=7 and arm_neon=1 (and
arm_thumb=1, which I'm going to separately make the default for
arm_version=7), but there are known color-order bugs with our
NEON procs that would make Daisy start pushing bad images to
Gold. Going to take baby steps here...
BUG=skia:1843
Committed: https://skia.googlesource.com/skia/+/3c2809bc612f4a265770914f860d214c9665dc4a
CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-Arm7-Debug-CrOS_Daisy-Trybot
Review URL: https://codereview.chromium.org/1051253002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/1051253002/)
Reason for revert:
arm_thumb not defined
Original issue's description:
> tidy up chromeos_setup.sh
>
> - remove unused alex
> - streamline Link's config
> - remove misleading Daisy config:
> 1) armv7=1 does nothing. We meant to type arm_version=7 here.
> 2) arm_neon=1 does nothing unless arm_version == 7.
> 3) arm_thumb=0 is the default when arm_version <= 7.
> 4) skia_arch_width=32 is the default when skia_arch_type=arm.
>
> I'd just fix this to make Daisy arm_version=7 and arm_neon=1 (and
> arm_thumb=1, which I'm going to separately make the default for
> arm_version=7), but there are known color-order bugs with our
> NEON procs that would make Daisy start pushing bad images to
> Gold. Going to take baby steps here...
>
> BUG=skia:1843
>
> Committed: https://skia.googlesource.com/skia/+/3c2809bc612f4a265770914f860d214c9665dc4a
TBR=borenet@google.com,mtklein@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:1843
Review URL: https://codereview.chromium.org/1059443002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- remove unused alex
- streamline Link's config
- remove misleading Daisy config:
1) armv7=1 does nothing. We meant to type arm_version=7 here.
2) arm_neon=1 does nothing unless arm_version == 7.
3) arm_thumb=0 is the default when arm_version <= 7.
4) skia_arch_width=32 is the default when skia_arch_type=arm.
I'd just fix this to make Daisy arm_version=7 and arm_neon=1 (and
arm_thumb=1, which I'm going to separately make the default for
arm_version=7), but there are known color-order bugs with our
NEON procs that would make Daisy start pushing bad images to
Gold. Going to take baby steps here...
BUG=skia:1843
Review URL: https://codereview.chromium.org/1051253002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1054633002
|
|
|
|
|
|
|
|
| |
BUG=skia:3257
Committed: https://skia.googlesource.com/skia/+/255dcd11992ebe74eb54202c48cf5394d33a8ce6
Review URL: https://codereview.chromium.org/1038863003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:260001 of https://codereview.chromium.org/1038863003/)
Reason for revert:
Trying out revert to see if it fixes Android bots.
Original issue's description:
> WIP: Added support for giflib, updated jpeg and png
>
> BUG=skia:3257
>
> Committed: https://skia.googlesource.com/skia/+/255dcd11992ebe74eb54202c48cf5394d33a8ce6
TBR=djsollen@google.com,scroggo@google.com,msarett@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=skia:3257
Review URL: https://codereview.chromium.org/1048713003
|
|
|
|
|
|
| |
BUG=skia:3257
Review URL: https://codereview.chromium.org/1038863003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/1011653004
|
|
|
|
| |
Review URL: https://codereview.chromium.org/979153002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/949853003
|
|
|
|
| |
Review URL: https://codereview.chromium.org/926003002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/914413003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When checking the skia_arch_type for "x86", instead of doing an
== compare, check if "x86" in skia_arch_type, so it will cover
both x86 and x86_64.
Except when we specifically want x86.
Set skia_arch_width based on "64" in skia_arch_type. No need to specify
in scripts.
In gyp_to_android.py, create a separate var_dict for x86_64.
BUG=skia:3419
Review URL: https://codereview.chromium.org/916113002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/917913004
|
|
|
|
|
|
|
|
|
|
| |
Properly labels several methods as static.
Use XML_GetBuffer to avoid an extra copy.
Set the memory allocators to Skia's.
Set define in 'defines' instead of cflags.
Update debug dumper.
Review URL: https://codereview.chromium.org/915443002
|
|
|
|
|
|
|
| |
Rename a few files to make their function clearer.
Update other files to remove dead code or improve function.
Review URL: https://codereview.chromium.org/865943007
|
|
|
|
|
|
|
|
|
| |
logcat -c clears the log before we run.
logcat -d dumps the log stdout and exits.
BUG=skia:
Review URL: https://codereview.chromium.org/870643002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/858233003
|
|
|
|
|
|
|
|
|
|
| |
This should make the android self-tests start passing again.
Rebaselined with:
$ python makefile_writer_tests.py --rebaseline
BUG=skia:
Review URL: https://codereview.chromium.org/860333004
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When running gyp_to_android inside a Skia tree, it uses the gyp program
in third_party/externals. Inside an Android tree, we need to use a
different location for gyp (the Android copy of Skia, in external/skia,
does not contain third_party/externals).
The bot handles this by importing gyp_to_android and running its main
function directly.
Add command line arguments so a human can directly run gyp_to_android.
Review URL: https://codereview.chromium.org/864503002
|
|
|
|
|
|
| |
Allows us to delete gm.
Review URL: https://codereview.chromium.org/860803004
|
|
|
|
|
|
|
|
|
|
| |
Pass command strings and offset arrays as out parameters instead of
returning new arrays from the functions.
This simplifies debugger leak investigations, as the app leaks less by
design.
Review URL: https://codereview.chromium.org/821663003
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When generating the tool makefiles, which also calls
android_framework_gyp, we also need to pass the gyp directory.
TBR=borenet
NOTRY=True
NOTREECHECKS=True
BUG=skia:3233
Review URL: https://codereview.chromium.org/804473005
|
|
|
|
|
|
|
|
|
|
|
| |
Temporary, to help diagnose skbug.com/3233
TBR=borenet
NOTRY=True
NOTREECHECKS=True
BUG=skia:3233
Review URL: https://codereview.chromium.org/802703002
|
|
|
|
|
|
|
|
| |
NOTRY=true
NOTREECHECKS=True
BUG=skia:3233
Review URL: https://codereview.chromium.org/800573002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, a function was called using dlsym in skia_launcher.
Add a static initializer that changes the setting, and include that for
the tools we automate for testing.
Also only do va_copy if we actually use it.
BUG=skia:2454
Review URL: https://codereview.chromium.org/753543003
|
|
|
|
|
|
|
|
| |
Left some notes about where we might further clean up.
BUG=skia:
Review URL: https://codereview.chromium.org/753633002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL updates various files in the includes directory to ensure that (1) they do
not depend on headers in /src and (2) that they minimize their dependence on external
headers.
To ensure that we don't regress this behavior a new build target has been added to
build a single cpp file that contains all* public includes and is compiled with
only those directories in the include path.
* The exception is those includes that depend on OS specific headers
BUG=skia:2941
NOTRY=true
Review URL: https://codereview.chromium.org/721903002
|