Change DebugCanvas API to not encourage memory leaks

Pass command strings and offset arrays as out parameters instead of
returning new arrays from the functions.

This simplifies debugger leak investigations, as the app leaks less by
design.

Review URL: https://codereview.chromium.org/821663003

1 files changed, 2 insertions, 3 deletions

diff --git a/platform_tools/nacl/src/nacl_debugger.cpp b/platform_tools/nacl/src/nacl_debugger.cpp
index b80dde0938..e7e26b8129 100644
--- a/platform_tools/nacl/src/nacl_debugger.cpp
+++ b/platform_tools/nacl/src/nacl_debugger.cpp
@@ -76,11 +76,10 @@ public:
                 picture->unref();
 
                 // Set up the command list.
-                SkTArray<SkString>* commands = fDebugger.getDrawCommandsAsStrings();
                 PostMessage("ClearCommands");
-                for (int i = 0; i < commands->count(); ++i) {
+                for (int i = 0; i < fDebugger.getSize(); ++i) {
                     SkString addCommand("AddCommand:");
-                    addCommand.append((*commands)[i]);
+                    addCommand.append(fDebugger.getDrawCommandAt(i)->toString());
                     PostMessage(addCommand.c_str());
                 }
                 PostMessage("UpdateCommands");