| Commit message (Collapse) | Author | Age |
|
|
|
|
|
| |
Allows us to delete gm.
Review URL: https://codereview.chromium.org/860803004
|
|
|
|
|
|
|
|
|
|
| |
Pass command strings and offset arrays as out parameters instead of
returning new arrays from the functions.
This simplifies debugger leak investigations, as the app leaks less by
design.
Review URL: https://codereview.chromium.org/821663003
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When generating the tool makefiles, which also calls
android_framework_gyp, we also need to pass the gyp directory.
TBR=borenet
NOTRY=True
NOTREECHECKS=True
BUG=skia:3233
Review URL: https://codereview.chromium.org/804473005
|
|
|
|
|
|
|
|
|
|
|
| |
Temporary, to help diagnose skbug.com/3233
TBR=borenet
NOTRY=True
NOTREECHECKS=True
BUG=skia:3233
Review URL: https://codereview.chromium.org/802703002
|
|
|
|
|
|
|
|
| |
NOTRY=true
NOTREECHECKS=True
BUG=skia:3233
Review URL: https://codereview.chromium.org/800573002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, a function was called using dlsym in skia_launcher.
Add a static initializer that changes the setting, and include that for
the tools we automate for testing.
Also only do va_copy if we actually use it.
BUG=skia:2454
Review URL: https://codereview.chromium.org/753543003
|
|
|
|
|
|
|
|
| |
Left some notes about where we might further clean up.
BUG=skia:
Review URL: https://codereview.chromium.org/753633002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL updates various files in the includes directory to ensure that (1) they do
not depend on headers in /src and (2) that they minimize their dependence on external
headers.
To ensure that we don't regress this behavior a new build target has been added to
build a single cpp file that contains all* public includes and is compiled with
only those directories in the include path.
* The exception is those includes that depend on OS specific headers
BUG=skia:2941
NOTRY=true
Review URL: https://codereview.chromium.org/721903002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #1 id:1 of https://codereview.chromium.org/718793003/)
> Original issue's description:
> > Move from libstlport to libc++ for Android framework builds
> >
> > Committed: https://skia.googlesource.com/skia/+/ce259510a738fab05a0d456440104f5aba1c9d72
>
> TBR=tomhudson@google.com,djsollen@google.com
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/3c3fe7ce4893204eb8bcf885e8a1d539763bca5d
TBR=tomhudson@google.com,djsollen@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/717303002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #1 id:1 of https://codereview.chromium.org/714113002/)
Reason for revert:
The code this depends on is not ready yet. We can submit once https://android-review.googlesource.com/#/c/113924/ is submitted.
Original issue's description:
> Move from libstlport to libc++ for Android framework builds
>
> Committed: https://skia.googlesource.com/skia/+/ce259510a738fab05a0d456440104f5aba1c9d72
TBR=tomhudson@google.com,djsollen@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/718793003
|
|
|
|
| |
Review URL: https://codereview.chromium.org/714113002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the generator to include a line for LOCAL_PICKUP_FILES. When
generating makefiles for our tests, they will now have the following line:
LOCAL_PICKUP_FILES := \
$(LOCAL_PATH)/../resources
This allows testing infrastructure to pick up resource files used by
our tests.
Update expectations files to test LOCAL_PICKUP_FILES.
BUG=skia:2454
Review URL: https://codereview.chromium.org/704393002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/692953002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/696463003
|
|
|
|
| |
Review URL: https://codereview.chromium.org/689943002
|
|
|
|
|
|
|
| |
This removes ADB from the Skia checkout and also does some quick
checks to make sure the version of ADB used meets a minimum threshold
Review URL: https://codereview.chromium.org/692513003
|
|
|
|
| |
Review URL: https://codereview.chromium.org/692633002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/684203002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/687603002/)
Reason for revert:
Spooky behavior on Nexus GPUs
Original issue's description:
> Update the Android NDK to r10c
>
> Committed: https://skia.googlesource.com/skia/+/a01a17b3f2f225d9499627e20f9b42ce351bd0eb
TBR=tomhudson@chromium.org,borenet@google.com,tomhudson@google.com,djsollen@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/685753003
|
|
|
|
| |
Review URL: https://codereview.chromium.org/687603002
|
|
|
|
|
|
|
|
|
|
|
| |
We have no a priori reason to limit the cache for new devices.
BUG=skia:
R=djsollen@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/556863006
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
R=djsollen@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/519743002
|
|
|
|
|
|
|
|
| |
BUG=skia:
NOTRY=true
R=djsollen@google.com
Review URL: https://codereview.chromium.org/510653004
|
|
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
BUG=skia:
R=djsollen@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/506403004
|
|
|
|
|
|
|
|
| |
R=mtklein@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/494193003
|
|
|
|
|
|
|
|
| |
R=tomhudson@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/489373004
|
|
|
|
|
|
|
|
| |
R=tomhudson@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/497503003
|
|
|
|
|
|
|
|
|
|
|
| |
We're only keeping bench_pictures around for the bots now. For human-initiated work, nanobench is the way to go.
BUG=skia:
R=djsollen@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/484663002
|
|
|
|
|
|
|
|
|
|
|
| |
Remove things related to no-longer-existing unittests, run makefile_writer_tests --rebaseline
BUG=skia:2843
R=djsollen@google.com, scroggo@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/481943002
|
|
|
|
|
|
| |
R=mtklein@google.com
Review URL: https://codereview.chromium.org/450503002
|
|
|
|
|
|
|
|
|
|
|
| |
NOTREECHECKS=true
BUG=skia:
R=djsollen@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/442343004
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
R=djsollen@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/440653004
|
|
|
|
|
|
|
|
| |
R=scroggo@google.com, bungeman@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/420803003
|
|
|
|
|
|
|
|
|
|
|
| |
R=robertphillips@google.com
TBR=robertphillips
NOTRY=true
NOTREECHECKS=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/408243003
|
|
|
|
|
|
|
|
|
|
|
| |
R=robertphillips@google.com
TBR=robertphillips
NOTRY=true
NOTREECHECKS=true
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/407163002
|
|
|
|
|
|
|
|
| |
R=jvanverth@google.com, scroggo@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/401613005
|
|
|
|
|
|
|
|
|
|
|
|
| |
Grab related shared libraryies. Remove libcorkscrew.so due libcorkscrew
is removed from AOSP.
BUG=skia:
R=djsollen@google.com
Author: qiankun.miao@intel.com
Review URL: https://codereview.chromium.org/399843002
|
|
|
|
|
|
|
|
|
|
|
|
| |
When generating Android framework makefiles, create one for
bench_pictures.
BUG=skia:2744
R=djsollen@google.com, halcanary@google.com, mtklein@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/391423002
|
|
|
|
|
|
|
|
|
| |
BUG=skia:
R=djsollen@google.com
Author: qiankun.miao@intel.com
Review URL: https://codereview.chromium.org/398733002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When generating SkUserConfig.h for Android, alphabetize the defines.
This will make one merge much harder to look at, but every following
one much easier.
R=mtklein@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/388693003
|
|
|
|
|
|
|
|
|
|
|
| |
restrictions
BUG=skia:2660
R=tomhudson@chromium.org, tomhudson@google.com
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/387893003
|
|
|
|
|
|
| |
R=borenet@google.com
Review URL: https://codereview.chromium.org/380213004
|
|
|
|
|
|
|
|
| |
This includes adding 64-bit support for arm, x86, and mips.
R=borenet@google.com
Review URL: https://codereview.chromium.org/377993002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduced in https://codereview.chromium.org/22617002, apparently
worked just fine, at least on already-set-up devices. Failing at
least since https://codereview.chromium.org/352303003/.
BUG=skia:2729
R=djsollen@google.com, tomhudson@google.com
Author: tomhudson@chromium.org
Review URL: https://codereview.chromium.org/372273003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will generate makefiles for our tools (bench, tests, gm, dm) using
the line "include $(BUILD_NATIVE_TEST)". This has been recommended by the
Android team, as it builds both 32 bit and 64 bit versions of the test.
Do not use LOCAL_MODULE_PATH, which is deprecated (see https://docs.google.com/a/google.com/document/d/1uLAuY7_KYGx1TSzJ9SXkyevT8qNpra2ZoIBkmCoq8VM/edit# ).
Corresponds to ag/498302 , which makes this change just for bench.
R=djsollen@google.com, halcanary@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/369673002
|
|
|
|
|
|
| |
R=tomhudson@google.com
Review URL: https://codereview.chromium.org/374833003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When generating tool Android.mks from gyp files, specify the name
of the target needed.
This fixes a bug where nanobench was being added to the same
makefile as bench, which would not compile.
TODO: Make gyp_to_android more general, so that it handles this
case better. See http://skbug.com/2709
R=mtklein@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/366653002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The resources directory is required by some benchmarks. Push it to
device's /data/local/tmp. Add "-i /data/local/tmp/resources" to command
line when using these resources.
BUG=skia:
R=djsollen@google.com, mtklein@google.com, borenet@google.com
Author: qiankun.miao@intel.com
Review URL: https://codereview.chromium.org/352303003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This breaks a bunch of circular dependencies between tools and gm and bench.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/4ed75287aed6371c6e4a41ffcc78c8a49c9810ed
CQ_EXTRA_TRYBOTS=tryserver.skia:Build-Mac10.7-Clang-Arm7-Debug-iOS-Trybot,Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot
R=tfarina@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/344213003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/344213003/)
Reason for revert:
GpuTimer broken
Original issue's description:
> Move BenchTimer to tools as Timer
>
> This breaks a bunch of circular dependencies between tools and gm and bench.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/4ed75287aed6371c6e4a41ffcc78c8a49c9810ed
R=tfarina@chromium.org, mtklein@chromium.org
TBR=mtklein@chromium.org, tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/346753003
|