aboutsummaryrefslogtreecommitdiffhomepage
path: root/platform_tools
Commit message (Collapse)AuthorAge
* Update Android Apps to use gradleGravatar djsollen2015-07-22
| | | | | | | | | This CL replaces ant with gradle for the task of building APKs. The primary driver of this change is that it now allow us to develop and test our apps using Android Studio. DOCS_PREVIEW= https://skia.org/?cl=1215023017 Review URL: https://codereview.chromium.org/1215023017
* Reenable yasm for Android x86 and x86-64 on Linux hostGravatar msarett2015-07-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It turns out that gyp (kind of) has support for cross compiling with a different host and target. We simply need to specify CC_host and CC_target instead of CC. Making this change allows us to compile yasm on a Linux host for Android. We run into problems on Mac because the linker on a Mac host requires different command line arguments than the linker on the Android target. In looking through the code for gyp itself and speaking to Ben, it doesn't appear to me that gyp supports passing different arguments to host and target linkers. I would imagine that we would have similar problems on Windows. Below is a link to a CL that would fix this issue in gyp. It looks like it has been dropped for a long time. Thanks to Ben for this link! https://chromiumcodereview.appspot.com/10795044/ Also I'm adding a link to the build instructions for Chrome (thanks again Ben). It looks like they only support building for Android from Linux. https://code.google.com/p/chromium/wiki/AndroidBuildInstructions My next steps are: 1) Getting in touch with Torne or someone else with gyp to see if people are aware of this issue or interested in fixing it. 2) Deciding if skia should care about this issue. 3) Deciding if skia should work around this issue. It'd be really great to hear your thoughts on (2) and (3). My first thought is that we shouldn't care because, as long as we always compile the production copy of skia for Android on Linux, we will get the fast code. Is this a valid conclusion? Is there a way to write Android apps on Mac that accidentally use the slower code? If we do care, there are workarounds: For Mac, we can check in a yasm binary - it's a little smaller than the one I am deleting in this CL :-/ For Windows, we *might* be able to use the yasm.exe binary already in externals (we get this from DEPS because this is how chromium uses yasm on Windows). Are there other platforms that we care about? Let me know what you think! BUG=skia:4028 DOCS_PREVIEW= https://skia.org/?cl=1239333002 Review URL: https://codereview.chromium.org/1239333002
* Fix for android command line arguments to VisualBenchGravatar joshualitt2015-07-15
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1241923002
* Move android_gdb_tmp into out/Gravatar scroggo2015-07-10
| | | | | | This way it will be ignored. Review URL: https://codereview.chromium.org/1230773003
* Use the upstream version of libwebp, v0.4.3.Gravatar scroggo2015-07-10
| | | | | | | | | | | | | | | | | | | DEPS: Update to pull v0.4.3 of libwebp from upstream gyp/libwebp.gyp: Add new files, as referenced by the gyp file used by Chromium. resource/tests: Add regression tests for particular images. BUG=skia:3442 BUG=skia:3315 BUG=skia:3429 Committed: https://skia.googlesource.com/skia/+/3aa0fb4d80c76b559ff4b82d5e569993aea06da1 Review URL: https://codereview.chromium.org/1178013008
* Add gradle wrappers for Android app buildsGravatar djsollen2015-07-08
| | | | | | | | These wrappers are approxiately 56K in size and are the recommened way to use Gradle. It also ensures that developers wanting to build the app don't need install an additional dependency. Review URL: https://codereview.chromium.org/1227723002
* Move visualbench to its own folderGravatar joshualitt2015-06-30
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1216973002
* Android scripts now notify gyp that your building with clangGravatar djsollen2015-06-26
| | | | Review URL: https://codereview.chromium.org/1217443004
* fix spurious init on VisualBench startupGravatar joshualitt2015-06-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1202023002
* Fixup android launch script to launch VisualBench as well as SampleAppGravatar joshualitt2015-06-22
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1185473003
* Fix for assert in VisualBenchGravatar joshualitt2015-06-19
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1198433004
* Modify android_install_app to install VisualBenchGravatar joshualitt2015-06-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1181973008
* Update android perf scriptGravatar msarett2015-06-18
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1185293006
* Visual bench on native androidGravatar joshualitt2015-06-12
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1164403002
* Print command to be executed in verbose modeGravatar djsollen2015-06-12
| | | | Review URL: https://codereview.chromium.org/1180163002
* Eliminate the check for ANDROID_LARGE_MEMORY in jpeg decodersGravatar msarett2015-06-11
| | | | | | BUG=skia:1282 Review URL: https://codereview.chromium.org/1103313002
* fix broken build by not passing the verbose flag throughGravatar Derek Sollenberger2015-06-10
| | | | Review URL: https://codereview.chromium.org/1176543004
* Remove verbose bash loggingGravatar djsollen2015-06-10
| | | | Review URL: https://codereview.chromium.org/1170283004
* Add android native_app_glue to platform_tools/android/third_partyGravatar joshualitt2015-06-09
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1175673002
* Update how we package skia resource for android testingGravatar djsollen2015-06-05
| | | | Review URL: https://codereview.chromium.org/1119283004
* Add adb_wait_for_device scriptGravatar borenet2015-06-02
| | | | | | BUG=skia:3718 Review URL: https://codereview.chromium.org/1149163003
* BUG=skia:Gravatar stephana2015-05-22
| | | | | | | NOTRY=true TBR=borenet Review URL: https://codereview.chromium.org/1153783003
* Unmount before app-installGravatar stephana2015-05-20
| | | | | | | | | TBR=borenet NOTRY=true BUG=skia: Review URL: https://codereview.chromium.org/1145093005
* This allows to restart the device.Gravatar stephana2015-05-19
| | | | | | | BUG=skia: TBR=borenet Review URL: https://codereview.chromium.org/1137873007
* Making mount more robustGravatar stephana2015-05-18
| | | | | | | BUG=skia: TBR=borenet Review URL: https://codereview.chromium.org/1131933007
* Android scripts: add --verbose, fix missing 'source android_setup'Gravatar borenet2015-05-14
| | | | | | | BUG=skia:3836 TBR=djsollen Review URL: https://codereview.chromium.org/1145473002
* Add android_launch_app script to allow command line options to be passed to ↵Gravatar Derek Sollenberger2015-05-11
| | | | | | | | | | the sampleApp when starting. BUG=skia:3815 DOCS_PREVIEW= https://skia.org/?cl=1136753003 R=bungeman@google.com, tomhudson@google.com Review URL: https://codereview.chromium.org/1136753003
* Add default resourcePath to SampleApp on Android.Gravatar bungeman2015-05-07
| | | | | | | | | | | Currently SampleApp on Android cannot find resources. This sets the resourcePath to /data/local/tmp/skia/resources/ which is the path used in documentationo. A future change will allow this default to be overridden. BUG=skia:3815 Review URL: https://codereview.chromium.org/1125363004
* cleanupGravatar stephana2015-05-05
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1085583006
* Support SKIA_OUT on Mac and ChromeOSGravatar borenet2015-05-04
| | | | | | BUG=skia:3774 Review URL: https://codereview.chromium.org/1122593003
* Make Skia for Android libjpeg use ashmemGravatar msarett2015-04-27
| | | | | | BUG=skia:1282 Review URL: https://codereview.chromium.org/1108013002
* Default to arm_v7_neon.Gravatar mtklein2015-04-21
| | | | | | | | This aliases all devices we know have NEON over to that too. BUG=skia: Review URL: https://codereview.chromium.org/1095953007
* Android's Clang toolchain can't assemble the JPEG's .S files.Gravatar mtklein2015-04-21
| | | | | | | | Only affecting Build-Mac10.8-Clang-Arm7-Debug-Android. BUG=skia: Review URL: https://codereview.chromium.org/1093423003
* Landing directly for testing the ios buildbot code.Gravatar stephana2015-04-21
| | | | | | | BUG=skia: TBR=borenet Review URL: https://codereview.chromium.org/1087653005
* Fail gracefully when dm.json is not presentGravatar Derek Sollenberger2015-04-08
| | | | Review URL: https://codereview.chromium.org/1073593002
* Try ARMv7 and NEON for Daisy.Gravatar mtklein2015-04-03
| | | | | | | | | | | | | I think Daisy's color order problems are in non-NEON ARM assembly. NEON might actually be fine. BUG=skia:1843 Committed: https://skia.googlesource.com/skia/+/a121c0ee6b911dd7004c6054a8692d37084b6b3d CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-Arm7-Debug-CrOS_Daisy-Trybot,Build-Ubuntu-GCC-Arm7-Debug-Android_Neon-Trybot,Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot,Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot Review URL: https://codereview.chromium.org/1054233002
* Revert of Try ARMv7 and NEON for Daisy. (patchset #1 id:1 of ↵Gravatar mtklein2015-04-02
| | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1054233002/) Reason for revert: whatever compiler we're using can't handle array subscripts for neon vectors Original issue's description: > Try ARMv7 and NEON for Daisy. > > I think Daisy's color order problems are in non-NEON ARM assembly. > NEON might actually be fine. > > BUG=skia:1843 > > Committed: https://skia.googlesource.com/skia/+/a121c0ee6b911dd7004c6054a8692d37084b6b3d TBR=mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:1843 Review URL: https://codereview.chromium.org/1058173002
* Try ARMv7 and NEON for Daisy.Gravatar Mike Klein2015-04-02
| | | | | | | | | I think Daisy's color order problems are in non-NEON ARM assembly. NEON might actually be fine. BUG=skia:1843 Review URL: https://codereview.chromium.org/1054233002
* back to plain arm for the nightGravatar Mike Klein2015-04-02
| | | | | | | | | | It's looking like the previous CL did not fix the Daisy bot GMs, even though that's still the only bit of code I can find that was ignoring color order. Puzzled. Reverting arm_version=7 for now. BUG=skia:1843 Review URL: https://codereview.chromium.org/1051423002
* Remove all code related to NaClGravatar borenet2015-04-02
| | | | | | | BUG=skia:3600 DOCS_PREVIEW= https://skia.org/?cl=1036283002 Review URL: https://codereview.chromium.org/1036283002
* Streamline Thumb config.Gravatar mtklein2015-04-02
| | | | | | | | Enable Thumb2 iff ARM v7. (We don't turn it on today for ARM <v7, and ARM v8 doesn't support it.) BUG=skia: Review URL: https://codereview.chromium.org/1054993002
* Make Daisy ARMv7.Gravatar mtklein2015-04-02
| | | | | | | | | This should be a ~noop as far as gold.skia.org goes. After this, I'll try out NEON. BUG=skia:1843 Review URL: https://codereview.chromium.org/1056793004
* tidy up chromeos_setup.shGravatar mtklein2015-04-02
| | | | | | | | | | | | | | | | | | | | | | | | - remove unused alex - streamline Link's config - remove misleading Daisy config: 1) armv7=1 does nothing. We meant to type arm_version=7 here. 2) arm_neon=1 does nothing unless arm_version == 7. 3) arm_thumb=0 is the default when arm_version <= 7. 4) skia_arch_width=32 is the default when skia_arch_type=arm. I'd just fix this to make Daisy arm_version=7 and arm_neon=1 (and arm_thumb=1, which I'm going to separately make the default for arm_version=7), but there are known color-order bugs with our NEON procs that would make Daisy start pushing bad images to Gold. Going to take baby steps here... BUG=skia:1843 Committed: https://skia.googlesource.com/skia/+/3c2809bc612f4a265770914f860d214c9665dc4a CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-Arm7-Debug-CrOS_Daisy-Trybot Review URL: https://codereview.chromium.org/1051253002
* Revert of tidy up chromeos_setup.sh (patchset #1 id:1 of ↵Gravatar mtklein2015-04-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1051253002/) Reason for revert: arm_thumb not defined Original issue's description: > tidy up chromeos_setup.sh > > - remove unused alex > - streamline Link's config > - remove misleading Daisy config: > 1) armv7=1 does nothing. We meant to type arm_version=7 here. > 2) arm_neon=1 does nothing unless arm_version == 7. > 3) arm_thumb=0 is the default when arm_version <= 7. > 4) skia_arch_width=32 is the default when skia_arch_type=arm. > > I'd just fix this to make Daisy arm_version=7 and arm_neon=1 (and > arm_thumb=1, which I'm going to separately make the default for > arm_version=7), but there are known color-order bugs with our > NEON procs that would make Daisy start pushing bad images to > Gold. Going to take baby steps here... > > BUG=skia:1843 > > Committed: https://skia.googlesource.com/skia/+/3c2809bc612f4a265770914f860d214c9665dc4a TBR=borenet@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:1843 Review URL: https://codereview.chromium.org/1059443002
* tidy up chromeos_setup.shGravatar mtklein2015-04-02
| | | | | | | | | | | | | | | | | | | | - remove unused alex - streamline Link's config - remove misleading Daisy config: 1) armv7=1 does nothing. We meant to type arm_version=7 here. 2) arm_neon=1 does nothing unless arm_version == 7. 3) arm_thumb=0 is the default when arm_version <= 7. 4) skia_arch_width=32 is the default when skia_arch_type=arm. I'd just fix this to make Daisy arm_version=7 and arm_neon=1 (and arm_thumb=1, which I'm going to separately make the default for arm_version=7), but there are known color-order bugs with our NEON procs that would make Daisy start pushing bad images to Gold. Going to take baby steps here... BUG=skia:1843 Review URL: https://codereview.chromium.org/1051253002
* Update the Android scripts to refresh device names and capabilities.Gravatar djsollen2015-04-01
| | | | Review URL: https://codereview.chromium.org/1054633002
* WIP: Added support for giflib, updated jpeg and pngGravatar msarett2015-03-30
| | | | | | | | BUG=skia:3257 Committed: https://skia.googlesource.com/skia/+/255dcd11992ebe74eb54202c48cf5394d33a8ce6 Review URL: https://codereview.chromium.org/1038863003
* Revert of WIP: Added support for giflib, updated jpeg and png (patchset #8 ↵Gravatar borenet2015-03-30
| | | | | | | | | | | | | | | | | | | | | | id:260001 of https://codereview.chromium.org/1038863003/) Reason for revert: Trying out revert to see if it fixes Android bots. Original issue's description: > WIP: Added support for giflib, updated jpeg and png > > BUG=skia:3257 > > Committed: https://skia.googlesource.com/skia/+/255dcd11992ebe74eb54202c48cf5394d33a8ce6 TBR=djsollen@google.com,scroggo@google.com,msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3257 Review URL: https://codereview.chromium.org/1048713003
* WIP: Added support for giflib, updated jpeg and pngGravatar msarett2015-03-27
| | | | | | BUG=skia:3257 Review URL: https://codereview.chromium.org/1038863003
* Fix android_run_skia script to allow for larger blacklistGravatar msarett2015-03-25
| | | | | | BUG=skia: Review URL: https://codereview.chromium.org/1011653004