aboutsummaryrefslogtreecommitdiffhomepage
path: root/platform_tools
diff options
context:
space:
mode:
authorGravatar joshualitt <joshualitt@chromium.org>2015-07-15 10:17:20 -0700
committerGravatar Commit bot <commit-bot@chromium.org>2015-07-15 10:17:21 -0700
commitdcd56e2f0e1bd31f260d19873be485340b66f096 (patch)
treec9b977fe8aa8b67932060ea040996374b0ac5472 /platform_tools
parenteeb8d99b4e58eb95cad3f7cd5438b9c2b3db7141 (diff)
Fix for android command line arguments to VisualBench
Diffstat (limited to 'platform_tools')
-rwxr-xr-xplatform_tools/android/bin/android_launch_app2
-rw-r--r--platform_tools/android/visualbench/jni/main.cpp1
2 files changed, 1 insertions, 2 deletions
diff --git a/platform_tools/android/bin/android_launch_app b/platform_tools/android/bin/android_launch_app
index 53b00e9023..3eddf3547e 100755
--- a/platform_tools/android/bin/android_launch_app
+++ b/platform_tools/android/bin/android_launch_app
@@ -21,7 +21,7 @@ fi
if [[ ${app} == 'SampleApp' ]]; then
$ADB ${DEVICE_SERIAL} shell am start -S -n "com.skia/.SkiaSampleActivity" --es "cmdLineFlags" "${APP_ARGS[*]:1}"
elif [[ ${app} == "VisualBench" ]] ; then
- $ADB ${DEVICE_SERIAL} shell am start -S -n "com.skia/.VisualBenchActivity" --es "cmdLineFlags" "${APP_ARGS[*]:1}"
+ $ADB ${DEVICE_SERIAL} shell am start -S -n "com.skia/.VisualBenchActivity" --es "cmdLineFlags" \"${APP_ARGS[*]:1}\"
else
echo "ERROR: supports either 'SampleApp' or 'VisualBench' as valid apps"
fi
diff --git a/platform_tools/android/visualbench/jni/main.cpp b/platform_tools/android/visualbench/jni/main.cpp
index 3d7ceab9eb..2ea6b76b39 100644
--- a/platform_tools/android/visualbench/jni/main.cpp
+++ b/platform_tools/android/visualbench/jni/main.cpp
@@ -90,7 +90,6 @@ void android_main(struct android_app* state) {
env->NewStringUTF("cmdLineFlags"));
if (jsParam1) {
const char* flags = env->GetStringUTFChars(jsParam1, 0);
- SkTArray<SkString> flagEntries;
SkStrSplit(flags, " ", &visualBenchState.fFlags);
env->ReleaseStringUTFChars(jsParam1, flags);
}