aboutsummaryrefslogtreecommitdiffhomepage
path: root/infra/bots/recipe_modules/flavor/gn_android_flavor.py
Commit message (Collapse)AuthorAge
* [recipes] Rename some modules and filesGravatar Eric Boren2018-05-24
| | | | | | | | | | | | | | | - Move doxygen and binary size out of core and into their own modules. - Rename core -> checkout since that's all it does, shorten method names. - Rename flavors: - Everything is GN, so remove GN/gn_ everywhere. - Merge gn_flavor into default. - Shorten file / module names. Bug: skia:6473 Change-Id: I8ac9ff9c9a267f366206b9991adfa5eb37126ca7 Reviewed-on: https://skia-review.googlesource.com/129176 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Make ASAN setup of Android bots more fault tolerantGravatar Kevin Lubick2018-05-21
| | | | | | | | Bug: skia:7975 Change-Id: I3f123337913870a921d1c09714873eaf2949e88f Reviewed-on: https://skia-review.googlesource.com/129364 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* [recipes] Move a lot of logic out of vars moduleGravatar Eric Boren2018-05-18
| | | | | | | | | | | | | In general, vars should only contain variables which are the same for all tasks. Variables specific to compilation belong in the build module (or compile recipe), and those specific to running tests belong in the flavor module, or the individual recipe which uses them. Bug: skia:6473 Change-Id: Ifd55a57118c5801e6f4934a6b5de9d1567415b9a Reviewed-on: https://skia-review.googlesource.com/128545 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com>
* Specify the ADB keys to use for ADBGravatar Kevin Lubick2018-05-17
| | | | | | | | | | | | | | | In the golo, specifically, the adb keys used by swarming are different than those used in the docker instance, unless configured otherwise. This means swarming can think a device is ready (authorized) but the adb we called was not (authorized) BUG: 843284 Change-Id: I697d5075258a176e7fc7a4b51a9e2c926e1b8fd0 Reviewed-on: https://skia-review.googlesource.com/128930 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* asan_device_setup has movedGravatar Mike Klein2018-05-14
| | | | | | | Change-Id: I9d9d34f1b663a06605eddeacd945517c3e880f4f Reviewed-on: https://skia-review.googlesource.com/128016 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* [recipes] Separate build and test flavorsGravatar Eric Boren2018-05-14
| | | | | | | | Bug: skia:6473 Change-Id: If1d6e1f64ec53624e7b540abd9d8a61cc82c4e0a Reviewed-on: https://skia-review.googlesource.com/125947 Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* [recipes] Add toolchain version to extra_cflags.Gravatar Ben Wagner2018-03-20
| | | | | | | | | | | | | In compile recipes, add a dummy define (e.g. -DDUMMY_clang_linux_version=42) to the compiler flags so that ninja will recompile from scratch when the toolchain changes. Bug: skia:7720 Change-Id: I9a330b21af364b3aa6a1eebbe6ac2022cfa82fdc Reviewed-on: https://skia-review.googlesource.com/115160 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Revert "Scale the GPU when running perf on Pixel(2)"Gravatar Ravi Mistry2018-03-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit aa504cddb9196a3f5e798a280061ba6eb3c22901. Reason for revert: Kevin asked me to revert since this broke things Original change's description: > Scale the GPU when running perf on Pixel(2) > > This is a similar followup to: > https://skia-review.googlesource.com/c/skia/+/93561 > > Bug: skia: > Change-Id: I9b11dbf3d063fd64b1dd712cf1c596618f2c9ffc > Reviewed-on: https://skia-review.googlesource.com/114340 > Reviewed-by: Eric Boren <borenet@google.com> > Commit-Queue: Kevin Lubick <kjlubick@google.com> TBR=borenet@google.com,kjlubick@google.com Change-Id: Idbc7234f2b7ff8c5e632680903836e1f4eaa50d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/114425 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Scale the GPU when running perf on Pixel(2)Gravatar Kevin Lubick2018-03-14
| | | | | | | | | | | This is a similar followup to: https://skia-review.googlesource.com/c/skia/+/93561 Bug: skia: Change-Id: I9b11dbf3d063fd64b1dd712cf1c596618f2c9ffc Reviewed-on: https://skia-review.googlesource.com/114340 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Test SKQP on Firebase Testlab and UploadGravatar Stephan Altmueller2018-03-07
| | | | | | | | | | | | | | - adds building the testlab driver (run_testlab) as a separate step - adds gcloud isolate necessary to run testlab - adds Testlab support and uploading a verified AKP to GCS (with meta data attached). Bug: skia: Change-Id: I1bf265f46c99360eb3a9eb684886f93de48085fe Reviewed-on: https://skia-review.googlesource.com/111603 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
* Change force_quarantine to use bot idGravatar Kevin Lubick2018-03-01
| | | | | | | | Bug: skia:7639 Change-Id: I4b8337bac996062c41fb9ae7460cf214b7524a46 Reviewed-on: https://skia-review.googlesource.com/111300 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Remove SkQP bot from masterGravatar Stephan Altmueller2018-02-22
| | | | | | | | Bug: skia: Change-Id: I0415690911a52059eaaf7f32c81b7a4c66117d5b Reviewed-on: https://skia-review.googlesource.com/109162 Commit-Queue: Stephan Altmueller <stephana@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Add SKQP bot to build universal APK to masterGravatar Stephan Altmueller2018-02-20
| | | | | | | | Bug: skia: Change-Id: Ib0e9ddb621056ddce2422b53f312ec42d4d7aa3c Reviewed-on: https://skia-review.googlesource.com/107880 Commit-Queue: Stephan Altmueller <stephana@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Revert "Increase ninja thread count for Android build on Linux."Gravatar Stephan Altmueller2018-02-20
| | | | | | | | | | | | | | | also Revert "Increase ninja thread count for Windows builds." This reverts commit 98c4231592bfadbe92d906f707d28508c50b0c16. This reverts commit 50a808a518c895c956c6d30d07e1e81e5e7abddb. Bug: skia: Change-Id: I7cc50b0bec6e1ad9f9d971a5c88c029488bb80ed Reviewed-on: https://skia-review.googlesource.com/108504 Reviewed-by: Stephan Altmueller <stephana@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Stephan Altmueller <stephana@google.com>
* Increase ninja thread count for Android build on Linux.Gravatar Ben Wagner2018-02-15
| | | | | | | Change-Id: Ib637360e2f09cd2851771595590203da6195a314 Reviewed-on: https://skia-review.googlesource.com/107600 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* target Android M for -arm- ASAN buildsGravatar Mike Klein2018-01-30
| | | | | | | Change-Id: I8154b9a0b2fcf76fa02af0efa6b57425c6f9ac31 Reviewed-on: https://skia-review.googlesource.com/101580 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add Android ASAN botGravatar Kevin Lubick2018-01-12
| | | | | | | | | | | It should work on 32 and 64 bit android running M or newer. Bug: skia: Change-Id: I7e6d4000f4fee8f2704b84b7174174dd0e68d21c Reviewed-on: https://skia-review.googlesource.com/93700 Reviewed-by: Mike Klein <mtklein@chromium.org> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* [recipes] Define variables in __init__Gravatar Eric Boren2018-01-12
| | | | | | | | | | This may fix weird races in tests. Bug: skia: Change-Id: I41c36424c7b559301e915a0892590c74931ae463 Reviewed-on: https://skia-review.googlesource.com/93942 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Trying gpu scaling on Nexus 5 and 5xGravatar Kevin Lubick2018-01-11
| | | | | | | | | | We do some of this already in skpbench. Bug: skia: Change-Id: Ia698466e83f9b476644c126747a2f89346361d13 Reviewed-on: https://skia-review.googlesource.com/93561 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Fix absolute path for recipesGravatar Kevin Lubick2018-01-04
| | | | | | | | Bug: skia: Change-Id: I42c528d86f19d369609b26763334e055501a9b9b Reviewed-on: https://skia-review.googlesource.com/90880 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Quarantine android bots instead of shutting off deviceGravatar Kevin Lubick2017-12-22
| | | | | | | | | | | | | | This should make it easier to diagnose and remotely fix the devices/hosts. Only works because of https://chrome-internal-review.googlesource.com/c/infradata/config/+/535542 Bug: skia: Change-Id: Idf11a09da6c7367212a0ac0b0b959cbf49fed85b Reviewed-on: https://skia-review.googlesource.com/89181 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>
* Make sure we get the LITTLE cores out of powersaveGravatar Kevin Lubick2017-12-19
| | | | | | | | | Bug: skia:7420 NOTRY=true Change-Id: I785135a3abc17f63d715d459668c768a6014d9b3 Reviewed-on: https://skia-review.googlesource.com/87001 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Revert "Revert "Disable extra CPUs during Nanobench""Gravatar Kevin Lubick2017-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 43307c09b97c5a5c5174f0c4ccb79bdaf3ebf557. Reason for revert: Fixed this time. Echo 1 > already online cpu returns exit code 1, which makes python over-react. Original change's description: > Revert "Disable extra CPUs during Nanobench" > > This reverts commit 32af335e7abbf562dad8f1bd21bb013610b8b021. > > Reason for revert: many unhappy android bots > > Original change's description: > > Disable extra CPUs during Nanobench > > > > The previous experiment revealed that nanobench can > > run on any of the online CPUs, so rather than put > > the ones we don't need/want into powersave mode, just > > disable them. > > > > Maybe in the future we can run CPU tests on the big > > or LITTLE cpus to get perf data on higher end or > > lower end cpus, but only if we get very stable > > results from this. > > > > Bug: skia:7378 > > Change-Id: I057513a691093e7f73c0f5790e17fab1a5ec0bc4 > > Reviewed-on: https://skia-review.googlesource.com/84820 > > Reviewed-by: Kevin Lubick <kjlubick@google.com> > > Commit-Queue: Kevin Lubick <kjlubick@google.com> > > TBR=borenet@google.com,mtklein@google.com,kjlubick@google.com > > Change-Id: I23c37a6bde631e95f0b4ae7277ec8fcf325a00e9 > Bug: skia:7378 > Reviewed-on: https://skia-review.googlesource.com/84921 > Reviewed-by: Mike Klein <mtklein@google.com> > Commit-Queue: Mike Klein <mtklein@google.com> No-Tree-Checks: true Change-Id: Ie7f0a3dc6ba55c124c796aba16a0f0497f285f3a Bug: skia:7378 Reviewed-on: https://skia-review.googlesource.com/84865 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Revert "Disable extra CPUs during Nanobench"Gravatar Mike Klein2017-12-14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 32af335e7abbf562dad8f1bd21bb013610b8b021. Reason for revert: many unhappy android bots Original change's description: > Disable extra CPUs during Nanobench > > The previous experiment revealed that nanobench can > run on any of the online CPUs, so rather than put > the ones we don't need/want into powersave mode, just > disable them. > > Maybe in the future we can run CPU tests on the big > or LITTLE cpus to get perf data on higher end or > lower end cpus, but only if we get very stable > results from this. > > Bug: skia:7378 > notry=true > notreechecks=true > Change-Id: I057513a691093e7f73c0f5790e17fab1a5ec0bc4 > Reviewed-on: https://skia-review.googlesource.com/84820 > Reviewed-by: Kevin Lubick <kjlubick@google.com> > Commit-Queue: Kevin Lubick <kjlubick@google.com> TBR=borenet@google.com,mtklein@google.com,kjlubick@google.com Change-Id: I23c37a6bde631e95f0b4ae7277ec8fcf325a00e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:7378 Reviewed-on: https://skia-review.googlesource.com/84921 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Disable extra CPUs during NanobenchGravatar Kevin Lubick2017-12-14
| | | | | | | | | | | | | | | | | | | | The previous experiment revealed that nanobench can run on any of the online CPUs, so rather than put the ones we don't need/want into powersave mode, just disable them. Maybe in the future we can run CPU tests on the big or LITTLE cpus to get perf data on higher end or lower end cpus, but only if we get very stable results from this. Bug: skia:7378 notry=true notreechecks=true Change-Id: I057513a691093e7f73c0f5790e17fab1a5ec0bc4 Reviewed-on: https://skia-review.googlesource.com/84820 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* [recipes] Provide tokenized extra_config and use it most places.Gravatar Ben Wagner2017-12-13
| | | | | | | Change-Id: I7baae5f90b2e510b66443cda449071c7c6ec9ec7 Reviewed-on: https://skia-review.googlesource.com/83520 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Experiment with turning CPUs off during perfGravatar Kevin Lubick2017-12-13
| | | | | | | | | | | | | | | | | | | | | | | Perf was nice and flat after https://skia-review.googlesource.com/c/skia/+/83240 but there was a 4-5x slowdown on the benchmarks themselves, indicating that perhaps we were running nanobench on the LITTLE cores (now on powersave) instead of the big cores we thought (which were recently scaled down). This experiment will show us FOR CERTAIN that we are running on core 0 or 1 which is at .6 max frequency. We expect to see a speedup from the previous results. This is leading to turning of CPUs we don't need to make sure nanobench is running on the ones we expect. Bug: skia: NOTRY=true Change-Id: Ida65181e4d90e778e65e3f22d761288b9ade64f6 Reviewed-on: https://skia-review.googlesource.com/84201 Reviewed-by: Mike Klein <mtklein@chromium.org> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Fix scaling logic for NexusPlayer and AndroidOneGravatar Kevin Lubick2017-12-12
| | | | | | | | | | | | They seem to be their own special cases for what governors they support. Bug: skia: NOTRY=true Change-Id: I7bb220e1d3ba6851c17c7e6ef327aab24ffdba42 Reviewed-on: https://skia-review.googlesource.com/83900 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Scale extra CPUs to powersave during nanobench.Gravatar Kevin Lubick2017-12-12
| | | | | | | | | | | | | | | | | | | | | | | | This scaling logic correctly accounts for some devices which have multiple CPUs. Previously, we were scaling the smaller of these CPUs, which likely had a negative impact on nanobench, given nanobench was single threaded and the CPUs weren't allowed to idle much (because we set the CPU). This CL sets those additional CPUs to powersave when we run nanobench and then correctly scales down the beefier CPU we want to run nanobench on. For DM, we just run it in ondemand mode, which will hopefully be "as fast as possible", but allow the CPU governor to scale down if overheating becomes a problem. Bug: skia:7378 notry=TRUE Change-Id: I45ca5d9fb32182233d1b2d094842c879f2b84da4 Reviewed-on: https://skia-review.googlesource.com/83240 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Remove Nexus10.Gravatar Ben Wagner2017-12-08
| | | | | | | | | Bug: skia:7381 Change-Id: I8e151c5c57f6344c9cdf165bbb78a4ed308491c8 NoTry: true Reviewed-on: https://skia-review.googlesource.com/82804 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Fix scaling issues for some devices (e.g. Pixel)Gravatar Kevin Lubick2017-12-08
| | | | | | | | | Bug: skia: NOTRY=true Change-Id: Ia6a80ecb97b5d30197932ec7d340163624e315bd Reviewed-on: https://skia-review.googlesource.com/82682 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Use full paths for adbGravatar Kevin Lubick2017-12-07
| | | | | | | | | | Add logic to run on Nexus 5xs in Golo. Bug:788839 Change-Id: I12290d11a0b1b0f012ada216da3e5b2599979c5e Reviewed-on: https://skia-review.googlesource.com/81861 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Don't set min frequency for Android devicesGravatar Kevin Lubick2017-12-05
| | | | | | | | | | Bug: skia:7378 NOTRY=true No-Tree-Checks: true Change-Id: Iaacbc8eadaa4da9832a53d4794a2214625bef9b6 Reviewed-on: https://skia-review.googlesource.com/80842 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Turn up Nexus10 CPU frequenciesGravatar Kevin Lubick2017-11-30
| | | | | | | | | | | | | | | | | | | | | The previous list was created from scaling_min_freq and scaling_max_freq instead of cpuinfo_min_freq and cpuinfo_max_freq which are the actual mins and maxes, not the current (transient) settings of the governor. Before: Test-Release: 61 minutes Perf-Debug: 41 minutes After: Test-Release: 32 minutes Perf-Debug: 16 minutes NOTRY=true Bug: skia: Change-Id: I9b431e92d2abcecb4fe643389daddc912a1399e1 Reviewed-on: https://skia-review.googlesource.com/78141 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Make cpu scaling more robustGravatar Kevin Lubick2017-11-30
| | | | | | | | | | | | | | | | | | Some bots, especially the Nexus 7s, seemed to occasionally fail when setting the CPU frequency. I was unable to repro this behavior, so this is a shotgun approach. We add a 5 second delay between setting and checking, checking frequency using scaling_cur_freq instead of scaling_setspeed, set the min_freq as well as max_freq, and retry up to 3 times if setting cpu frequency fails. NOTRY=true Bug: skia: Change-Id: Id4d85d8d509c9dba8e3a0e06b5992f5adadf36d2 Reviewed-on: https://skia-review.googlesource.com/78140 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Don't scale CPU for internal botsGravatar Kevin Lubick2017-11-28
| | | | | | | | | | | | For internal hardware, it tends not to work - they work at one clock speed, despite advertising others. Bug: skia: NOTRY=true Change-Id: I10bf0fc1ab4d60bfbc2eefcef5b42ceab9e3f435 Reviewed-on: https://skia-review.googlesource.com/76720 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Fix scaling on Nexus 7 botsGravatar Kevin Lubick2017-11-22
| | | | | | | | | | Bug: skia: NOTRY=true Change-Id: I1a1755dd03f2e6ebd8d9b2c9235cca8eb34f04ad Reviewed-on: https://skia-review.googlesource.com/75280 Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Make CPU scaling code cleanerGravatar Kevin Lubick2017-11-21
| | | | | | | | | | | | | | | | | This also makes *sure* the CPU frequency we set the device to actually "takes". Along the way, I learned if scaling_max_freq is < the frequency we set, the scaling_max_freq will be used instead, which was happening to the PixelCs and AndroidOnes. As a result, this may make those two Test- configs faster. Bug: skia: Change-Id: I10c98d37e296a19e1cf67bfe7269bb59cdd912d5 Reviewed-on: https://skia-review.googlesource.com/74360 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Put CPU frequency scaling in recipesGravatar Kevin Lubick2017-11-20
| | | | | | | | Bug: skia: Change-Id: I994f67c3043306d7fa612feb03f8fbe8d7bf4c91 Reviewed-on: https://skia-review.googlesource.com/73760 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* pass -k 0 to ninjaGravatar Mike Klein2017-11-06
| | | | | | | | | | This makes failing builds print all failures, not just the first. Successful builds, the usual case, are unaffected. Change-Id: I8dde21e913f6715e7760b298a87f51d1b40a8789 Reviewed-on: https://skia-review.googlesource.com/67803 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Fix asset version detectionGravatar Kevin Lubick2017-10-13
| | | | | | | | | | | | | | Since we went to retrying the adb commands, the return value got lost, which was used to read the SKP_VERSIOn, etc. This fixes it. Bug: skia: NOTRY=true Change-Id: Ifc61ec4cbb13a61c571b2fb89a9c0ed215f8fbd3 Reviewed-on: https://skia-review.googlesource.com/59441 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Update to adb 1.0.35Gravatar Kevin Lubick2017-10-12
| | | | | | | | | | | | | | | | | | | | | | | | The newer adb acts more like cp when pulling. We used to create the dm folder on the host machine before pulling. This used to be fine, /device/dm_out/dm.json -> /host/dm/dm.json However, with the update, adb would do /device/dm_out/dm.json -> /host/dm/dm_out/dm.json This breaks the upload step. To make this transition a smooth one, /usr/bin/adb on the RPI is staying the same (for a while, at least) and /usr/bin/adb.1.0.35 is being added. That way we can use the new adb on tests after this commit, but when we backfill, we don't break because of the unexpected folder. Bug: skia: Change-Id: Icbed38594fca0e17af1f8d01d75c42ce03f710b9 Reviewed-on: https://skia-review.googlesource.com/58880 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Simpler version of wait-for-device.Gravatar Ben Wagner2017-09-12
| | | | | | | | | | This is a followup to https://skia-review.googlesource.com/43564 No-Try: true Change-Id: I4bc2a24fe08e6b07f5512e3a1e03eac7e3397155 Reviewed-on: https://skia-review.googlesource.com/45120 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Retry adb commands on flaky devices.Gravatar Ben Wagner2017-09-11
| | | | | | | | No-Try: true Change-Id: I3519131cf064d0a9676abd0fb9d7e946646ce27f Reviewed-on: https://skia-review.googlesource.com/43564 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add new Android builder which uses API_LEVEL 26Gravatar Eric Boren2017-07-20
| | | | | | | | Bug: skia:6870 Change-Id: Idd9a27518c1123c0a729b4d07461047f5530aae3 Reviewed-on: https://skia-review.googlesource.com/24960 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Stop adding Android-specific defines to SkUserConfigGravatar Leon Scroggins III2017-07-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove #defines that lived in gn_to_bp.py and android_framework_defines.gni. These have been moved into a new file in Android, SkUserConfigManual.h, in https://googleplex-android-review.git.corp.google.com/#/c/2519600/ Update gn_to_bp.py to include SkUserConfigManual.h, so it will still result in using the same #defines. Lately, we've found it difficult to guard changes behind a flag. e.g. a change to drawing causes a CTS failure in Android, so we have to do the following: - put the change behind a flag, and add it to gn_to_bp.py or android_framework_defines.gni - generate new images on Android (by running CTS with external/skia modified to not define the flag) - create a CL in CTS that uses the new images - land a CL in Skia that stops defining the flag - when the Skia change lands, wait for the auto-roller to create a CL that includes the change, stop the auto-roller, add the topic to the CTS CL so the two can land at the same time - land both Android changes (with TreeHugger) - restart the Android auto-roller With SkUserConfigManual.h (which lives in Android), the process will be similar to Chromium: - land a CL in Android's external/skia that defines a flag e.g. SK_SUPPORT_LEGACY_FEATURE. Land without TreeHugger because it isn't used in Skia and does not do anything - land a change in Skia that changes behavior unless SK_SUPPORT_LEGACY_FEATURE is defined. This will safely go through the Android roll and not change any behavior for Android - create two Android CLs - one in CTS to use the new images, and one in external/skia to delete SK_SUPPORT_LEGACY_FEATURE. Set them to the same topic and land them with TreeHugger In the new process, there is no need to mess with the Android roll. A downside to the new process is that we cannot test the android framework defines without checking in to Android. But given how much we've progressed in automating Android testing, this is fine. Bug: b/63429612 Change-Id: Idfbaef2f4cae641a75fb6e7bf70428733a441336 Reviewed-on: https://skia-review.googlesource.com/22072 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* [skia] convert recipes and module to new context moduleGravatar Robert Iannucci2017-05-15
| | | | | | | | | | | | | This is a syntax-only change to convert to the new (documented) context module. R=borenet@google.com Bug: skia: Change-Id: Id907c309d3cf38b85a46f6d8d7ce90ed58ba026f Reviewed-on: https://skia-review.googlesource.com/16840 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Don't reboot Pixel C or Nexus Player before taskGravatar Kevin Lubick2017-04-27
| | | | | | | | | | | | | We reboot this after in swarming with real adb, so this is unnecessary and could, in fact, be harmful. Bug: skia:6559 NOTRY=true Change-Id: Iaf58416994637111c02013fe3c83f4ac92de2a66 Reviewed-on: https://skia-review.googlesource.com/14526 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* [recipes] Fix *_VERSION step failure handlingGravatar Eric Boren2017-04-24
| | | | | | | | | | Bug: skia:6473 Change-Id: I2fa6f800f59f40f74b5c080c52cdec3a32329ef7 NOTRY=true Reviewed-on: https://skia-review.googlesource.com/14240 Commit-Queue: Stephan Altmueller <stephana@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Stephan Altmueller <stephana@google.com>
* Reland Recipes: Use strict coverage, part 2Gravatar Eric Boren2017-04-19
| | | | | | | | Bug: skia:6473 Change-Id: I90c1c3a3108ce583df60933150d97b426173a315 Reviewed-on: https://skia-review.googlesource.com/13840 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-10-05 12:06:37 +0000