aboutsummaryrefslogtreecommitdiffhomepage
path: root/infra/bots/recipe_modules/flavor/gn_android_flavor.py
Commit message (Collapse)AuthorAge
* Scale extra CPUs to powersave during nanobench.Gravatar Kevin Lubick2017-12-12
| | | | | | | | | | | | | | | | | | | | | | | | This scaling logic correctly accounts for some devices which have multiple CPUs. Previously, we were scaling the smaller of these CPUs, which likely had a negative impact on nanobench, given nanobench was single threaded and the CPUs weren't allowed to idle much (because we set the CPU). This CL sets those additional CPUs to powersave when we run nanobench and then correctly scales down the beefier CPU we want to run nanobench on. For DM, we just run it in ondemand mode, which will hopefully be "as fast as possible", but allow the CPU governor to scale down if overheating becomes a problem. Bug: skia:7378 notry=TRUE Change-Id: I45ca5d9fb32182233d1b2d094842c879f2b84da4 Reviewed-on: https://skia-review.googlesource.com/83240 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Remove Nexus10.Gravatar Ben Wagner2017-12-08
| | | | | | | | | Bug: skia:7381 Change-Id: I8e151c5c57f6344c9cdf165bbb78a4ed308491c8 NoTry: true Reviewed-on: https://skia-review.googlesource.com/82804 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Fix scaling issues for some devices (e.g. Pixel)Gravatar Kevin Lubick2017-12-08
| | | | | | | | | Bug: skia: NOTRY=true Change-Id: Ia6a80ecb97b5d30197932ec7d340163624e315bd Reviewed-on: https://skia-review.googlesource.com/82682 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Use full paths for adbGravatar Kevin Lubick2017-12-07
| | | | | | | | | | Add logic to run on Nexus 5xs in Golo. Bug:788839 Change-Id: I12290d11a0b1b0f012ada216da3e5b2599979c5e Reviewed-on: https://skia-review.googlesource.com/81861 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Don't set min frequency for Android devicesGravatar Kevin Lubick2017-12-05
| | | | | | | | | | Bug: skia:7378 NOTRY=true No-Tree-Checks: true Change-Id: Iaacbc8eadaa4da9832a53d4794a2214625bef9b6 Reviewed-on: https://skia-review.googlesource.com/80842 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Turn up Nexus10 CPU frequenciesGravatar Kevin Lubick2017-11-30
| | | | | | | | | | | | | | | | | | | | | The previous list was created from scaling_min_freq and scaling_max_freq instead of cpuinfo_min_freq and cpuinfo_max_freq which are the actual mins and maxes, not the current (transient) settings of the governor. Before: Test-Release: 61 minutes Perf-Debug: 41 minutes After: Test-Release: 32 minutes Perf-Debug: 16 minutes NOTRY=true Bug: skia: Change-Id: I9b431e92d2abcecb4fe643389daddc912a1399e1 Reviewed-on: https://skia-review.googlesource.com/78141 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Make cpu scaling more robustGravatar Kevin Lubick2017-11-30
| | | | | | | | | | | | | | | | | | Some bots, especially the Nexus 7s, seemed to occasionally fail when setting the CPU frequency. I was unable to repro this behavior, so this is a shotgun approach. We add a 5 second delay between setting and checking, checking frequency using scaling_cur_freq instead of scaling_setspeed, set the min_freq as well as max_freq, and retry up to 3 times if setting cpu frequency fails. NOTRY=true Bug: skia: Change-Id: Id4d85d8d509c9dba8e3a0e06b5992f5adadf36d2 Reviewed-on: https://skia-review.googlesource.com/78140 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Don't scale CPU for internal botsGravatar Kevin Lubick2017-11-28
| | | | | | | | | | | | For internal hardware, it tends not to work - they work at one clock speed, despite advertising others. Bug: skia: NOTRY=true Change-Id: I10bf0fc1ab4d60bfbc2eefcef5b42ceab9e3f435 Reviewed-on: https://skia-review.googlesource.com/76720 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Fix scaling on Nexus 7 botsGravatar Kevin Lubick2017-11-22
| | | | | | | | | | Bug: skia: NOTRY=true Change-Id: I1a1755dd03f2e6ebd8d9b2c9235cca8eb34f04ad Reviewed-on: https://skia-review.googlesource.com/75280 Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Make CPU scaling code cleanerGravatar Kevin Lubick2017-11-21
| | | | | | | | | | | | | | | | | This also makes *sure* the CPU frequency we set the device to actually "takes". Along the way, I learned if scaling_max_freq is < the frequency we set, the scaling_max_freq will be used instead, which was happening to the PixelCs and AndroidOnes. As a result, this may make those two Test- configs faster. Bug: skia: Change-Id: I10c98d37e296a19e1cf67bfe7269bb59cdd912d5 Reviewed-on: https://skia-review.googlesource.com/74360 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Put CPU frequency scaling in recipesGravatar Kevin Lubick2017-11-20
| | | | | | | | Bug: skia: Change-Id: I994f67c3043306d7fa612feb03f8fbe8d7bf4c91 Reviewed-on: https://skia-review.googlesource.com/73760 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* pass -k 0 to ninjaGravatar Mike Klein2017-11-06
| | | | | | | | | | This makes failing builds print all failures, not just the first. Successful builds, the usual case, are unaffected. Change-Id: I8dde21e913f6715e7760b298a87f51d1b40a8789 Reviewed-on: https://skia-review.googlesource.com/67803 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Fix asset version detectionGravatar Kevin Lubick2017-10-13
| | | | | | | | | | | | | | Since we went to retrying the adb commands, the return value got lost, which was used to read the SKP_VERSIOn, etc. This fixes it. Bug: skia: NOTRY=true Change-Id: Ifc61ec4cbb13a61c571b2fb89a9c0ed215f8fbd3 Reviewed-on: https://skia-review.googlesource.com/59441 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Update to adb 1.0.35Gravatar Kevin Lubick2017-10-12
| | | | | | | | | | | | | | | | | | | | | | | | The newer adb acts more like cp when pulling. We used to create the dm folder on the host machine before pulling. This used to be fine, /device/dm_out/dm.json -> /host/dm/dm.json However, with the update, adb would do /device/dm_out/dm.json -> /host/dm/dm_out/dm.json This breaks the upload step. To make this transition a smooth one, /usr/bin/adb on the RPI is staying the same (for a while, at least) and /usr/bin/adb.1.0.35 is being added. That way we can use the new adb on tests after this commit, but when we backfill, we don't break because of the unexpected folder. Bug: skia: Change-Id: Icbed38594fca0e17af1f8d01d75c42ce03f710b9 Reviewed-on: https://skia-review.googlesource.com/58880 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Simpler version of wait-for-device.Gravatar Ben Wagner2017-09-12
| | | | | | | | | | This is a followup to https://skia-review.googlesource.com/43564 No-Try: true Change-Id: I4bc2a24fe08e6b07f5512e3a1e03eac7e3397155 Reviewed-on: https://skia-review.googlesource.com/45120 Commit-Queue: Ben Wagner <benjaminwagner@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com>
* Retry adb commands on flaky devices.Gravatar Ben Wagner2017-09-11
| | | | | | | | No-Try: true Change-Id: I3519131cf064d0a9676abd0fb9d7e946646ce27f Reviewed-on: https://skia-review.googlesource.com/43564 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Ben Wagner <benjaminwagner@google.com>
* Add new Android builder which uses API_LEVEL 26Gravatar Eric Boren2017-07-20
| | | | | | | | Bug: skia:6870 Change-Id: Idd9a27518c1123c0a729b4d07461047f5530aae3 Reviewed-on: https://skia-review.googlesource.com/24960 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Stop adding Android-specific defines to SkUserConfigGravatar Leon Scroggins III2017-07-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove #defines that lived in gn_to_bp.py and android_framework_defines.gni. These have been moved into a new file in Android, SkUserConfigManual.h, in https://googleplex-android-review.git.corp.google.com/#/c/2519600/ Update gn_to_bp.py to include SkUserConfigManual.h, so it will still result in using the same #defines. Lately, we've found it difficult to guard changes behind a flag. e.g. a change to drawing causes a CTS failure in Android, so we have to do the following: - put the change behind a flag, and add it to gn_to_bp.py or android_framework_defines.gni - generate new images on Android (by running CTS with external/skia modified to not define the flag) - create a CL in CTS that uses the new images - land a CL in Skia that stops defining the flag - when the Skia change lands, wait for the auto-roller to create a CL that includes the change, stop the auto-roller, add the topic to the CTS CL so the two can land at the same time - land both Android changes (with TreeHugger) - restart the Android auto-roller With SkUserConfigManual.h (which lives in Android), the process will be similar to Chromium: - land a CL in Android's external/skia that defines a flag e.g. SK_SUPPORT_LEGACY_FEATURE. Land without TreeHugger because it isn't used in Skia and does not do anything - land a change in Skia that changes behavior unless SK_SUPPORT_LEGACY_FEATURE is defined. This will safely go through the Android roll and not change any behavior for Android - create two Android CLs - one in CTS to use the new images, and one in external/skia to delete SK_SUPPORT_LEGACY_FEATURE. Set them to the same topic and land them with TreeHugger In the new process, there is no need to mess with the Android roll. A downside to the new process is that we cannot test the android framework defines without checking in to Android. But given how much we've progressed in automating Android testing, this is fine. Bug: b/63429612 Change-Id: Idfbaef2f4cae641a75fb6e7bf70428733a441336 Reviewed-on: https://skia-review.googlesource.com/22072 Commit-Queue: Leon Scroggins <scroggo@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* [skia] convert recipes and module to new context moduleGravatar Robert Iannucci2017-05-15
| | | | | | | | | | | | | This is a syntax-only change to convert to the new (documented) context module. R=borenet@google.com Bug: skia: Change-Id: Id907c309d3cf38b85a46f6d8d7ce90ed58ba026f Reviewed-on: https://skia-review.googlesource.com/16840 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Don't reboot Pixel C or Nexus Player before taskGravatar Kevin Lubick2017-04-27
| | | | | | | | | | | | | We reboot this after in swarming with real adb, so this is unnecessary and could, in fact, be harmful. Bug: skia:6559 NOTRY=true Change-Id: Iaf58416994637111c02013fe3c83f4ac92de2a66 Reviewed-on: https://skia-review.googlesource.com/14526 Reviewed-by: Eric Boren <borenet@google.com> Reviewed-by: Ben Wagner <benjaminwagner@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* [recipes] Fix *_VERSION step failure handlingGravatar Eric Boren2017-04-24
| | | | | | | | | | Bug: skia:6473 Change-Id: I2fa6f800f59f40f74b5c080c52cdec3a32329ef7 NOTRY=true Reviewed-on: https://skia-review.googlesource.com/14240 Commit-Queue: Stephan Altmueller <stephana@google.com> Reviewed-by: Kevin Lubick <kjlubick@google.com> Reviewed-by: Stephan Altmueller <stephana@google.com>
* Reland Recipes: Use strict coverage, part 2Gravatar Eric Boren2017-04-19
| | | | | | | | Bug: skia:6473 Change-Id: I90c1c3a3108ce583df60933150d97b426173a315 Reviewed-on: https://skia-review.googlesource.com/13840 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Revert "Recipes: Use strict coverage, part 2"Gravatar Eric Boren2017-04-19
| | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 4dbc9cead90eb31756a1c1bf61ea01f223c5fe96. Reason for revert: flaky? Original change's description: > Recipes: Use strict coverage, part 2 > > Bug: skia:6473 > Change-Id: Ia3a1587215a6a868c9577f2d864bc5c4e671a3fa > Reviewed-on: https://skia-review.googlesource.com/13812 > Reviewed-by: Ravi Mistry <rmistry@google.com> > Commit-Queue: Eric Boren <borenet@google.com> > TBR=borenet@google.com,rmistry@google.com,reviews@skia.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Id746de56609fbaf5ec8ecdd22b5e60bcb3c01fa2 Reviewed-on: https://skia-review.googlesource.com/13819 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Recipes: Use strict coverage, part 2Gravatar Eric Boren2017-04-19
| | | | | | | | Bug: skia:6473 Change-Id: Ia3a1587215a6a868c9577f2d864bc5c4e671a3fa Reviewed-on: https://skia-review.googlesource.com/13812 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Followup fixes for recipe rollGravatar Eric Boren2017-03-21
| | | | | | | | | | | | | | Simplifying some environment madness. Nobody gets to modify default_env. Always apply it in run.__call__(). Add depot_tools path to PATH in default_env. Result is simpler but now default_env is applied in many more places, which should be harmless. BUG=skia: Change-Id: I8299d50bde2bc3e2d47568a267d1d962a3fc3d56 Reviewed-on: https://skia-review.googlesource.com/9916 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Roll Recipe DEPSGravatar Eric Boren2017-03-21
| | | | | | | | | BUG=skia: Change-Id: Ic89d1b49aba842fb41c82ad6fc8f5ebe787893bd Reviewed-on: https://skia-review.googlesource.com/9884 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Reboot PixelCs before every taskGravatar Kevin Lubick2017-03-16
| | | | | | | | | | | | | | | Just like the NexusPlayers, swarming can't reboot the PixelCs. This may be causing the strange state we see in tasks like: https://chromium-swarm.appspot.com/task?id=34ed0f1bdcd5a610&refresh=10 BUG=skia: Change-Id: Icb0b4a5564d34093abb463ca8ef5da43d066db4a Reviewed-on: https://skia-review.googlesource.com/9818 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Fix Nexus 10s from shutting down too oftenGravatar Kevin Lubick2017-02-15
| | | | | | | | | BUG=skia: Change-Id: I373bb62c6894569a2672745ce20aa351c5893968 Reviewed-on: https://skia-review.googlesource.com/8486 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com>
* Clean up hack of run apiGravatar Kevin Lubick2017-02-13
| | | | | | | | | | | | Also fix such that the Nexus Players get kicked three times not one and a half times. BUG=skia:6045 Change-Id: Ie9142f809a979a46b17a8ad9a205279d6fcb9bd5 Reviewed-on: https://skia-review.googlesource.com/8266 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Prevent waiting for NexusPlayers indefinitelyGravatar Kevin Lubick2017-02-09
| | | | | | | | | | | | | | | | | | | Also, I noticed that sometimes the NexusPlayers would come back up such that adb would recognize them, but not such that the sys.boot_completed was set to 1. This was usually fixed by rebooting the devices again. This code will reboot them up to three times in total before giving up and killing the device. BUG=skia: TBR=borenet,rmistry NOTREECHECKS=true NOTRY=true Change-Id: Ic2217855ad643ab256a598a3f55a67ba84ebcb25 Reviewed-on: https://skia-review.googlesource.com/8285 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Reboot NexusPlayers with adb and shut them down if install failsGravatar Kevin Lubick2017-02-09
| | | | | | | | | BUG=skia:6045 Change-Id: Ibd31e4cc44b71633377b05ad33c1bdab9024f78c Reviewed-on: https://skia-review.googlesource.com/8152 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>
* Copy modules back in from skia-recipes repoGravatar Eric Boren2017-02-02
| | | | | | | | | BUG=skia:6070 Change-Id: I86b3f039c27bd8287516c1db8bd1cae62888171b Reviewed-on: https://skia-review.googlesource.com/7890 Reviewed-by: Ravi Mistry <rmistry@google.com> Commit-Queue: Eric Boren <borenet@google.com>
* Move recipe modules to shared repoGravatar Eric Boren2017-01-17
| | | | | | | | | | BUG=skia:6070 Change-Id: I6c487e77ddfddb6164b983981dff5ee8ae870376 Reviewed-on: https://skia-review.googlesource.com/6946 Commit-Queue: Eric Boren <borenet@google.com> Reviewed-by: Ravi Mistry <rmistry@google.com> Reviewed-by: Stephan Altmueller <stephana@google.com>
* Add skpbench jobGravatar Kevin Lubick2016-11-14
| | | | | | | | | | | | | | | | | | | | | | | | This entails a few parts: 1. Isolating tools/skpbench/ to be used by the perf task. 2. Adding skpbench to BUILD_PRODUCTS_ISOLATE_WHITELIST 3. Add recipe commands to run skpbench. While it is conceptually similar to nanobench, it doesn't support images nor svgs, only skps, so we don't need to copy those to devices or bring them in via CIPD. 4. Add recipe commands to parse skpbench output and upload to Perf. 5. Update gen_tasks.go to handle skpbench jobs and tasks. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4551 Change-Id: I09bf0b078067279e138e95eca9316e55539ec735 Reviewed-on: https://skia-review.googlesource.com/4551 Commit-Queue: Kevin Lubick <kjlubick@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* GN android flavor windows supportGravatar Mike Klein2016-11-03
| | | | | | | | | | | | | | | | GN is a .bat, fetch-gn is a Python script, ninja is an .exe. Just the same stuff gn_flavor does in the same way. TBR=borenet@google.com BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4321 Change-Id: I89ce3711a6dea46d32fe03c5719ef635defe54f7 Reviewed-on: https://skia-review.googlesource.com/4321 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Shorten android_ndk_windows to n to save some precious path budget.Gravatar Mike Klein2016-11-02
| | | | | | | | | | | | | | We're going above 260 as-is. If this doesn't work... hopefully we don't need any of the long-named files. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4316 Change-Id: I3074c28adfbd4fccb5230eaacf2d6f0c4980bbbe Reviewed-on: https://skia-review.googlesource.com/4316 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Eric Boren <borenet@google.com>
* Add a Windows Android builder.Gravatar Mike Klein2016-11-02
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4320 Change-Id: Ifd693f5de978565f694bc0173a1248e705303e68 Reviewed-on: https://skia-review.googlesource.com/4320 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* For debug builds, -O0 by default, adding -O1 only on bots.Gravatar Mike Klein2016-11-02
| | | | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=4344 Change-Id: Idc1435d75e51ea0b54d369efa91993d369aa74c0 Reviewed-on: https://skia-review.googlesource.com/4344 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Remove custom NINJA_STATUS.Gravatar Mike Klein2016-10-19
| | | | | | | | | | I think the Ninja [nnn/mmm] counts started going off when we landed this. I'd rather have the [nnn/mmm] be correct than have the timestamps. Change-Id: I96d24664789393056f94202f2b549ed5a4fe4bdb Reviewed-on: https://skia-review.googlesource.com/3604 Reviewed-by: Eric Boren <borenet@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Some GN-related recipe cleanup.Gravatar Mike Klein2016-10-18
| | | | | | | | | | | | | | | | | | | All our bots but the iOS ones are on GN now. This cleans up a bunch of GYP and other obsolete stuff. - Nothing's using default_flavor.py any more except as a base class. - There are no -CMake, -Shared or -VisualBench bots anymore. - Only the iOS bots care about GYP_DEFINES. You'll see the PDFium bot's GYP_DEFINES change, but that doesn't matter... it's using PDFium's own (GN) build system, and it ignores GYP_DEFINES. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3567 Change-Id: I699e10f013ea77df4dcaa1cb559c51c5bf55dfdb Reviewed-on: https://skia-review.googlesource.com/3567 Commit-Queue: Mike Klein <mtklein@google.com> Reviewed-by: Eric Boren <borenet@google.com>
* Add timestamp to bot ninja output.Gravatar Mike Klein2016-10-13
| | | | | | | | | | | The default NINJA_STATUS format is "[%f/%t] ". This prepends %e to help diagnose slow builds. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=3323 Change-Id: Ied27317cedc2b07ff57c59eae61fe9e86c7fea33 Reviewed-on: https://skia-review.googlesource.com/3323 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Eric Boren <borenet@google.com>
* Stop rebooting Android devices during Swarming tasksGravatar borenet2016-10-13
| | | | | | | | | Swarming will reboot the devices after each task. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2402403002 Review-Url: https://codereview.chromium.org/2402403002
* Add define of SK_ENABLE_VK_LAYERS to gn buildGravatar egdaniel2016-09-21
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2357953002 Review-Url: https://codereview.chromium.org/2357953002
* Snazzier dump log step on Android bots.Gravatar mtklein2016-09-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (The failing NexusPlayer bot is a demo.) This should make stack traces more useful, turning this sort of thing 09-20 11:29:39.536 2978 2978 F DEBUG : #00 pc 00970fd0 /data/local/tmp/dm into something like this 09-20 11:29:39.536 2978 2978 F DEBUG : #00 pc 00970fd0 adjust_bounds_to_granularity(SkIRect*, SkIRect const&, VkExtent2D const&, int, int) at /b/work/skia/out/Build-Ubuntu-Clang-x86-Debug-GN_Android_Vulkan/Debug/../../../src/gpu/vk/GrVkGpu.cpp:1803 /data/local/tmp/dm Some bots like the S7 already have good enough stack traces, e.g. 09-20 11:35:12.567 936 936 F DEBUG : #00 pc 00000000000bed6c /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN13QglManagedBuf14ConfirmEntriesEv+108) 09-20 11:35:12.567 936 936 F DEBUG : #01 pc 00000000000b098c /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN9QglBltLib6FillHwEPK10QglBltFillPK15QglBltColorFillPK15QglBltDepthFillPjP12QglBltStatusSB_+588) 09-20 11:35:12.567 936 936 F DEBUG : #02 pc 00000000000b23bc /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN9QglBltLib9FillImageEPK10QglBltFillPK15QglBltColorFillPK15QglBltDepthFillPjP12QglBltStatusSB_+348) 09-20 11:35:12.567 936 936 F DEBUG : #03 pc 000000000009bb00 /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN16A5xCommandBuffer22PerformConditionalFillEiiP10QglBltFillPK15QglBltColorFillP15QglBltDepthFillP12QglBltStatusS8_+256) 09-20 11:35:12.567 936 936 F DEBUG : #04 pc 000000000009c0c0 /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN16A5xCommandBuffer23HwWriteSubpassInitClearEP10QglBltFillPK15QglBltColorFillP15QglBltDepthFillP12QglBltStatusS8_+224) 09-20 11:35:12.567 936 936 F DEBUG : #05 pc 0000000000072610 /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN16QglCommandBuffer18WriteSubpassClearsEv+464) 09-20 11:35:12.567 936 936 F DEBUG : #06 pc 0000000000073ae0 /system/vendor/lib64/hw/vulkan.msm8996.so (_ZN16QglCommandBuffer12BeginSubpassEv+32) 09-20 11:35:12.567 936 936 F DEBUG : #07 pc 0000000000063120 /system/vendor/lib64/hw/vulkan.msm8996.so (vkCmdBeginRenderPass+224) 09-20 11:35:12.567 936 936 F DEBUG : #08 pc 0000000000635f60 /data/local/tmp/nanobench (_ZN24GrVkPrimaryCommandBuffer15beginRenderPassEPK7GrVkGpuPK14GrVkRenderPassjPK12VkClearValueRK16GrVkRenderTargetRK7SkIRectb+132) or 09-20 11:42:24.557 937 937 F DEBUG : backtrace: 09-20 11:42:24.557 937 937 F DEBUG : #00 pc 0000000000069404 /system/lib64/libc.so (tgkill+8) 09-20 11:42:24.557 937 937 F DEBUG : #01 pc 0000000000066b94 /system/lib64/libc.so (pthread_kill+68) 09-20 11:42:24.557 937 937 F DEBUG : #02 pc 0000000000023a28 /system/lib64/libc.so (raise+28) 09-20 11:42:24.557 937 937 F DEBUG : #03 pc 000000000001e358 /system/lib64/libc.so (abort+60) 09-20 11:42:24.557 937 937 F DEBUG : #04 pc 000000000076430c /data/local/tmp/dm (_Z17sk_abort_no_printv+8) These won't be affected. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2351243002 NOTREECHECKS=true Review-Url: https://codereview.chromium.org/2351243002
* GN: remove old Android recipe code.Gravatar mtklein2016-09-19
| | | | | | | | | | | All the Android builders, testers, and perfers are on gn_android_flavor now. Not as scary as it looks... all the big line count changes are deletes. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2352653002 Review-Url: https://codereview.chromium.org/2352653002
* GN: enable Vulkan on Android when API >= 24.Gravatar mtklein2016-09-16
| | | | | | | | | | | Android API >= 24 implies Vulkan support, so we can have a more useful default here than 'false'. If for some reason you wanted to turn it off, you can still override skia_use_vulkan. The defined(ndk_api) guards other users of our GN files (Fuchsia) who may not have an ndk_api argument defined in their BUILDCONFIG.gn. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2347843003 Review-Url: https://codereview.chromium.org/2347843003
* merge run and check-rc stepsGravatar mtklein2016-09-14
| | | | | | | | | | | This'll make the 'dm' or 'nanobench' step go red like you'd hope. The N5 should pass and the N10 and N7 should fail, showing us both sides. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2339713003 Review-Url: https://codereview.chromium.org/2339713003
* Android GN scripts: distingush directories for data and binaries.Gravatar mtklein2016-09-14
| | | | | | | | | This enables data reuse, e.g. https://luci-milo.appspot.com/swarming/task/313eff129c753d10 or https://luci-milo.appspot.com/swarming/task/313f17a174c6c710 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2335203004 Review-Url: https://codereview.chromium.org/2335203004
* Update gn_android_flavor for Vulkan.Gravatar mtklein2016-09-13
| | | | | | | | | C.f. https://codereview.chromium.org/2336343002 for basic GN support. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333293004 Review-Url: https://codereview.chromium.org/2333293004
* Android GN: don't reboot before runningGravatar mtklein2016-09-13
| | | | | | | | | We're already rebooting after running, so we should already be ready to go when the task starts. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2334223003 Review-Url: https://codereview.chromium.org/2334223003
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-06 21:57:54 +0000