aboutsummaryrefslogtreecommitdiffhomepage
path: root/include/private/SkTFitsIn.h
Commit message (Collapse)AuthorAge
* Reland "use std::enable_if instead of assert()"Gravatar Mike Klein2018-06-14
| | | | | | | | | | | | | | | | | | | | | This is a reland of c6530d1e5ecce640e0255d66a01f9db73add7df9 Original change's description: > use std::enable_if instead of assert() > > Crazy? Genius? > > Change-Id: I6033ab5f1af1a6bee84c27025b988e1143d59293 > Reviewed-on: https://skia-review.googlesource.com/134512 > Commit-Queue: Mike Klein <mtklein@chromium.org> > Commit-Queue: Ben Wagner <bungeman@google.com> > Auto-Submit: Mike Klein <mtklein@chromium.org> > Reviewed-by: Ben Wagner <bungeman@google.com> Change-Id: I50849c89a37255396706ce659e20f00c0b0f08c6 Reviewed-on: https://skia-review.googlesource.com/134860 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Reland "simplify SkTFitsIn, try 2"Gravatar Mike Klein2018-06-14
| | | | | | | | | | | | | | | | | | | | | | | | | | This is a reland of 009f51e43fee199a579ecdd773e3aa35aaa3b8b8 Original change's description: > simplify SkTFitsIn, try 2 > > Originally we wrote this in C++14 constexpr, > but because this is used from public headers, we can't use > C++14 yet. Now a somewhat sillier looking C++11 version. > > All the old tests still pass, and one new added. > Updated the comments a bit for correctness and readability. > > Change-Id: I99c01e1346c1a5a36278cc08f30538112e5259aa > Reviewed-on: https://skia-review.googlesource.com/134425 > Commit-Queue: Mike Klein <mtklein@chromium.org> > Commit-Queue: Ben Wagner <bungeman@google.com> > Auto-Submit: Mike Klein <mtklein@chromium.org> > Reviewed-by: Ben Wagner <bungeman@google.com> Change-Id: I99676faac6153830538c1396a325ca1456dfb126 Reviewed-on: https://skia-review.googlesource.com/134800 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Revert "simplify SkTFitsIn, try 2"Gravatar Mike Klein2018-06-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 009f51e43fee199a579ecdd773e3aa35aaa3b8b8. Reason for revert: unintentional header consequences in Chromium... will reland after fixing Chromium Original change's description: > simplify SkTFitsIn, try 2 > > Originally we wrote this in C++14 constexpr, > but because this is used from public headers, we can't use > C++14 yet. Now a somewhat sillier looking C++11 version. > > All the old tests still pass, and one new added. > Updated the comments a bit for correctness and readability. > > Change-Id: I99c01e1346c1a5a36278cc08f30538112e5259aa > Reviewed-on: https://skia-review.googlesource.com/134425 > Commit-Queue: Mike Klein <mtklein@chromium.org> > Commit-Queue: Ben Wagner <bungeman@google.com> > Auto-Submit: Mike Klein <mtklein@chromium.org> > Reviewed-by: Ben Wagner <bungeman@google.com> TBR=mtklein@chromium.org,bungeman@google.com Change-Id: Ic73f8800bd022ffea125b3b1bf138fe49c0db926 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/134621 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* Revert "use std::enable_if instead of assert()"Gravatar Mike Klein2018-06-13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit c6530d1e5ecce640e0255d66a01f9db73add7df9. Reason for revert: going to revert SkTFitsIn refactor temporarily Original change's description: > use std::enable_if instead of assert() > > Crazy? Genius? > > Change-Id: I6033ab5f1af1a6bee84c27025b988e1143d59293 > Reviewed-on: https://skia-review.googlesource.com/134512 > Commit-Queue: Mike Klein <mtklein@chromium.org> > Commit-Queue: Ben Wagner <bungeman@google.com> > Auto-Submit: Mike Klein <mtklein@chromium.org> > Reviewed-by: Ben Wagner <bungeman@google.com> TBR=mtklein@chromium.org,bungeman@google.com Change-Id: Id7c91e3a12756defe194379579cc5fd88fd4b164 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/134620 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* use std::enable_if instead of assert()Gravatar Mike Klein2018-06-13
| | | | | | | | | | | Crazy? Genius? Change-Id: I6033ab5f1af1a6bee84c27025b988e1143d59293 Reviewed-on: https://skia-review.googlesource.com/134512 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <bungeman@google.com> Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by: Ben Wagner <bungeman@google.com>
* simplify SkTFitsIn, try 2Gravatar Mike Klein2018-06-13
| | | | | | | | | | | | | | | | Originally we wrote this in C++14 constexpr, but because this is used from public headers, we can't use C++14 yet. Now a somewhat sillier looking C++11 version. All the old tests still pass, and one new added. Updated the comments a bit for correctness and readability. Change-Id: I99c01e1346c1a5a36278cc08f30538112e5259aa Reviewed-on: https://skia-review.googlesource.com/134425 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Ben Wagner <bungeman@google.com> Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by: Ben Wagner <bungeman@google.com>
* Revert "simplify SkTFitsIn"Gravatar Mike Klein2018-06-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit b82c3d6ff2ac62c8a14b38b0d658a51e7d8cf81e. Reason for revert: SkTFitsIn makes its way into public headers via SkTo<T>, so it cannot use C++14isms. Original change's description: > simplify SkTFitsIn > > Now that we're C++14, a constexpr SkTFitsIn() is a lot easier. > All the old tests still pass, and one new added. > > Updated the comments a bit for correctness and readability. > > Change-Id: I0f60e32e545fe4f2fb14e66a2bf25d562dbd680f > Reviewed-on: https://skia-review.googlesource.com/133831 > Reviewed-by: Ben Wagner <bungeman@google.com> > Commit-Queue: Mike Klein <mtklein@chromium.org> TBR=mtklein@chromium.org,halcanary@google.com,bungeman@google.com Change-Id: Icfb19c77b450cf3525d11225d4237f9bfa68c7fc No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://skia-review.googlesource.com/134440 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Mike Klein <mtklein@google.com>
* simplify SkTFitsInGravatar Mike Klein2018-06-12
| | | | | | | | | | | | Now that we're C++14, a constexpr SkTFitsIn() is a lot easier. All the old tests still pass, and one new added. Updated the comments a bit for correctness and readability. Change-Id: I0f60e32e545fe4f2fb14e66a2bf25d562dbd680f Reviewed-on: https://skia-review.googlesource.com/133831 Reviewed-by: Ben Wagner <bungeman@google.com> Commit-Queue: Mike Klein <mtklein@chromium.org>
* Add paint flags to viewer GUI.Gravatar Ben Wagner2018-04-17
| | | | | | | | | | Overriding bits of the paint was added with keyboard bindings but without being reflected in the GUI. This adds these flags to the GUI. Change-Id: I633801fb776248952afe7cbe8857676ef8b57135 Reviewed-on: https://skia-review.googlesource.com/121796 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Ben Wagner <bungeman@google.com>
* Make SkTFitsIn and SkTo constexpr.Gravatar Ben Wagner2017-10-17
| | | | | | | | | | Because what can be better than marking things that can be constexpr as constexpr. Also, I have a change where this would be nice to have. Change-Id: Ie313b19d1930b98ddcd60cc17a320971625f18e3 Reviewed-on: https://skia-review.googlesource.com/60862 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@chromium.org>
* Make SkTFitsIn turn into less code.Gravatar Ben Wagner2017-08-24
| | | | | | | | | | This changes the cases which require two compares into single compares by relying on squirrely bits of the C++ specification. Change-Id: I2c14e461b571bb94f586c14db4eaeadfd06b628b Reviewed-on: https://skia-review.googlesource.com/38220 Commit-Queue: Ben Wagner <bungeman@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
* Templatize SkToXXX.Gravatar bungeman2016-03-19
| | | | | | | | | | | Makes the checked cast in debug more correct, avoiding new warnings in vs2015. BUG=skia:4553 Committed: https://skia.googlesource.com/skia/+/0be9e806af72b3e029e691eef5c891c90d3fd320 Review URL: https://codereview.chromium.org/1814153003
* Revert of Templatize SkToXXX. (patchset #2 id:20001 of ↵Gravatar bungeman2016-03-18
| | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1814153003/ ) Reason for revert: Chrome does not yet have std::underlying_type. Original issue's description: > Templatize SkToXXX. > > Makes the checked cast in debug more correct, avoiding new > warnings in vs2015. > > BUG=skia:4553 > > Committed: https://skia.googlesource.com/skia/+/0be9e806af72b3e029e691eef5c891c90d3fd320 TBR=reed@google.com,mtklein@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4553 Review URL: https://codereview.chromium.org/1820433002
* Templatize SkToXXX.Gravatar bungeman2016-03-18
Makes the checked cast in debug more correct, avoiding new warnings in vs2015. BUG=skia:4553 Review URL: https://codereview.chromium.org/1814153003
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-09 04:20:30 +0000