aboutsummaryrefslogtreecommitdiffhomepage
path: root/gn/flutter_defines.gni
Commit message (Collapse)AuthorAge
* Add legacy flag for vulkan interface for flutter.Gravatar Greg Daniel2018-06-23
| | | | | | | | Bug: skia: Change-Id: I50eb5c331b4a5818037155865d477914276a983c Reviewed-on: https://skia-review.googlesource.com/137194 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* clean up defines that do nothingGravatar Mike Klein2018-06-18
| | | | | | | | | Change-Id: I0181ddfd7b75cd7ffb7002b7038a99419ea876f2 Reviewed-on: https://skia-review.googlesource.com/135562 Commit-Queue: Mike Klein <mtklein@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Auto-Submit: Mike Klein <mtklein@chromium.org> Reviewed-by: Brian Osman <brianosman@google.com>
* Reland "Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter."Gravatar Greg Daniel2018-05-21
| | | | | | | | | | | | | | | | | | | | This is a reland of 333031b921264508ca1869769c1021bc08e4e07a Original change's description: > Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter. > > Bug: skia: > Change-Id: I2c8c116f825278cae4001d169aaef42ce9a21873 > Reviewed-on: https://skia-review.googlesource.com/125725 > Commit-Queue: Greg Daniel <egdaniel@google.com> > Reviewed-by: Brian Osman <brianosman@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> Bug: skia: Change-Id: Ibb8f89f1d3559a8484976f6a07f9a01d28394c48 Reviewed-on: https://skia-review.googlesource.com/129341 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Revert "Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter."Gravatar Greg Daniel2018-05-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 333031b921264508ca1869769c1021bc08e4e07a. Reason for revert: Flutter roll into fuchsia got reverted so now this breaks fuchsia again.... Original change's description: > Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter. > > Bug: skia: > Change-Id: I2c8c116f825278cae4001d169aaef42ce9a21873 > Reviewed-on: https://skia-review.googlesource.com/125725 > Commit-Queue: Greg Daniel <egdaniel@google.com> > Reviewed-by: Brian Osman <brianosman@google.com> > Reviewed-by: Robert Phillips <robertphillips@google.com> TBR=egdaniel@google.com,robertphillips@google.com,brianosman@google.com Change-Id: I78f3cfae9ba690a34372d2081e47ec793cda3392 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/127481 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* Remove guard flag for SK_SUPPORT_LEGACY_BACKEND_OBJECTS on flutter.Gravatar Greg Daniel2018-05-10
| | | | | | | | | Bug: skia: Change-Id: I2c8c116f825278cae4001d169aaef42ce9a21873 Reviewed-on: https://skia-review.googlesource.com/125725 Commit-Queue: Greg Daniel <egdaniel@google.com> Reviewed-by: Brian Osman <brianosman@google.com> Reviewed-by: Robert Phillips <robertphillips@google.com>
* Disable optimizing xforms for speed on FlutterGravatar Brian Osman2018-04-26
| | | | | | | | | | Ironically, this is a giant slowdown, because xforms are being constructed every frame, and this takes multiple ms. Change-Id: Ib242b6b7b212c715d20fdd572ed6db5a167f07e2 Reviewed-on: https://skia-review.googlesource.com/123922 Reviewed-by: Brian Osman <brianosman@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* Add SK_SUPPORT_LEGACY_BACKEND_OBJECTSGravatar Robert Phillips2018-04-12
| | | | | | | | | This relies on the Chrome CL: https://chromium-review.googlesource.com/c/chromium/src/+/999796 (Add SK_SUPPORT_LEGACY_BACKEND_OBJECTS to SkUserConfig.h) landing first. Change-Id: Ie0a2b7b84cc02e46957765a0a7d6444a5320769d Reviewed-on: https://skia-review.googlesource.com/119140 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com>
* Remove legacy API support from FlutterGravatar Brian Osman2018-04-03
| | | | | | | | | | | | | | | | All uses of these APIs have been removed / updated. This still can't land until all Flutter fixes: https://github.com/flutter/engine/commit/c092e1475ad473d30fe740bc307bfd08b54a84fc have landed in Fuchsia: https://fuchsia.googlesource.com/topaz/+/master/manifest/flutter Change-Id: I3d188e3594751617f3f232fe7323428c822d13e1 Reviewed-on: https://skia-review.googlesource.com/117780 Reviewed-by: Mike Klein <mtklein@google.com> Commit-Queue: Brian Osman <brianosman@google.com>
* hide SkBlurMaskFilter and SkBlurQualityGravatar Mike Reed2018-03-14
| | | | | | | | | | SK_SUPPORT_LEGACY_BLURMASKFILTER Bug: skia: Change-Id: Ic3e27e08e6e3cd2ffc1cd13b044e197bebc96236 Reviewed-on: https://skia-review.googlesource.com/113940 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Switch MDB GrContextOptions over to Enable styleGravatar Robert Phillips2018-02-08
| | | | | | | Change-Id: Id6541c346a13649c89ca3b9ccb13972976f9b973 Reviewed-on: https://skia-review.googlesource.com/105603 Reviewed-by: Brian Salomon <bsalomon@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com>
* Move control of explicit GPU resource allocation to GrContextOptionsGravatar Robert Phillips2018-02-08
| | | | | | | | Change-Id: Ic284acc79bab5936f0007d5ae5fb1e7a9929e2af Reviewed-on: https://skia-review.googlesource.com/104880 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Salomon <bsalomon@google.com> Reviewed-by: Greg Daniel <egdaniel@google.com>
* add flag for flutterGravatar Mike Reed2018-01-09
| | | | | | | Bug: skia: Change-Id: I73b6045aa17c7a38fcbd3245be926a5097d165ee Reviewed-on: https://skia-review.googlesource.com/92684 Reviewed-by: Mike Reed <reed@google.com>
* Preemptively disable upcoming Skia features in Flutter/FuchsiaGravatar Robert Phillips2017-11-10
| | | | | | | Change-Id: I8be706846fecde704a29ba1dda0d7329046980b4 Reviewed-on: https://skia-review.googlesource.com/69840 Commit-Queue: Robert Phillips <robertphillips@google.com> Reviewed-by: Brian Osman <brianosman@google.com>
* remove legacy font api flag for flutterGravatar Mike Reed2017-10-11
| | | | | | | Bug: skia: Change-Id: I318f06f93d42ea74ea2eeb93ff3b69335f93a62c Reviewed-on: https://skia-review.googlesource.com/58240 Reviewed-by: Mike Reed <reed@google.com>
* use new computeByteSize apiGravatar Mike Reed2017-10-10
| | | | | | | Bug: skia: Change-Id: If88f6e5fe7c7856ea7ce4780deaf88214f51bf0c Reviewed-on: https://skia-review.googlesource.com/58040 Reviewed-by: Mike Reed <reed@google.com>
* Revert[3] "remove legacy fontmgr flag from flutter"Gravatar Mike Reed2017-10-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit cbfd8bf7c098bff938d0f575584a7a82b354c621. Reason for revert: broke again ../../garnet/public/lib/ui/skia/skia_font_loader.cc:29:42: error: no member named 'createFromData' in 'SkFontMgr' SkFontMgr::RefDefault()->createFromData(font_data.get()))); Original change's description: > Revert "Revert "remove legacy fontmgr flag from flutter"" > > This reverts commit da6cf4e97ca334b408dda2344b6758970802eddd. > > Reason for revert: fix landed in flutter > > Original change's description: > > Revert "remove legacy fontmgr flag from flutter" > > > > This reverts commit 7077ae855519a23b087ded7386e18b475ac73c48. > > > > Reason for revert: Breaking flutter [1]: > > > > ../../flutter/sky/engine/platform/fonts/fuchsia/FontCacheFuchsia.cpp:136:53: error: no member named 'createFromData' in 'SkFontMgr' > > return sk_sp<SkTypeface>(SkFontMgr::RefDefault()->createFromData(data.get())); > > ~~~~~~~~~~~~~~~~~~~~~~~ ^ > > 1 error generated. > > > > [1] https://luci-logdog.appspot.com/v/?s=fuchsia%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8966486899186212448%2F%2B%2Fsteps%2Fbuild_fuchsia%2F0%2Fsteps%2Fninja%2F0%2Fstdout > > > > Original change's description: > > > remove legacy fontmgr flag from flutter > > > > > > Bug: skia: > > > Change-Id: I82d16b398ea8bb7309378f475d94d9dea0b263d5 > > > Reviewed-on: https://skia-review.googlesource.com/56160 > > > Reviewed-by: Mike Reed <reed@google.com> > > > Commit-Queue: Mike Reed <reed@google.com> > > > > TBR=reed@google.com,reed@chromium.org > > > > Change-Id: I942a9c51dd4673fb2088610ddc2bffd414fbc4d8 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: skia: > > Reviewed-on: https://skia-review.googlesource.com/56320 > > Reviewed-by: Leon Scroggins <scroggo@google.com> > > Commit-Queue: Leon Scroggins <scroggo@google.com> > > TBR=scroggo@google.com,reed@google.com,reed@chromium.org > > Change-Id: Idbb1205e4f7548b683da7d08e9a954fc97be7489 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/56761 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=scroggo@google.com,reed@google.com,reed@chromium.org Change-Id: I43a92fccae128f944ed1c6b57d635db322698545 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/56840 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Revert "remove legacy fontmgr flag from flutter""Gravatar Mike Reed2017-10-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit da6cf4e97ca334b408dda2344b6758970802eddd. Reason for revert: fix landed in flutter Original change's description: > Revert "remove legacy fontmgr flag from flutter" > > This reverts commit 7077ae855519a23b087ded7386e18b475ac73c48. > > Reason for revert: Breaking flutter [1]: > > ../../flutter/sky/engine/platform/fonts/fuchsia/FontCacheFuchsia.cpp:136:53: error: no member named 'createFromData' in 'SkFontMgr' > return sk_sp<SkTypeface>(SkFontMgr::RefDefault()->createFromData(data.get())); > ~~~~~~~~~~~~~~~~~~~~~~~ ^ > 1 error generated. > > [1] https://luci-logdog.appspot.com/v/?s=fuchsia%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8966486899186212448%2F%2B%2Fsteps%2Fbuild_fuchsia%2F0%2Fsteps%2Fninja%2F0%2Fstdout > > Original change's description: > > remove legacy fontmgr flag from flutter > > > > Bug: skia: > > Change-Id: I82d16b398ea8bb7309378f475d94d9dea0b263d5 > > Reviewed-on: https://skia-review.googlesource.com/56160 > > Reviewed-by: Mike Reed <reed@google.com> > > Commit-Queue: Mike Reed <reed@google.com> > > TBR=reed@google.com,reed@chromium.org > > Change-Id: I942a9c51dd4673fb2088610ddc2bffd414fbc4d8 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: skia: > Reviewed-on: https://skia-review.googlesource.com/56320 > Reviewed-by: Leon Scroggins <scroggo@google.com> > Commit-Queue: Leon Scroggins <scroggo@google.com> TBR=scroggo@google.com,reed@google.com,reed@chromium.org Change-Id: Idbb1205e4f7548b683da7d08e9a954fc97be7489 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/56761 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "remove legacy fontmgr flag from flutter"Gravatar Leon Scroggins2017-10-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 7077ae855519a23b087ded7386e18b475ac73c48. Reason for revert: Breaking flutter [1]: ../../flutter/sky/engine/platform/fonts/fuchsia/FontCacheFuchsia.cpp:136:53: error: no member named 'createFromData' in 'SkFontMgr' return sk_sp<SkTypeface>(SkFontMgr::RefDefault()->createFromData(data.get())); ~~~~~~~~~~~~~~~~~~~~~~~ ^ 1 error generated. [1] https://luci-logdog.appspot.com/v/?s=fuchsia%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8966486899186212448%2F%2B%2Fsteps%2Fbuild_fuchsia%2F0%2Fsteps%2Fninja%2F0%2Fstdout Original change's description: > remove legacy fontmgr flag from flutter > > Bug: skia: > Change-Id: I82d16b398ea8bb7309378f475d94d9dea0b263d5 > Reviewed-on: https://skia-review.googlesource.com/56160 > Reviewed-by: Mike Reed <reed@google.com> > Commit-Queue: Mike Reed <reed@google.com> TBR=reed@google.com,reed@chromium.org Change-Id: I942a9c51dd4673fb2088610ddc2bffd414fbc4d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/56320 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Leon Scroggins <scroggo@google.com>
* remove legacy fontmgr flag from flutterGravatar Mike Reed2017-10-05
| | | | | | | | Bug: skia: Change-Id: I82d16b398ea8bb7309378f475d94d9dea0b263d5 Reviewed-on: https://skia-review.googlesource.com/56160 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert[4] "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"Gravatar Mike Reed2017-10-03
| | | | | | | | | | This reverts commit 5a2e50edc51006ce91366e177a9d21a16775d7fd. Bug: skia: Change-Id: I8d28b5c07d90130e5a1653923740eaf189ecb954 Reviewed-on: https://skia-review.googlesource.com/53900 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Revert "Revert "guard old apis for querying byte-size of a ↵Gravatar Mike Reed2017-10-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | bitmap/imageinfo/pixmap""" This reverts commit cd284c532376d16fcc4ed75baf3da65c3e4a2e95. Reason for revert: assert fired in SkMallocPixelRef.cpp:61: fatal error: "assert(info.computeByteSize(rowBytes) == info.getSafeSize(rowBytes))" google3 thinks it was from surface_rowbytes Original change's description: > Revert "Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"" > > This reverts commit 809cbedd4b252be221b2ac3b4269d312fd8f53a0. > > Bug: skia: > Change-Id: I680d8daeeeeb15526b44c1305d8fb0c6bfa38e1d > Reviewed-on: https://skia-review.googlesource.com/52665 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Florin Malita <fmalita@chromium.org> TBR=fmalita@chromium.org,reed@google.com Change-Id: I41e3f7a3f791cc8183291847e783ed8a53bc91d2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/53802 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Revert "Revert "guard old apis for querying byte-size of a ↵Gravatar Mike Reed2017-10-02
| | | | | | | | | | | | bitmap/imageinfo/pixmap"" This reverts commit 809cbedd4b252be221b2ac3b4269d312fd8f53a0. Bug: skia: Change-Id: I680d8daeeeeb15526b44c1305d8fb0c6bfa38e1d Reviewed-on: https://skia-review.googlesource.com/52665 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org>
* Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"Gravatar Jim Van Verth2017-09-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 88757dacd4f532a0f647c02ae0ee596d31ab5c68. Reason for revert: Still seems to be failing Chromium "telemetry_perf_unittests (with patch) on Android" on android_n5x_swarming_rel. Original change's description: > guard old apis for querying byte-size of a bitmap/imageinfo/pixmap > > Now with legacy behavior for allocpixels > > This was reverted, so the current CL is a "fix" on top of ... > https://skia-review.googlesource.com/c/skia/+/50980 > > Related update to Chrome (in preparation for this change) > https://chromium-review.googlesource.com/c/chromium/src/+/685719 > > Bug: skia: > Change-Id: I4b370ee7e95083ab27421f008132219c9c7b86e9 > Reviewed-on: https://skia-review.googlesource.com/51341 > Reviewed-by: Florin Malita <fmalita@chromium.org> > Commit-Queue: Mike Reed <reed@google.com> TBR=fmalita@chromium.org,reed@google.com Change-Id: I827a0ca1d1e3909e648fde3342cdb8601d34da8d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/52381 Reviewed-by: Jim Van Verth <jvanverth@google.com> Commit-Queue: Jim Van Verth <jvanverth@google.com>
* guard old apis for querying byte-size of a bitmap/imageinfo/pixmapGravatar Mike Reed2017-09-27
| | | | | | | | | | | | | | | | Now with legacy behavior for allocpixels This was reverted, so the current CL is a "fix" on top of ... https://skia-review.googlesource.com/c/skia/+/50980 Related update to Chrome (in preparation for this change) https://chromium-review.googlesource.com/c/chromium/src/+/685719 Bug: skia: Change-Id: I4b370ee7e95083ab27421f008132219c9c7b86e9 Reviewed-on: https://skia-review.googlesource.com/51341 Reviewed-by: Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@google.com>
* Revert "guard old apis for querying byte-size of a bitmap/imageinfo/pixmap"Gravatar Greg Daniel2017-09-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 98a6216b18b57c2f7a0d58f542c60503686aed69. Reason for revert: breaking the chrome roll. Looks like they may be writing data to create an image across all the row bytes and thus writing to unalloced data on the last row. Link to example failing bot: https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/539960 Original change's description: > guard old apis for querying byte-size of a bitmap/imageinfo/pixmap > > Previously we had size_t and uint64_t variations. > > The new (simpler) API always.. > - returns size_t, or 0 if the calculation overflowed > - returns the trimmed size (does not include rowBytes padding for the last row) > > Bug: skia: > Change-Id: I05173e877918327c7b207d2f7f1ab0db36892e2e > Reviewed-on: https://skia-review.googlesource.com/50980 > Commit-Queue: Mike Reed <reed@google.com> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Reviewed-by: Leon Scroggins <scroggo@google.com> TBR=mtklein@google.com,herb@google.com,scroggo@google.com,fmalita@chromium.org,reed@google.com Change-Id: I726f6ab1b36b14979ba6f37105e0a469b3f0dbc0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia: Reviewed-on: https://skia-review.googlesource.com/51262 Reviewed-by: Greg Daniel <egdaniel@google.com> Commit-Queue: Greg Daniel <egdaniel@google.com>
* guard old apis for querying byte-size of a bitmap/imageinfo/pixmapGravatar Mike Reed2017-09-26
| | | | | | | | | | | | | | | Previously we had size_t and uint64_t variations. The new (simpler) API always.. - returns size_t, or 0 if the calculation overflowed - returns the trimmed size (does not include rowBytes padding for the last row) Bug: skia: Change-Id: I05173e877918327c7b207d2f7f1ab0db36892e2e Reviewed-on: https://skia-review.googlesource.com/50980 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Florin Malita <fmalita@chromium.org> Reviewed-by: Leon Scroggins <scroggo@google.com>
* Revert "Revert "migrate to sk_sp for SkFontMgr API""Gravatar Mike Reed2017-09-26
| | | | | | | | | | This reverts commit f40ae1a4b5365620463bd63b5140bd3fc78894a1. Bug: skia: Change-Id: I752606de92ea405d6e50219c98030409b00a2841 Reviewed-on: https://skia-review.googlesource.com/51160 Reviewed-by: Mike Reed <reed@google.com> Commit-Queue: Mike Reed <reed@google.com>
* Add GN arg to allow Flutter-specific API guardsGravatar Brian Osman2017-07-14
Bug: skia: Change-Id: I5a97da664626eebf30bba3f391fff0d8b9e62ea5 Reviewed-on: https://skia-review.googlesource.com/23042 Reviewed-by: Leon Scroggins <scroggo@google.com> Commit-Queue: Ravi Mistry <rmistry@google.com>