Commit message (Collapse) | Author | Age | |
---|---|---|---|
* | GM: some header cleanup | 2017-03-22 | |
| | | | | | | | | | | | | | | gm.h includes sk_tool_utils.h but does not use it. The bulk of this CL makes each gm that uses sk_tool_utils include it. sk_tool_utils.h also provided SkRandom and SkTDArray, so a couple GMs add those headers too. Change-Id: Ieb2a7c542f0ca89c3223f744fc11b0ff37af36c1 Reviewed-on: https://skia-review.googlesource.com/10014 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by: Herb Derby <herb@google.com> | ||
* | Replace a lot of 'static const' with 'constexpr' or 'const'. | 2016-09-01 | |
| | | | | | | | | | | | | | | | | | | | | | | | 'static const' means, there must be at most one of these, and initialize it at compile time if possible or runtime if necessary. This leads to unexpected code execution, and TSAN* will complain about races on the guard variables. Generally 'constexpr' or 'const' are better choices. Neither can cause races: they're either intialized at compile time (constexpr) or intialized each time independently (const). This CL prefers constexpr where possible, and uses const where not. It even prefers constexpr over const where they don't make a difference... I want to have lots of examples of constexpr for people to see and mimic. The scoped-to-class static has nothing to do with any of this, and is not changed. * Not yet on the bots, which use an older TSAN. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2300623005 Review-Url: https://codereview.chromium.org/2300623005 | ||
* | Add new GM to exercise stroked line special case | 2016-05-31 | |
This is a companion to: https://codereview.chromium.org/2023693002/ (Handle stroked single line special case in Ganesh) The idea is to land this CL first so any regressions are visible. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2019193002 Review-Url: https://codereview.chromium.org/2019193002 |