| Commit message (Collapse) | Author | Age |
... | |
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes every case where virtual and SK_OVERRIDE were on the same line,
which should be the bulk of cases. We'll have to manually clean up the rest
over time unless I level up in regexes.
for f in (find . -type f); perl -p -i -e 's/virtual (.*)SK_OVERRIDE/\1SK_OVERRIDE/g' $f; end
BUG=skia:
Review URL: https://codereview.chromium.org/806653007
|
|
|
|
|
|
| |
This appears to have been missed in https://codereview.chromium.org/831253002/ (move remaining virtual draw methods to onDraw)
Review URL: https://codereview.chromium.org/839433002
|
|
|
|
|
|
|
|
|
| |
This program takes a list of Skia Picture (SKP) files and
renders each as a multipage PDF, then prints out the MD5
checksum of the PDF file. This can be used to verify that
changes to the PDF backend will not change PDF output.
Review URL: https://codereview.chromium.org/832403002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/830083002
|
|
|
|
|
|
|
|
| |
Just noticed these were still here.
BUG=skia:
Review URL: https://codereview.chromium.org/801373003
|
|
|
|
|
|
| |
BUG=3245
Review URL: https://codereview.chromium.org/803913005
|
|
|
|
| |
Review URL: https://codereview.chromium.org/801413002
|
|
|
|
|
|
| |
R=mtklein@google.com, reed@google.com, robertphillips@google.com
Review URL: https://codereview.chromium.org/789033002
|
|
|
|
|
|
| |
Causing compilation complaints on Windows
Review URL: https://codereview.chromium.org/783683004
|
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=
NOTRY=True
Review URL: https://codereview.chromium.org/774863003
|
|
|
|
|
|
| |
BUG=skia:3184
Review URL: https://codereview.chromium.org/775763003
|
|
|
|
| |
Review URL: https://codereview.chromium.org/769423002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/769083003
|
|
|
|
|
|
|
|
|
|
|
| |
There is already an GYP version for it in:
https://skia.googlesource.com/skia/+/master/gyp/SimpleiOSApp.gyp
BUG=None
TEST=None
R=caryclark@google.com
Review URL: https://codereview.chromium.org/691133004
|
|
|
|
|
|
|
|
|
|
| |
working
The key here was to get everything into a single library. Our shared library build is the easiest way to do that. Some light skimming online makes it look like perhaps cgo requires shared libraries, so that may be at play here too.
BUG=skia:
Review URL: https://codereview.chromium.org/698943002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/670303005
|
|
|
|
|
|
|
|
|
|
|
| |
Since GrPrintf is just defined to SkDebugf, we can go with the later
directly.
BUG=None
TEST=None
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/695663003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/688713002
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=jcgregorio
Review URL: https://codereview.chromium.org/688003002
|
|
|
|
|
|
|
|
|
|
|
| |
You can now select Raster, Ganesh, or both (PDF coming soon), and see
all output simultaneously.
BUG=skia:
R=jcgregorio@google.com
TBR=jcgregorio
Review URL: https://codereview.chromium.org/688433002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/661033005
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We decided last week that GPU rendering wouldn't be associated
with the fiddle itself; options in the left bar will be split into
ones that are bound to the fiddle (so appear in the hash and database)
and ones that are run-specific (like the rendering mode).
This will leave us better placed to do things like rendering in multiple
modes at once.
BUG=skia:
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/685543002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds DrawingMethods with some of the methods it defines. Context is now
an implementation of DrawingMethods.
The sample.js file now shows how the context is used.
Not much new code here, that's mostly in DrawingMethods::DrawPath, most everything else is a code move.
BUG=skia:
Review URL: https://codereview.chromium.org/676423002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/680053002
|
|
|
|
| |
Review URL: https://codereview.chromium.org/677133002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
should have to begin with.
Also:
- SkWindow now has createSurface, not createCanvas.
- Add the platform init code v8 now seems to require.
- Fix library linkage.
- Call isolate->Enter(); because it doesn't look
like v8 starts with a default isolate to begin with.
BUG=skia:
Review URL: https://codereview.chromium.org/673223002
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/665203004
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/637263004
|
|
|
|
|
|
|
|
|
|
|
| |
In case they fail, lets fail with an ERROR message rather than an INFO,
and lets make the error message a little bit better.
BUG=None
TEST=None
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/669643004
|
|
|
|
|
|
|
|
|
| |
Otherwise the --log_dir flag doesn't affect where glog output goes to.
TBR=humper
BUG=skia:
Review URL: https://codereview.chromium.org/667493002
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This setup and runs a logserver, like the one being used by skiaperf, to
serve the directory /tmp/glog, so we don't need to ssh into the instance
to see the logs of the webtry application.
This is a follow up to suggestion made in codereview.chromium.org/655323002.
BUG=None
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/643903003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/644253003
|
|
|
|
|
|
|
|
|
| |
You can also click on the errors in the parsed output to jump directly to the offending location in the editor.
BUG=skia:
NOTRY=true
Review URL: https://codereview.chromium.org/660573003
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should prevent further enumeration according to the docs.
http://golang.org/pkg/database/sql/#Rows.Close
BUG=None
TEST=None
R=humper@google.com
Review URL: https://codereview.chromium.org/638373003
|
|
|
|
|
|
|
|
|
|
| |
Update it to use glog variant.
BUG=skia:2980
TEST=go build webtry.go
TBR=jcgregorio@google.com
Review URL: https://codereview.chromium.org/659813003
|
|
|
|
|
|
|
|
| |
BUG=skia:2980
TEST=go get -d && go build webtry.go
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/655323002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As mentioned in http://golang.org/doc/effective_go.html#blank_assign,
errors are provided for a reason, so always check them.
The documentation for this function is available at
http://golang.org/pkg/os/#Chdir.
BUG=None
TEST=None
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/651343002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
text/template and html/template both have a helper function called
"Must" that according to the docs in http://golang.org/pkg/text/template/#Must
and http://golang.org/pkg/html/template/#Must, wraps a call to a function
returning (*Template, error) and panics if the error is non-nil.
So we don't need to that ourselves. Which is a good thing and makes code
cleaner.
BUG=None
TEST=None
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/642243004
|
|
|
|
|
|
|
|
|
| |
space available to a fiddle because linking against libGL causes the
amount of memory used by a process to bloat to over 100M. Yikes.
BUG=skia:
Review URL: https://codereview.chromium.org/638003008
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of https://codereview.chromium.org/649313002/)
Reason for revert:
adding -Dskia_mesa=1 broke production; don't yet know why and don't want to leave things in a broken state.
Original issue's description:
> add ganesh checkbox to skfiddle interface
>
> BUG=skia:
> R=mtklein@google.com, tfarina@chromium.org
>
> Committed: https://skia.googlesource.com/skia/+/ccb54895c614632fd01d22b64ab614921f980eb1
TBR=tfarina@chromium.org,jcgregorio@google.com,mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/655633003
|
|
|
|
|
|
|
| |
BUG=skia:
R=mtklein@google.com, tfarina@chromium.org
Review URL: https://codereview.chromium.org/649313002
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=NOne
R=humper@google.com
TBR=humper@google.com
Review URL: https://codereview.chromium.org/648563003
|
|
|
|
|
|
|
| |
BUG=skia:
R=jcgregorio@google.com
Review URL: https://codereview.chromium.org/656463002
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
That seems to make things more tied and that seems to be where we have
the same scripts/configs in the perf directory:
https://skia.googlesource.com/buildbot/+/master/perf/setup/sys/
That way we keep all files used/related to setting up a new webtry server in one place.
BUG=None
TEST=None
R=humper@google.com
Review URL: https://codereview.chromium.org/644513003
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=jcgregorio
Review URL: https://codereview.chromium.org/637353003
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous version of the script didn't properly update the code for the webtry
user, so only changes to skia would really be pulled, not changes to the actual
webtry server itself.
This version of the setup script is 100% automated and brings everything up to date.
It's also a little more verbose about what it's doing, so it's easier to debug.
BUG=skia:
R=tfarina@chromium.org
TBR=jcgregorio, mtklein, tfarina
Review URL: https://codereview.chromium.org/636173003
|
|
|
|
|
|
| |
BUG=skia:
Review URL: https://codereview.chromium.org/639013002
|
|
|
|
|
|
|
| |
BUG=skia:
TBR=jcgregorio
Review URL: https://codereview.chromium.org/635373002
|
|
|
|
|
|
|
| |
BUG=skia:2998
TBR=jcgregorio, tfarina
Review URL: https://codereview.chromium.org/639833003
|
|
|
|
|
|
| |
Mainly just to familiarize myself with this code.
Review URL: https://codereview.chromium.org/633183002
|