aboutsummaryrefslogtreecommitdiffhomepage
Commit message (Collapse)AuthorAge
* Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.Gravatar djsollen2016-04-29
| | | | | | | | | | | | | The Release_Developer build type is now used to build Skia with release level optimizations but still enable SK_DEBUG. This in turn means that SkASSERTS and SkRTConf are available in this mode. Further we can then remove SK_DEVELOPER as a define as it is true iff SK_DEBUG is true. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1931903002 DOCS_PREVIEW= https://skia.org/?cl=1931903002 Review-Url: https://codereview.chromium.org/1931903002
* Make stencils be attachable to render targets created via ↵Gravatar kkinnunen2016-04-29
| | | | | | | | | | | | | | | | | | | | | | SkSurface::MakeFromBackendTextureAsRenderTarget This is a regression from "Refactor to separate backend object lifecycle and GpuResource budget decision". GrGLRenderTarget::CreateWrapped creates only render targets that wrap the FBO. GrGLRenderTargetTexture::CreateWrapped creates render targets that wrap the texture. Use the latter as the implementation for SkSurface::MakeFromBackendTextureAsRenderTarget. The test contains disabled code. The MakeFromBackendTextureAsRenderTarget does not copy the existing texture contents to the FBO render buffer. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1924183003 Review-Url: https://codereview.chromium.org/1924183003
* Whitespace change to test botsGravatar borenet2016-04-29
| | | | | | | | | NOTREECHECKS=true TBR=rmistry BUG=skia:4763 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1936543002 Review-Url: https://codereview.chromium.org/1936543002
* Adjust tolerance to fix bezier glitches issueGravatar xidachen2016-04-28
| | | | | | | | | | | | | | | | In a previous CL: https://codereview.chromium.org/1126793003, the value of gDegenerateToLineTol was changed from 1.0 to 0.25 which caused the bezier glitches. This CL changes the value to SK_ScalarRoot2Over2, with this change the bezier curve looks fine, and the result of the layout tests pointed out in this bug: https://bugs.chromium.org/p/chromium/issues/detail?id=472847 is also reasonable. BUG=605439 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926063002 Review-Url: https://codereview.chromium.org/1926063002
* Tighten up SkSpecialSurface factory functionsGravatar robertphillips2016-04-28
| | | | | | | | This is split out of https://codereview.chromium.org/1930013002/ ((Mostly) Retract GrRenderTarget from SkGpuDevice) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1925313002 Review-Url: https://codereview.chromium.org/1925313002
* Clean up test drawContext usageGravatar robertphillips2016-04-28
| | | | | | | | The general idea is to provide access to SkGpuDevice's drawContext rather than its GrRenderTarget. That is usually what the testing framework actually wants. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1930623003 Review-Url: https://codereview.chromium.org/1930623003
* Remove skstd::is_convertible.Gravatar bungeman2016-04-28
| | | | | | | | | We should now be able to use std::is_convertible. TBR=reed@google.com This doesn't change any API, just where we get a type trait from. Review-Url: https://codereview.chromium.org/1931003002
* Update Win toolchainGravatar mtklein2016-04-28
| | | | | | | | | | | | | I believe this now correctly updates us to VS 2015 update 2. CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Win-MSVC-x86-Debug-VS2015-Trybot https://isolateserver.appspot.com/browse?namespace=default-gzip&digest=3c710fd7f4df8ec24fde62681536fad21be2751c BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926813007 Review-Url: https://codereview.chromium.org/1926813007
* Refactor drawContext/RenderTarget creationGravatar robertphillips2016-04-28
| | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1914883002 Committed: https://skia.googlesource.com/skia/+/2f1c42e8448bbbadeb3df1c626faa90aa33f8907 Review-Url: https://codereview.chromium.org/1914883002
* Delete unused code from SkColorSpaceGravatar msarett2016-04-28
| | | | | | | | | | | | | | | | IMO, a lot of this code reflects an oversimplified view of handling color profiles. And a lot of this code is valid math/checks/enums that we will eventually need. Right now, it's all unused and is adding a bit of clutter and confusion as I try to redesign this object. I think it makes sense to start simpler and build this back up as necessary. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1932743002 Review-Url: https://codereview.chromium.org/1932743002
* Parse A2B0 tag on ICC profilesGravatar msarett2016-04-28
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1925753002 Review-Url: https://codereview.chromium.org/1925753002
* Stop printing warnings about ADB versionGravatar borenet2016-04-28
| | | | | | | BUG=skia:5156 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927973002 Review-Url: https://codereview.chromium.org/1927973002
* remove (now unused) SkDivBitsGravatar reed2016-04-28
| | | | | | | | | needs https://codereview.chromium.org/1927823002/ to land first BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1925913002 Review-Url: https://codereview.chromium.org/1925913002
* Detect empty (r)rects in GrShape.Gravatar bsalomon2016-04-28
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1929643002 Review-Url: https://codereview.chromium.org/1929643002
* Fix vulkan build on linux and androidGravatar egdaniel2016-04-28
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1921963003 Review-Url: https://codereview.chromium.org/1921963003
* Revert of Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER. ↵Gravatar reed2016-04-28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #2 id:20001 of https://codereview.chromium.org/1927583002/ ) Reason for revert: still blocking DEPS roll Original issue's description: > Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER. > > The Release_Developer build type is now used to build Skia with > release level optimizations but still enable SK_DEBUG. This in turn > means that SkASSERTS and SkRTConf are available in this mode. > > Further we can then remove SK_DEVELOPER as a define as it is true > iff SK_DEBUG is true. > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927583002 > DOCS_PREVIEW= https://skia.org/?cl=1927583002 > > Committed: https://skia.googlesource.com/skia/+/48d6f88479e72efaf9b9d8f9c0769acb1ba773db TBR=bungeman@gmail.com,bungeman@google.com,benjaminwagner@google.com,djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/1918253006
* Revert of fix build by using ifdef instead of if for SK_DEBUG (patchset #1 ↵Gravatar reed2016-04-28
| | | | | | | | | | | | | | | | | | | | | | | | | id:1 of https://codereview.chromium.org/1924943003/ ) Reason for revert: need to revert main change for now Original issue's description: > fix build by using ifdef instead of if for SK_DEBUG > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1924943003 > > TBR= > NOTRY=True > > Committed: https://skia.googlesource.com/skia/+/b8498825b54718cdd90c30c39323cfc433695f23 TBR=djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/1927113002
* Revert of Refactor drawContext/RenderTarget creation (patchset #8 id:140001 ↵Gravatar robertphillips2016-04-28
| | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/1914883002/ ) Reason for revert: Experimental revert to see if this is blocking the DEPS roll. Original issue's description: > Refactor drawContext/RenderTarget creation > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1914883002 > > Committed: https://skia.googlesource.com/skia/+/2f1c42e8448bbbadeb3df1c626faa90aa33f8907 TBR=bsalomon@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/1929833004
* BUG=skia:Gravatar reed2016-04-27
| | | | | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1924943003 TBR= NOTRY=True Review-Url: https://codereview.chromium.org/1924943003
* remove SK_SUPPORT_LEGACY_DIVBITS_UB -- chrome no longer defines thisGravatar reed2016-04-27
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927823002 TBR=mtklein@google.com Review-Url: https://codereview.chromium.org/1927823002
* Enable flattening of SkRecordedDrawableGravatar msarett2016-04-27
| | | | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1913843002 Committed: https://skia.googlesource.com/skia/+/d636950e8ecba89c0021ce4e76037c67aa6ee2cd Review-Url: https://codereview.chromium.org/1913843002
* skip unneeded header from writeFlattenable when building font-cache-key. ↵Gravatar reed2016-04-27
| | | | | | | | | | | Saves ~30% in size BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1924033002 TBR=mtklein Review-Url: https://codereview.chromium.org/1924033002
* adb_wait_for_charge: Don't download toolchainsGravatar borenet2016-04-27
| | | | | | | BUG=skia:5156 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926833003 Review-Url: https://codereview.chromium.org/1926833003
* Make the default android build be release_developer.Gravatar djsollen2016-04-27
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1929663002 Review-Url: https://codereview.chromium.org/1929663002
* Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.Gravatar djsollen2016-04-27
| | | | | | | | | | | | | The Release_Developer build type is now used to build Skia with release level optimizations but still enable SK_DEBUG. This in turn means that SkASSERTS and SkRTConf are available in this mode. Further we can then remove SK_DEVELOPER as a define as it is true iff SK_DEBUG is true. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927583002 DOCS_PREVIEW= https://skia.org/?cl=1927583002 Review-Url: https://codereview.chromium.org/1927583002
* Refactor drawContext/RenderTarget creationGravatar robertphillips2016-04-27
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1914883002 Review-Url: https://codereview.chromium.org/1914883002
* Add tests for volatile paths to GrShapeTestGravatar bsalomon2016-04-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1923403003 Review-Url: https://codereview.chromium.org/1923403003
* Add tests for empty GrShapes.Gravatar bsalomon2016-04-27
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927673002 Review-Url: https://codereview.chromium.org/1927673002
* Simplify style handling in custom font manager.Gravatar bungeman2016-04-27
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915103002 Review-Url: https://codereview.chromium.org/1915103002
* SkDocument::CreateXPS fix rollGravatar halcanary2016-04-27
| | | | | | | NOTRY=true TBR=reed@google.com Review-Url: https://codereview.chromium.org/1918713006
* Remove AttachmentInfo from VulkanViewer setupGravatar jvanverth2016-04-27
| | | | | | | | | It's not necessary to pass this information back up to the client; we can store it in the TestContext if needed for Surface creation. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1920163004 Review-Url: https://codereview.chromium.org/1920163004
* Add work around for vulkan copies on the 5XGravatar egdaniel2016-04-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1923963002 Review-Url: https://codereview.chromium.org/1923963002
* Image filters: de-nest SkImageFilter::Cache and Cache::Key.Gravatar senorblanco2016-04-27
| | | | | | | | | | | This reduces the public header, and also allows us to foward- declare them, so we can remove an #include from all the SkDevice subclass headers. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1919063002 Review-Url: https://codereview.chromium.org/1919063002
* SkPDF/None: fix compilationGravatar halcanary2016-04-27
| | | | | | TBR=stephana@google.com Review-Url: https://codereview.chromium.org/1929593002
* Bring sk_sp to GrDrawContextGravatar robertphillips2016-04-27
| | | | | | | | This is split out of: https://codereview.chromium.org/1914883002/ (Refactor drawContext/RenderTarget creation) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1918003003 Review-Url: https://codereview.chromium.org/1918003003
* Add oblique as a slant.Gravatar bungeman2016-04-27
| | | | | | | | | | | | | Some fonts have italic and oblique in the same family, see http://lucidafonts.com/fonts/family/lucida-sans http://www.gust.org.pl/projects/e-foundry/latin-modern GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1921903002 Chromium side change at https://crrev.com/1921503006/ . Review-Url: https://codereview.chromium.org/1921903002
* Add dry_run_access_list to Skia's cq.protoGravatar rmistry2016-04-27
| | | | | | | | | This will give all users who have access to our trybots access to our dry run CQ as well. BUG=591183 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926783002 Review-Url: https://codereview.chromium.org/1926783002
* Revert of Enable flattening of SkRecordedDrawable (patchset #8 id:140001 of ↵Gravatar mtklein2016-04-27
| | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/1913843002/ ) Reason for revert: Release mode bots appear to be crashing while loading .skp files in nanobench. Original issue's description: > Enable flattening of SkRecordedDrawable > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1913843002 > > Committed: https://skia.googlesource.com/skia/+/d636950e8ecba89c0021ce4e76037c67aa6ee2cd TBR=djsollen@google.com,reed@google.com,msarett@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Review-Url: https://codereview.chromium.org/1923393002
* Enable flattening of SkRecordedDrawableGravatar msarett2016-04-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1913843002 Review-Url: https://codereview.chromium.org/1913843002
* Upgrade Android Gradle pluginsGravatar djsollen2016-04-27
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1926743002 Review-Url: https://codereview.chromium.org/1926743002
* remove 'deprecated' region from SkDrawGravatar reed2016-04-27
| | | | | | | | | | | | | | | Most call-sites that used it just took its bounds, so it was trivial to convert them to get the bounds of the RasterClip. Two clients wanted the actual region: 1. layeriter for android 2. pdf Android already only has BW clips, so should be safe. PDF now overrides its clip methods to ensure that all clips are BW. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1925693002 Review URL: https://codereview.chromium.org/1925693002
* SkDocument/PDF: new APIGravatar halcanary2016-04-27
| | | | | | | | | | has a pdf/a switch. sets metadata in factory. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1916093002 Review URL: https://codereview.chromium.org/1916093002
* tools/pdf-comparison.sh: stop relying on /usr/bin/timeoutGravatar halcanary2016-04-27
| | | | | | | NOTRY=true TBR= Review URL: https://codereview.chromium.org/1921943006
* Treat kIncompleteInput as successes in get_images_from_skpsGravatar rmistry2016-04-27
| | | | | | | | | | | | Context: https://bugs.chromium.org/p/skia/issues/detail?id=5226 and https://codereview.chromium.org/1844713003/diff/160001/tools/get_images_from_skps.cpp#newcode83 BUG=skia:5226 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1917413003 Review URL: https://codereview.chromium.org/1917413003
* Disable ReadWriteAlpha on TSANGravatar stephana2016-04-27
| | | | | | | | BUG=skia: R=borenet GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1927573002 Review URL: https://codereview.chromium.org/1927573002
* Add support for building GrShape from SkPath and more testsGravatar bsalomon2016-04-27
| | | | | | GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922713002 Review URL: https://codereview.chromium.org/1922713002
* Add comments and sanity checks to parsing of ICC headersGravatar msarett2016-04-27
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1922073003 Review URL: https://codereview.chromium.org/1922073003
* Don't isolate the Skia repo for Swarming compilesGravatar borenet2016-04-27
| | | | | | | | BUG=skia: NOTREECHECKS=true GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1886343002 Review URL: https://codereview.chromium.org/1886343002
* Change default window size on Windows.Gravatar brianosman2016-04-26
| | | | | | | | | | The OS tends to pick a very large size if you let it. Instead, choose a smaller (fixed) window (matching what we currently use on Linux). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1919133004 Review URL: https://codereview.chromium.org/1919133004
* Ensure we're operating on the correct texture when generating mipmaps.Gravatar brianosman2016-04-26
| | | | | | | BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1915403004 Review URL: https://codereview.chromium.org/1915403004
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-04 15:15:13 +0000